[Vertical Tabs] Test the real tab strip in TabCollectionNodeBrowserTest [chromium/src : main]
0 views
Skip to first unread message
Tom Lukaszewicz (Gerrit)
12:34 AM (3 hours ago) 12:34 AM
to Eshwar Stalin, chromium...@chromium.org
Attention needed from Eshwar Stalin
Tom Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Eshwar Stalin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eshwar Stalin (Gerrit)
12:45 AM (3 hours ago) 12:45 AM
to Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tom Lukaszewicz
Eshwar Stalin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
1:12 AM (2 hours ago) 1:12 AM
to Eshwar Stalin, Chromium LUCI CQ, chromium...@chromium.org
Tom Lukaszewicz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:24 AM (2 hours ago) 1:24 AM
to Tom Lukaszewicz, Eshwar Stalin, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Vertical Tabs] Test the real tab strip in TabCollectionNodeBrowserTest
TabCollectionNodeBrowserTests currently leverage elements of the
InProcessBrowserTest environment (such as the default browser and
its associated tab strip APIs) - but instantiate a makeshift
RootTabCollectionNode with a View hierarchy anchored to a
parent_view with no associated Widget.
The current test setup and configuration is not representative of
a real browser environment, e.g. invariants that hold in production
have been seen to fail in these test cases. Further the setup makes
it confusing to understand exactly what is being tested.
This CL updates the fixture to inherit from the
VerticalTabsBrowserTestMixin (which aligns with other browser tests
in this directory) and instantiates a real vertical tab strip
for testing.
Helpers have been added to allow access to the root node and view. Test
cases have been updated to leverage the new helpers in the fixture but
are otherwise unchanged.
ViewFactory and associated APIs has been removed from TabCollectionNode
as this existed only to service the makeshift instantiation of the
vertical tab strip mentioned above.
Bug: 459824840
Change-Id: I36ec1488a668ad99594bbfa2f0fc59dc6b0baf8c
Reviewed-by: Eshwar Stalin <est...@chromium.org>
Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568924}
Files:
- M chrome/browser/ui/views/tabs/vertical/tab_collection_node.cc
- M chrome/browser/ui/views/tabs/vertical/tab_collection_node.h
- M chrome/browser/ui/views/tabs/vertical/tab_collection_node_browsertest.cc
Change size: L
Delta: 3 files changed, 120 insertions(+), 328 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eshwar Stalin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages