Import maps: use wpt_internal for parsing unit tests [chromium/src : main]
0 views
Skip to first unread message
Domenic Denicola (Gerrit)
Aug 8, 2022, 4:10:24 AM8/8/22
to blink-...@chromium.org, Hiroshige Hayashizaki, Chromium LUCI CQ, chromium...@chromium.org
Attention is currently required from: Hiroshige Hayashizaki.
To view, visit change 3815111. To unsubscribe, or for help writing mail filters, visit settings.
Hiroshige Hayashizaki (Gerrit)
Aug 8, 2022, 4:47:27 PM8/8/22
to Domenic Denicola, blink-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org
Attention is currently required from: Domenic Denicola.
Patch set 1:Code-Review +1
1 comment:
Commit Message:
Patch Set #1, Line 9:
A previous CLCould you explicitly link to https://chromium-review.googlesource.com/c/chromium/src/+/3816001/?
To view, visit change 3815111. To unsubscribe, or for help writing mail filters, visit settings.
Domenic Denicola (Gerrit)
Aug 8, 2022, 10:56:17 PM8/8/22
to blink-...@chromium.org, Hiroshige Hayashizaki, Chromium LUCI CQ, chromium...@chromium.org
1 comment:
Commit Message:
Patch Set #1, Line 9:
A previous CL
Could you explicitly link to https://chromium-review.googlesource. […]
Done
To view, visit change 3815111. To unsubscribe, or for help writing mail filters, visit settings.
Domenic Denicola (Gerrit)
Aug 9, 2022, 12:25:30 AM8/9/22
to blink-...@chromium.org, Hiroshige Hayashizaki, Chromium LUCI CQ, chromium...@chromium.org
Patch set 3:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Aug 9, 2022, 12:31:51 AM8/9/22
to Domenic Denicola, blink-...@chromium.org, Hiroshige Hayashizaki, chromium...@chromium.org
Chromium LUCI CQ submitted this change.
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Approvals:
Hiroshige Hayashizaki: Looks good to me
Domenic Denicola: Commit
Import maps: use wpt_internal for parsing unit tests
https://chromium-review.googlesource.com/c/chromium/src/+/3816001/ removed the test coverage in wpt/external for parsing import maps. Although we plan to eventually convert those tests into resolution tests, it's still nice to have unit test-like coverage for our import map parser, so this CL copies over the data files in their current form and creates a small harness for directly testing them.
Change-Id: I40837cb336e721e6e52c5f959a46c9220e225edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3815111
Commit-Queue: Domenic Denicola <dom...@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiro...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032873}
---
A third_party/blink/web_tests/wpt_internal/import-maps/README.md
A third_party/blink/web_tests/wpt_internal/import-maps/parsing.html
A third_party/blink/web_tests/wpt_internal/import-maps/resources/parsing-addresses-absolute.json
A third_party/blink/web_tests/wpt_internal/import-maps/resources/parsing-addresses-invalid.json
A third_party/blink/web_tests/wpt_internal/import-maps/resources/parsing-addresses.json
A third_party/blink/web_tests/wpt_internal/import-maps/resources/parsing-invalid-json.json
A third_party/blink/web_tests/wpt_internal/import-maps/resources/parsing-schema-normalization.json
A third_party/blink/web_tests/wpt_internal/import-maps/resources/parsing-schema-scope.json
A third_party/blink/web_tests/wpt_internal/import-maps/resources/parsing-schema-specifier-map.json
A third_party/blink/web_tests/wpt_internal/import-maps/resources/parsing-schema-toplevel.json
A third_party/blink/web_tests/wpt_internal/import-maps/resources/parsing-scope-keys.json
A third_party/blink/web_tests/wpt_internal/import-maps/resources/parsing-specifier-keys.json
A third_party/blink/web_tests/wpt_internal/import-maps/resources/parsing-trailing-slashes.json
13 files changed, 957 insertions(+), 0 deletions(-)
Reply all
Reply to author
Forward
0 new messages