Site Search: Coordinator destroy refine [chromium/src : main]
0 views
Skip to first unread message
Kay Lin (Gerrit)
May 30, 2026, 1:10:00 AM (2 days ago) May 30
to chromium...@chromium.org
Kay Lin has uploaded the change for review![]( "Open in Gerrit")
Commit message
Site Search: Coordinator destroy refine
This CL refines the destroy() methods of site search related components.
Bug: 518087480
Change-Id: I477c29065cdd644d66503692b040a02b42e93bb8
Change diff
Change information
Files:
- M chrome/browser/search_engines/android/java/src/org/chromium/chrome/browser/search_engines/settings/custom_search_engine/CustomSearchEngineListCoordinator.java
- M chrome/browser/search_engines/android/java/src/org/chromium/chrome/browser/search_engines/settings/custom_site_search/CustomSiteSearchCoordinator.java
- M chrome/browser/search_engines/android/java/src/org/chromium/chrome/browser/search_engines/settings/inactive_shortcut/InactiveShortcutCoordinator.java
Change size: S
Delta: 3 files changed, 5 insertions(+), 5 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kay Lin (Gerrit)
May 31, 2026, 11:29:42 PM (1 hour ago) May 31
to Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Shuhei Takahashi
Kay Lin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kay Lin . resolved
Hi Nya, this is a follow-up CL regarding your suggestion last time about the best practice for the destruction order (bottom to top). PTAL! :)
Related details
Attention is currently required from:
- Shuhei Takahashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages