[WebInstallAPI] Refine error handling to use kDataError [chromium/src : main]

0 views

Skip to first unread message

Kristin Lee (Gerrit)

unread,

Jan 9, 2026, 4:23:25 PM (24 hours ago) Jan 9

to Lia Hiscock, Lu Huang, Robert Paveza, Chromium LUCI CQ, chromium...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Lia Hiscock

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Lia Hiscock

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lia Hiscock (Gerrit)

unread,

Jan 9, 2026, 9:51:03 PM (18 hours ago) Jan 9

to Kristin Lee, Lu Huang, Robert Paveza, Chromium LUCI CQ, chromium...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Kristin Lee

Lia Hiscock voted and added 2 comments

Votes added by Lia Hiscock

Code-Review

2 comments

File chrome/browser/web_applications/web_install_service_impl.cc

Line 585, Patchset 1: .Run(web_app::WebInstallApiResult::kUnexpectedFailure,

Kristin Lee . unresolved

Wondering if it would be helpful to add a new WebInstallApiResult? Such as something like `kRedirectUrlUsed`, `kInstallInfoFetchFailed`? We could add ApiResults for the other InstallResultCodes that were added in lines 706-708?

Lia Hiscock

This is only for background launches so I think for now we're ok without that much granularity.

Line 709, Patchset 1: case webapps::InstallResultCode::kInstallURLRedirected:

Kristin Lee . resolved

Thoughts on firing DataError in the meantime for redirects instead of AbortError? Considering the customer feedback about how it's confusing that AbortError is also fired when the user rejects the install dialog, I thought firing DataError essentially helps signal to developers that their arguments need to be updated which seems more fitting for redirects that currently are supported.

Lia Hiscock

This sounds reasonable.