[iOS] Add Feature Flags And Bridge in Gemini Configuration [chromium/src : main]
0 views
Skip to first unread message
Joemer Ramos (Gerrit)
Feb 6, 2026, 5:39:21 PM (19 hours ago) Feb 6
to Joemer Ramos, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro
Joemer Ramos added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Joemer Ramos . unresolved
I'm not sure if I coded a double feature param properly, can you check that this is right?
Related details
Attention is currently required from:
- Adam Arcaro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Arcaro (Gerrit)
Feb 6, 2026, 5:40:53 PM (19 hours ago) Feb 6
to Joemer Ramos, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Joemer Ramos
Adam Arcaro voted and added 2 comments![]( "Open in Gerrit")
Votes added by Adam Arcaro
| Code-Review | +1 |
2 comments
Patchset-level comments
Adam Arcaro . resolved
Thanks!
File ios/chrome/browser/flags/about_flags.mm
Line 2592, Patchset 1 (Latest):
{"gemini-response-view-dynamic-resizing",Adam Arcaro . unresolved
This should be added at the end of the list
Related details
Attention is currently required from:
- Joemer Ramos
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joemer Ramos (Gerrit)
Feb 6, 2026, 6:10:49 PM (19 hours ago) Feb 6
to Joemer Ramos, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Joemer Ramos voted and added 2 comments![]( "Open in Gerrit")
Votes added by Joemer Ramos
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Joemer Ramos . resolved
Can you double check i did the params right?
File ios/chrome/browser/flags/about_flags.mm
This should be added at the end of the list
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Arcaro (Gerrit)
Feb 6, 2026, 6:24:23 PM (18 hours ago) Feb 6
to Joemer Ramos, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Joemer Ramos
Adam Arcaro voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Arcaro
| Code-Review | +1 |
1 comment
Patchset-level comments
Joemer Ramos . resolved
Can you double check i did the params right?
Attention is currently required from:
- Joemer Ramos
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joemer Ramos (Gerrit)
Feb 6, 2026, 6:27:26 PM (18 hours ago) Feb 6
to Joemer Ramos, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Joemer Ramos voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joemer Ramos (Gerrit)
Feb 6, 2026, 6:28:22 PM (18 hours ago) Feb 6
to Joemer Ramos, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Joemer Ramos added 1 comment![]( "Open in Gerrit")
Patchset-level comments
I'm not sure if I coded a double feature param properly, can you check that this is right?
Joemer Ramos
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joemer Ramos (Gerrit)
Feb 6, 2026, 6:28:36 PM (18 hours ago) Feb 6
to Joemer Ramos, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Joemer Ramos voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
9:01 AM (4 hours ago) 9:01 AM
to Joemer Ramos, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro and Joemer Ramos
Justin Cohen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Adam Arcaro
- Joemer Ramos
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joemer Ramos (Gerrit)
9:01 AM (4 hours ago) 9:01 AM
to Joemer Ramos, Justin Cohen, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro
Joemer Ramos voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Adam Arcaro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:08 AM (4 hours ago) 9:08 AM
to Joemer Ramos, Justin Cohen, Adam Arcaro, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Add Feature Flags And Bridge in Gemini Configuration
Adds a feature flag for the response ready interval and dynamic
resizing flag and adds it to `GeminiConfiguration`.
Bug: 482310970
Change-Id: Ie54cba91b265c51f136c6c81e66453a90c154f5a
Reviewed-by: Justin Cohen <justi...@google.com>
Commit-Queue: Joemer Ramos <joeme...@google.com>
Cr-Commit-Position: refs/heads/main@{#1581339}
Files:
- M chrome/browser/flag-metadata.json
- M ios/chrome/browser/flags/about_flags.mm
- M ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
- M ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
- M ios/chrome/browser/intelligence/bwg/model/gemini_browser_agent.mm
- M ios/chrome/browser/intelligence/bwg/model/gemini_configuration.h
- M ios/chrome/browser/intelligence/features/features.h
- M ios/chrome/browser/intelligence/features/features.mm
Change size: M
Delta: 8 files changed, 69 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Justin Cohen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joemer Ramos (Gerrit)
9:13 AM (4 hours ago) 9:13 AM
to Chromium LUCI CQ, Joemer Ramos, Justin Cohen, Adam Arcaro, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Joemer Ramos added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Joemer Ramos . resolved
**NOTE** The description for this CL wasn't updated, this is adding one feature flag for dynamic resizing and one feature flag **param** for `ResponseReadyInverval`
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages