Revert "[AIM] Adjust button sizes and lots of padding/margin." [chromium/src : main]

0 views
Skip to first unread message

Sky Malice (Gerrit)

unread,
6:01 PM (3 hours ago) 6:01 PM
to Tomasz Wiszkowski, Jian Li, Chromium LUCI CQ, Patrick Noland, Code Review Nudger, chromium...@chromium.org
Attention needed from Jian Li, Patrick Noland and Tomasz Wiszkowski

Sky Malice has uploaded the change for review

Sky Malice would like Tomasz Wiszkowski, Jian Li, Chromium LUCI CQ and Patrick Noland to review this change.

Commit message

Revert "[AIM] Adjust button sizes and lots of padding/margin."

This reverts commit 664cb17b9b2cf3469307c1319d94ce80404c41c2.

Reason for revert: Introduced a alignment aliment bug that we are not fixing for now. Reverting this to have worse padding but better alignment.

Original change's description:
> [AIM] Adjust button sizes and lots of padding/margin.
>
> Bug: 465529802, 463351051, 467054502
> Change-Id: Ib97771dec229a62bf2dc9f916bbad30ce3359839
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7272464
> Reviewed-by: Patrick Noland <pno...@chromium.org>
> Reviewed-by: Tomasz Wiszkowski <en...@google.com>
> Commit-Queue: Sky Malice <sk...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1568142}
Bug: 465529802, 463351051, 467054502
Change-Id: Iba6a2e0606c158d84ae308fb9747a224841c5373

Change diff


Change information

Files:
  • M chrome/browser/ui/android/omnibox/java/res/layout/fusebox_layout.xml
  • M chrome/browser/ui/android/omnibox/java/res/values/dimens.xml
  • M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/fusebox/FuseboxViewBinder.java
  • M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/fusebox/FuseboxViewBinderUnitTest.java
Change size: M
Delta: 4 files changed, 13 insertions(+), 60 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Jian Li
  • Patrick Noland
  • Tomasz Wiszkowski
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iba6a2e0606c158d84ae308fb9747a224841c5373
Gerrit-Change-Number: 7487106
Gerrit-PatchSet: 1
Gerrit-Owner: Sky Malice <sk...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jian Li <jia...@chromium.org>
Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
Gerrit-Reviewer: Tomasz Wiszkowski <en...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Jian Li <jia...@chromium.org>
Gerrit-Attention: Tomasz Wiszkowski <en...@google.com>
Gerrit-Attention: Patrick Noland <pno...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
6:02 PM (3 hours ago) 6:02 PM
to Sky Malice, AyeAye, Tomasz Wiszkowski, Jian Li, Chromium LUCI CQ, Patrick Noland, Code Review Nudger, chromium...@chromium.org, ender...@chromium.org
Attention needed from Jian Li, Patrick Noland and Tomasz Wiszkowski

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jian Li
  • Patrick Noland
  • Tomasz Wiszkowski
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iba6a2e0606c158d84ae308fb9747a224841c5373
    Gerrit-Change-Number: 7487106
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sky Malice <sk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jian Li <jia...@chromium.org>
    Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Tomasz Wiszkowski <en...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Jian Li <jia...@chromium.org>
    Gerrit-Attention: Tomasz Wiszkowski <en...@google.com>
    Gerrit-Attention: Patrick Noland <pno...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:02:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Sky Malice (Gerrit)

    unread,
    6:06 PM (3 hours ago) 6:06 PM
    to Rubber Stamper, AyeAye, Tomasz Wiszkowski, Jian Li, Chromium LUCI CQ, Patrick Noland, Code Review Nudger, chromium...@chromium.org, ender...@chromium.org
    Attention needed from Jian Li, Patrick Noland and Tomasz Wiszkowski

    Sky Malice voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jian Li
    • Patrick Noland
    • Tomasz Wiszkowski
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iba6a2e0606c158d84ae308fb9747a224841c5373
    Gerrit-Change-Number: 7487106
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sky Malice <sk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jian Li <jia...@chromium.org>
    Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
    Gerrit-Reviewer: Tomasz Wiszkowski <en...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Jian Li <jia...@chromium.org>
    Gerrit-Attention: Tomasz Wiszkowski <en...@google.com>
    Gerrit-Attention: Patrick Noland <pno...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:06:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Rubber Stamper (Gerrit)

    unread,
    6:32 PM (2 hours ago) 6:32 PM
    to Sky Malice, AyeAye, Tomasz Wiszkowski, Jian Li, Chromium LUCI CQ, Patrick Noland, Code Review Nudger, chromium...@chromium.org, ender...@chromium.org
    Attention needed from Jian Li, Patrick Noland and Tomasz Wiszkowski

    Message from Rubber Stamper

    Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jian Li
    • Patrick Noland
    • Tomasz Wiszkowski
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iba6a2e0606c158d84ae308fb9747a224841c5373
      Gerrit-Change-Number: 7487106
      Gerrit-PatchSet: 2
      Gerrit-Owner: Sky Malice <sk...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Jian Li <jia...@chromium.org>
      Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
      Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
      Gerrit-Reviewer: Tomasz Wiszkowski <en...@google.com>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-Attention: Jian Li <jia...@chromium.org>
      Gerrit-Attention: Tomasz Wiszkowski <en...@google.com>
      Gerrit-Attention: Patrick Noland <pno...@chromium.org>
      Gerrit-Comment-Date: Thu, 15 Jan 2026 23:32:11 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Sky Malice (Gerrit)

      unread,
      6:32 PM (2 hours ago) 6:32 PM
      to AyeAye, Tomasz Wiszkowski, Jian Li, Chromium LUCI CQ, Patrick Noland, Code Review Nudger, chromium...@chromium.org, ender...@chromium.org
      Attention needed from Jian Li, Patrick Noland and Tomasz Wiszkowski

      Sky Malice added 1 comment

      Patchset-level comments
      File-level comment, Patchset 2 (Latest):
      Sky Malice . resolved

      Okay, fixed the merge, PTAL.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jian Li
      • Patrick Noland
      • Tomasz Wiszkowski
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iba6a2e0606c158d84ae308fb9747a224841c5373
      Gerrit-Change-Number: 7487106
      Gerrit-PatchSet: 2
      Gerrit-Owner: Sky Malice <sk...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Jian Li <jia...@chromium.org>
      Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
      Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
      Gerrit-Reviewer: Tomasz Wiszkowski <en...@google.com>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-Attention: Jian Li <jia...@chromium.org>
      Gerrit-Attention: Tomasz Wiszkowski <en...@google.com>
      Gerrit-Attention: Patrick Noland <pno...@chromium.org>
      Gerrit-Comment-Date: Thu, 15 Jan 2026 23:32:14 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages