[TabGroupsModule][a11y] Hide remaining tab count from a11y tree. [chromium/src : main]

0 views
Skip to first unread message

Teresa Mao (Gerrit)

unread,
Sep 4, 2025, 9:11:57 PM (2 days ago) Sep 4
to Tibor Goldschwendt, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tibor Goldschwendt

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Tibor Goldschwendt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idf9dae0cf11fedbbb6c1fd85ff12e6617b490f79
Gerrit-Change-Number: 6918156
Gerrit-PatchSet: 1
Gerrit-Owner: Teresa Mao <te...@chromium.org>
Gerrit-Reviewer: Teresa Mao <te...@chromium.org>
Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
Gerrit-Attention: Tibor Goldschwendt <tib...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 01:11:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tibor Goldschwendt (Gerrit)

unread,
Sep 5, 2025, 4:02:43 PM (2 days ago) Sep 5
to Teresa Mao, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Teresa Mao

Tibor Goldschwendt voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Teresa Mao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idf9dae0cf11fedbbb6c1fd85ff12e6617b490f79
    Gerrit-Change-Number: 6918156
    Gerrit-PatchSet: 1
    Gerrit-Owner: Teresa Mao <te...@chromium.org>
    Gerrit-Reviewer: Teresa Mao <te...@chromium.org>
    Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
    Gerrit-Attention: Teresa Mao <te...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 20:02:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Teresa Mao (Gerrit)

    unread,
    Sep 5, 2025, 4:09:45 PM (2 days ago) Sep 5
    to Tibor Goldschwendt, Chromium LUCI CQ, chromium...@chromium.org

    Teresa Mao voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idf9dae0cf11fedbbb6c1fd85ff12e6617b490f79
    Gerrit-Change-Number: 6918156
    Gerrit-PatchSet: 1
    Gerrit-Owner: Teresa Mao <te...@chromium.org>
    Gerrit-Reviewer: Teresa Mao <te...@chromium.org>
    Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 20:09:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 5, 2025, 4:13:21 PM (2 days ago) Sep 5
    to Teresa Mao, Tibor Goldschwendt, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [TabGroupsModule][a11y] Hide remaining tab count from a11y tree.
    Fixed: 442639871
    Change-Id: Idf9dae0cf11fedbbb6c1fd85ff12e6617b490f79
    Reviewed-by: Tibor Goldschwendt <tib...@chromium.org>
    Commit-Queue: Teresa Mao <te...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1511825}
    Files:
    • M chrome/browser/resources/new_tab_page/modules/tab_groups/icon_container.ts
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Tibor Goldschwendt
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idf9dae0cf11fedbbb6c1fd85ff12e6617b490f79
    Gerrit-Change-Number: 6918156
    Gerrit-PatchSet: 2
    Gerrit-Owner: Teresa Mao <te...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Teresa Mao <te...@chromium.org>
    Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages