[bookmarks] Move Show bookmarks bar context menu checkmark icon to RHS [chromium/src : main]

0 views
Skip to first unread message

Evan Luo (Gerrit)

unread,
Jul 24, 2026, 5:43:55 PM (11 hours ago) Jul 24
to Brandon Wylie, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Eleanor Lee, Mark Schillaci, browser-comp...@chromium.org
Attention needed from Brandon Wylie

Evan Luo voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Wylie
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I70c73e68cc729e2e5d102cdbcd5d48c95303c3ea
Gerrit-Change-Number: 8144381
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Luo <eva...@google.com>
Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
Gerrit-Reviewer: Evan Luo <eva...@google.com>
Gerrit-CC: Eleanor Lee <elean...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-Attention: Brandon Wylie <wyl...@google.com>
Gerrit-Comment-Date: Fri, 24 Jul 2026 21:43:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Brandon Wylie (Gerrit)

unread,
Jul 24, 2026, 6:13:13 PM (10 hours ago) Jul 24
to Evan Luo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Eleanor Lee, Mark Schillaci, browser-comp...@chromium.org
Attention needed from Evan Luo

Brandon Wylie voted and added 1 comment

Votes added by Brandon Wylie

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Brandon Wylie . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Evan Luo
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I70c73e68cc729e2e5d102cdbcd5d48c95303c3ea
Gerrit-Change-Number: 8144381
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Luo <eva...@google.com>
Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
Gerrit-Reviewer: Evan Luo <eva...@google.com>
Gerrit-Attention: Evan Luo <eva...@google.com>
Gerrit-Comment-Date: Fri, 24 Jul 2026 22:13:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Evan Luo (Gerrit)

unread,
Jul 24, 2026, 11:24:13 PM (5 hours ago) Jul 24
to Brandon Wylie, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Eleanor Lee, Mark Schillaci, browser-comp...@chromium.org

Evan Luo voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I70c73e68cc729e2e5d102cdbcd5d48c95303c3ea
Gerrit-Change-Number: 8144381
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Luo <eva...@google.com>
Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
Gerrit-Reviewer: Evan Luo <eva...@google.com>
Gerrit-CC: Eleanor Lee <elean...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-Comment-Date: Sat, 25 Jul 2026 03:23:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 24, 2026, 11:30:38 PM (5 hours ago) Jul 24
to Evan Luo, Brandon Wylie, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Eleanor Lee, Mark Schillaci, browser-comp...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[bookmarks] Move Show bookmarks bar context menu checkmark icon to RHS

Screenshot: https://screenshot.googleplex.com/image/8Qw6VUnEpyTK9XU.png
Bug: 535692460
Change-Id: I70c73e68cc729e2e5d102cdbcd5d48c95303c3ea
Reviewed-by: Brandon Wylie <wyl...@google.com>
Commit-Queue: Evan Luo <eva...@google.com>
Auto-Submit: Evan Luo <eva...@google.com>
Cr-Commit-Position: refs/heads/main@{#1668247}
Files:
  • M chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/bar/BookmarkBarContextMenuMediator.java
Change size: XS
Delta: 1 file changed, 1 insertion(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Brandon Wylie
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I70c73e68cc729e2e5d102cdbcd5d48c95303c3ea
Gerrit-Change-Number: 8144381
Gerrit-PatchSet: 2
Gerrit-Owner: Evan Luo <eva...@google.com>
Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Evan Luo <eva...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages