Document PiP: Align requestWindow timing with the spec [chromium/src : main]

[Michael Reeves (Gerrit)]

Attention needed from Peter Beverloo and Tommy Steimel

Michael Reeves has uploaded the change for review

Michael Reeves would like Tommy Steimel and Peter Beverloo to review this change.

Commit message

Document PiP: Align requestWindow timing with the spec

Chromium resolves requestWindow() from the task that dispatches the enter event, so the event fires before promise reactions. The specification instead queues the enter event on the DOM manipulation task source and returns a resolved promise. This causes the requestWindow timing subtest in returns-window-with-document.https.html to fail.

Resolve the promise when the window is created and queue only the enter event. Also make Content Shell close an existing Document PiP window before replacing its child contents, matching Chrome’s PictureInPictureWindowManager and supporting the WPT’s sequential window requests.

Remove the test’s expected-failure baseline now that Chromium follows the specified ordering.

R=pe...@chromium.org, ste...@chromium.org

Bug: 469687370

Change-Id: I4f32ce1cfa61277a81013d3e0699720114af7060

Change diff

Change information

Files:

• M AUTHORS
• M content/shell/browser/shell.cc
• M third_party/blink/renderer/modules/document_picture_in_picture/picture_in_picture_controller_impl.cc
• M third_party/blink/renderer/modules/document_picture_in_picture/picture_in_picture_controller_impl.h
• D third_party/blink/web_tests/external/wpt/document-picture-in-picture/returns-window-with-document.https-expected.txt

Change size: M

Delta: 5 files changed, 12 insertions(+), 55 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Peter Beverloo
• Tommy Steimel

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4f32ce1cfa61277a81013d3e0699720114af7060

Gerrit-Change-Number: 8222446

Gerrit-PatchSet: 1

Gerrit-Owner: Michael Reeves <michael....@gmail.com>

Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>

Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Tommy Steimel <ste...@chromium.org>

Gerrit-Attention: Peter Beverloo <pe...@chromium.org>