Add Request.isReloadNavigation attribute [chromium/src : main]

0 views
Skip to first unread message

Yoav Weiss (@Shopify) (Gerrit)

unread,
Nov 22, 2025, 10:55:09 PM11/22/25
to Helmut Januschka, Adam Rice, Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Adam Rice and Helmut Januschka

Yoav Weiss (@Shopify) added 1 comment

Patchset-level comments
File-level comment, Patchset 15 (Latest):
Yoav Weiss (@Shopify) . resolved

Can you link to the relevant spec in the commit note?

Also, I suspect this would require an intent to prototype and ship

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Helmut Januschka
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
Gerrit-Change-Number: 7137783
Gerrit-PatchSet: 15
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Comment-Date: Sun, 23 Nov 2025 03:54:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Adam Rice (Gerrit)

unread,
Nov 25, 2025, 1:21:16 PM11/25/25
to Helmut Januschka, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Helmut Januschka

Adam Rice added 2 comments

Patchset-level comments
File-level comment, Patchset 15:
Yoav Weiss (@Shopify) . unresolved

Can you link to the relevant spec in the commit note?

Also, I suspect this would require an intent to prototype and ship

Adam Rice

Yes, this will need an intent to prototype and ship. Since it is an implementation of an existing spec, they can be combined.

File-level comment, Patchset 16 (Latest):
Adam Rice . resolved

This might take me a few days to review as it touches a lot of things.

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
    Gerrit-Change-Number: 7137783
    Gerrit-PatchSet: 16
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
    Gerrit-Comment-Date: Tue, 25 Nov 2025 18:20:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Adam Rice (Gerrit)

    unread,
    Nov 25, 2025, 1:23:23 PM11/25/25
    to Helmut Januschka, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Helmut Januschka

    Adam Rice added 1 comment

    File content/browser/security_exploit_browsertest.cc
    Line 1626, Patchset 16 (Parent): ui::PAGE_TRANSITION_RELOAD,
    Adam Rice . unresolved

    Why is this safe to remove?

    Gerrit-Comment-Date: Tue, 25 Nov 2025 18:22:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Helmut Januschka (Gerrit)

    unread,
    Dec 1, 2025, 5:45:37 AM12/1/25
    to Helmut Januschka, Adam Rice, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Adam Rice and Yoav Weiss (@Shopify)

    Helmut Januschka added 2 comments

    Patchset-level comments
    File-level comment, Patchset 15:
    Yoav Weiss (@Shopify) . resolved

    Can you link to the relevant spec in the commit note?

    Also, I suspect this would require an intent to prototype and ship

    Adam Rice

    Yes, this will need an intent to prototype and ship. Since it is an implementation of an existing spec, they can be combined.

    File content/browser/security_exploit_browsertest.cc
    Line 1626, Patchset 16 (Parent): ui::PAGE_TRANSITION_RELOAD,
    Adam Rice . unresolved

    Why is this safe to remove?

    Helmut Januschka

    think it is safe to remove because this CL makes PAGE_TRANSITION_RELOAD web-triggerable for script-initiated reloads. Since it's now intentionally web-triggerable, it would be incorrect to test.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Rice
    • Yoav Weiss (@Shopify)
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
    Gerrit-Change-Number: 7137783
    Gerrit-PatchSet: 16
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Adam Rice <ri...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Dec 2025 10:45:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Adam Rice <ri...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Adam Rice (Gerrit)

    unread,
    Dec 8, 2025, 8:00:09 PM12/8/25
    to Helmut Januschka, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Helmut Januschka and Yoav Weiss (@Shopify)

    Adam Rice added 1 comment

    File content/browser/security_exploit_browsertest.cc
    Line 1626, Patchset 16 (Parent): ui::PAGE_TRANSITION_RELOAD,
    Adam Rice . unresolved

    Why is this safe to remove?

    Helmut Januschka

    think it is safe to remove because this CL makes PAGE_TRANSITION_RELOAD web-triggerable for script-initiated reloads. Since it's now intentionally web-triggerable, it would be incorrect to test.

    Adam Rice

    But `isReloadNavigation` is a read-only attribute. JavaScript can't even set it, so how does this CL enable JavaScript to trigger PAGE_TRANSITION_RELOAD?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Helmut Januschka
    • Yoav Weiss (@Shopify)
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
    Gerrit-Change-Number: 7137783
    Gerrit-PatchSet: 16
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
    Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Comment-Date: Tue, 09 Dec 2025 00:59:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Helmut Januschka <hel...@januschka.com>
    Comment-In-Reply-To: Adam Rice <ri...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Helmut Januschka (Gerrit)

    unread,
    Dec 9, 2025, 3:58:57 AM12/9/25
    to Helmut Januschka, Adam Rice, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Adam Rice and Yoav Weiss (@Shopify)

    Helmut Januschka added 1 comment

    File content/browser/security_exploit_browsertest.cc
    Line 1626, Patchset 16 (Parent): ui::PAGE_TRANSITION_RELOAD,
    Adam Rice . resolved

    Why is this safe to remove?

    Helmut Januschka

    think it is safe to remove because this CL makes PAGE_TRANSITION_RELOAD web-triggerable for script-initiated reloads. Since it's now intentionally web-triggerable, it would be incorrect to test.

    Adam Rice

    But `isReloadNavigation` is a read-only attribute. JavaScript can't even set it, so how does this CL enable JavaScript to trigger PAGE_TRANSITION_RELOAD?

    Helmut Januschka

    i changed `render_frame_impl.cc` to send `PAGE_TRANSITION_RELOAD` for reload navigations (`location.reload()`). Previously, all renderer-initiated navigations used `PAGE_TRANSITION_LINK`.

    Since the renderer now sends `PAGE_TRANSITION_RELOAD`, it must be added to `PageTransitionIsWebTriggerable()` - otherwise the browser would kill the renderer.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Rice
    • Yoav Weiss (@Shopify)
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
      Gerrit-Change-Number: 7137783
      Gerrit-PatchSet: 16
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Attention: Adam Rice <ri...@chromium.org>
      Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Comment-Date: Tue, 09 Dec 2025 08:58:38 +0000
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Adam Rice (Gerrit)

      unread,
      Dec 9, 2025, 9:54:20 PM12/9/25
      to Helmut Januschka, Daniel Cheng, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
      Attention needed from Daniel Cheng, Helmut Januschka and Yoav Weiss (@Shopify)

      Adam Rice added 2 comments

      Patchset-level comments
      Adam Rice . resolved

      +dcheng I need someone with domain knowledge to determine if the change in //content/renderer/render_frame_impl.cc is safe. Would you be a good person?

      File content/browser/security_exploit_browsertest.cc
      Line 1626, Patchset 16 (Parent): ui::PAGE_TRANSITION_RELOAD,
      Adam Rice . unresolved

      Why is this safe to remove?

      Helmut Januschka

      think it is safe to remove because this CL makes PAGE_TRANSITION_RELOAD web-triggerable for script-initiated reloads. Since it's now intentionally web-triggerable, it would be incorrect to test.

      Adam Rice

      But `isReloadNavigation` is a read-only attribute. JavaScript can't even set it, so how does this CL enable JavaScript to trigger PAGE_TRANSITION_RELOAD?

      Helmut Januschka

      i changed `render_frame_impl.cc` to send `PAGE_TRANSITION_RELOAD` for reload navigations (`location.reload()`). Previously, all renderer-initiated navigations used `PAGE_TRANSITION_LINK`.

      Since the renderer now sends `PAGE_TRANSITION_RELOAD`, it must be added to `PageTransitionIsWebTriggerable()` - otherwise the browser would kill the renderer.

      Adam Rice

      Oh! I missed that important point. I think I need that part to be reviewed first. Let me find a review for it.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      • Helmut Januschka
      • Yoav Weiss (@Shopify)
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
        Gerrit-Change-Number: 7137783
        Gerrit-PatchSet: 16
        Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
        Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
        Gerrit-Comment-Date: Wed, 10 Dec 2025 02:53:50 +0000
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Daniel Cheng (Gerrit)

        unread,
        Dec 11, 2025, 12:20:20 PM12/11/25
        to Helmut Januschka, Daniel Cheng, Adam Rice, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
        Attention needed from Helmut Januschka and Yoav Weiss (@Shopify)

        Daniel Cheng added 1 comment

        Patchset-level comments
        Adam Rice . unresolved

        +dcheng I need someone with domain knowledge to determine if the change in //content/renderer/render_frame_impl.cc is safe. Would you be a good person?

        Daniel Cheng

        I don't understand why `BeginNavigationInternal()` changes here. Aren't the fetch API and navigation two distinct things?

        Open in Gerrit

        Related details

        Attention is currently required from:
        Gerrit-Comment-Date: Thu, 11 Dec 2025 17:20:09 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Adam Rice <ri...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Helmut Januschka (Gerrit)

        unread,
        Dec 11, 2025, 3:25:08 PM12/11/25
        to Helmut Januschka, Daniel Cheng, Adam Rice, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
        Attention needed from Adam Rice, Daniel Cheng and Yoav Weiss (@Shopify)

        Helmut Januschka added 1 comment

        Patchset-level comments
        Adam Rice . resolved

        +dcheng I need someone with domain knowledge to determine if the change in //content/renderer/render_frame_impl.cc is safe. Would you be a good person?

        Daniel Cheng

        I don't understand why `BeginNavigationInternal()` changes here. Aren't the fetch API and navigation two distinct things?

        Helmut Januschka

        Fetch API and navigation intersect for Service Worker navigation requests.

        `Request.isReloadNavigation` tells the SW whether the navigation came from a reload, but for that to work we need to pass the right page transition from the renderer.

        Right now `BeginNavigationInternal()` always uses `PAGE_TRANSITION_LINK` [1], even for `location.reload()`. The navigation type is already `kWebNavigationTypeReload` [2], but we weren't converting that into a reload transition. This change fixes that by using `PAGE_TRANSITION_RELOAD` for reloads.

        [1] https://source.chromium.org/chromium/chromium/src/+/83f6205f0e033e3c5da53306d66b494254303cce:content/renderer/render_frame_impl.cc;l=6048
        [2] https://source.chromium.org/chromium/chromium/src/+/83f6205f0e033e3c5da53306d66b494254303cce:third_party/blink/public/web/web_navigation_type.h;l=40

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Adam Rice
        • Daniel Cheng
        • Yoav Weiss (@Shopify)
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
        Gerrit-Change-Number: 7137783
        Gerrit-PatchSet: 16
        Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Attention: Adam Rice <ri...@chromium.org>
        Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
        Gerrit-Comment-Date: Thu, 11 Dec 2025 20:24:47 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Adam Rice <ri...@chromium.org>
        Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Helmut Januschka (Gerrit)

        unread,
        Dec 22, 2025, 3:28:21 AM12/22/25
        to Helmut Januschka, Daniel Cheng, Adam Rice, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
        Attention needed from Adam Rice, Daniel Cheng and Yoav Weiss (@Shopify)

        Helmut Januschka added 1 comment

        Patchset-level comments
        Helmut Januschka . resolved

        ping, anything i can do to move on?

        Gerrit-Comment-Date: Mon, 22 Dec 2025 08:28:09 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Helmut Januschka (Gerrit)

        unread,
        Jan 10, 2026, 5:24:30 PM (24 hours ago) Jan 10
        to Helmut Januschka, Daniel Cheng, Adam Rice, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
        Attention needed from Adam Rice, Daniel Cheng and Yoav Weiss (@Shopify)

        Helmut Januschka added 1 comment

        Patchset-level comments
        File-level comment, Patchset 16 (Latest):
        Helmut Januschka . resolved

        ping

        Gerrit-Comment-Date: Sat, 10 Jan 2026 22:24:09 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages