Reland "[PA] Add TaskControlledPurge to fieldtrial" [chromium/src : main]
0 views
Skip to first unread message
Mikihito Matsuura (Gerrit)
Feb 16, 2026, 9:57:35 AM (14 days ago) Feb 16
to Benoit Lize, Chromium LUCI CQ, Steve Kobes, Will Harris, Morten Stenshorne, Rubber Stamper, AyeAye, Stephen Nusko, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews
Mikihito Matsuura has uploaded the change for review![]( "Open in Gerrit")
Mikihito Matsuura would like Benoit Lize, Chromium LUCI CQ, Steve Kobes, Will Harris, Morten Stenshorne and Rubber Stamper to review this change.
Commit message
Reland "[PA] Add TaskControlledPurge to fieldtrial"
This reverts commit cc391d1cf1785113340221c8190956aec14dc8e3.
Reason for revert: TBD
Original change's description:
> Revert "[PA] Add TaskControlledPurge to fieldtrial"
>
> This reverts commit 7053c500f98ab15855aa0a3330fd0fd884402f79.
>
> Reason for revert: causing crashes on CQ, see crbug.com/483092892.
>
> Original change's description:
> > [PA] Add TaskControlledPurge to fieldtrial
> >
> > PartitionAllocSchedulerLoopQuarantineTaskControlledPurge is a feature to
> > replace
> > PartitionAllocSchedulerLoopQuarantineTaskObserverForBrowserUIThread. It
> > is more widely-available and its performance characteristic is to be
> > determined through Finch experiments.
> >
> > Bug: 351974425
> > Change-Id: Iba926a0ce636f531d66adca9ca6be8c1ee4ca915
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7519605
> > Commit-Queue: Mikihito Matsuura <mi...@google.com>
> > Reviewed-by: Stephen Nusko <nus...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1581619}
>
> Bug: 351974425, 483092892
> Change-Id: I87083e90ae4ea0db7e747380d077af70e7373369
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7562909
> Reviewed-by: Morten Stenshorne <mste...@chromium.org>
> Commit-Queue: Steve Kobes <sko...@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1582492}
Bug: 351974425, 483092892
Change-Id: Ic3bf879ba259bbb7af29f2db5825bc449c97da12
Change diff
diff --git a/testing/variations/fieldtrial_testing_config.json b/testing/variations/fieldtrial_testing_config.json
index fe9046de..848648b7 100644
--- a/testing/variations/fieldtrial_testing_config.json
+++ b/testing/variations/fieldtrial_testing_config.json
@@ -19529,10 +19529,11 @@
},
"enable_features": [
"PartitionAllocSchedulerLoopQuarantine",
- "PartitionAllocSchedulerLoopQuarantineTaskObserverForBrowserUIThread",
+ "PartitionAllocSchedulerLoopQuarantineTaskControlledPurge",
"PartitionAllocWithAdvancedChecks"
],
"disable_features": [
+ "PartitionAllocSchedulerLoopQuarantineTaskObserverForBrowserUIThread",
"ScreenAIPartitionAllocAdvancedChecksEnabled"
]
}
Change information
Files:
- M testing/variations/fieldtrial_testing_config.json
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikihito Matsuura (Gerrit)
12:19 AM (2 hours ago) 12:19 AM
to Stephen Nusko, Morten Stenshorne, Will Harris, Benoit Lize, Steve Kobes, Rubber Stamper, AyeAye, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org
Attention needed from Stephen Nusko
Mikihito Matsuura added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Stephen Nusko
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
12:19 AM (2 hours ago) 12:19 AM
to Mikihito Matsuura, Stephen Nusko, Morten Stenshorne, Will Harris, Benoit Lize, Steve Kobes, AyeAye, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org
Attention needed from Stephen Nusko
Message from Rubber Stamper![]( "Open in Gerrit")
The change is not in the configured time window. Rubber Stamper is only allowed to review reverts within 14 day(s). Learn more: go/rubber-stamper-user-guide.
Stephen Nusko (Gerrit)
1:29 AM (1 hour ago) 1:29 AM
to Mikihito Matsuura, Morten Stenshorne, Will Harris, Benoit Lize, Steve Kobes, AyeAye, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org
Attention needed from Mikihito Matsuura
Stephen Nusko voted![]( "Open in Gerrit")
Attention is currently required from:
- Mikihito Matsuura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikihito Matsuura (Gerrit)
1:30 AM (1 hour ago) 1:30 AM
to Chromium LUCI CQ, Stephen Nusko, Morten Stenshorne, Will Harris, Benoit Lize, Steve Kobes, AyeAye, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org
Mikihito Matsuura voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:06 AM (6 minutes ago) 2:06 AM
to Mikihito Matsuura, Stephen Nusko, Morten Stenshorne, Will Harris, Benoit Lize, Steve Kobes, AyeAye, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, asvitkine...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[PA] Add TaskControlledPurge to fieldtrial"
This reverts commit cc391d1cf1785113340221c8190956aec14dc8e3.
Reason for revert: Fixed by https://crrev.com/c/7591513
Reviewed-by: Stephen Nusko <nus...@chromium.org>
Commit-Queue: Stephen Nusko <nus...@chromium.org>
Commit-Queue: Mikihito Matsuura <mi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1592268}
Files:
- M testing/variations/fieldtrial_testing_config.json
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Stephen Nusko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages