Proof of concept: local override for AccessibilityNodeInfoCompat.java [chromium/src : main]

0 views
Skip to first unread message

Akihiro Ota (Gerrit)

unread,
Sep 4, 2025, 6:46:01 PM (3 days ago) Sep 4
to Andrew Grieve, Amanda Lin Dietz, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Andrew Grieve

Akihiro Ota voted and added 1 comment

Votes added by Akihiro Ota

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Akihiro Ota . resolved

Hi Andrew,

Per our email thread, here's our local override of ANICompat.java. The contents are the same as the androidx-main file here:

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:core/core/src/main/java/androidx/core/view/accessibility/AccessibilityNodeInfoCompat.java?q=nodeinfocompat.java&ss=androidx%2Fplatform%2Fframeworks%2Fsupport

If you're okay with how this looks, then I can clean up the commit message so that it's ready to check-in.

Thanks for your help here!

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ica343a66a3cb74b062aa3ad758d90a5c0cc4c148
Gerrit-Change-Number: 6917784
Gerrit-PatchSet: 2
Gerrit-Owner: Akihiro Ota <akihi...@chromium.org>
Gerrit-Reviewer: Akihiro Ota <akihi...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Amanda Lin Dietz <ald...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Sep 2025 22:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Sep 4, 2025, 9:00:07 PM (2 days ago) Sep 4
to Akihiro Ota, Chromium LUCI CQ, Andrew Grieve, Amanda Lin Dietz, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Akihiro Ota

Andrew Grieve added 1 comment

Patchset-level comments
Akihiro Ota . resolved

Hi Andrew,

Per our email thread, here's our local override of ANICompat.java. The contents are the same as the androidx-main file here:

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:core/core/src/main/java/androidx/core/view/accessibility/AccessibilityNodeInfoCompat.java?q=nodeinfocompat.java&ss=androidx%2Fplatform%2Fframeworks%2Fsupport

If you're okay with how this looks, then I can clean up the commit message so that it's ready to check-in.

Thanks for your help here!

Andrew Grieve

LGTM!

Open in Gerrit

Related details

Attention is currently required from:
  • Akihiro Ota
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ica343a66a3cb74b062aa3ad758d90a5c0cc4c148
Gerrit-Change-Number: 6917784
Gerrit-PatchSet: 2
Gerrit-Owner: Akihiro Ota <akihi...@chromium.org>
Gerrit-Reviewer: Akihiro Ota <akihi...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Amanda Lin Dietz <ald...@google.com>
Gerrit-Attention: Akihiro Ota <akihi...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 01:00:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Akihiro Ota <akihi...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages