views: Handle null DialogDelegate in DialogClientView layout [chromium/src : main]

0 views
Skip to first unread message

gwsq (Gerrit)

unread,
Aug 6, 2026, 10:20:22 PM (3 days ago) Aug 6
to Chunyang Huo, Chromium UI Views Reviews, Thomas Lukaszewicz, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Thomas Lukaszewicz

Message from gwsq

Reviewer source(s):
tl...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ui/views/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If1118952ae51b547ebff63c1364d1b9db48232f3
Gerrit-Change-Number: 8220888
Gerrit-PatchSet: 2
Gerrit-Owner: Chunyang Huo <chuny...@microsoft.com>
Gerrit-Reviewer: Chunyang Huo <chuny...@microsoft.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Fri, 07 Aug 2026 02:19:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Lukaszewicz (Gerrit)

unread,
4:33 PM (4 hours ago) 4:33 PM
to Chunyang Huo, David Yeung, Chromium UI Views Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Chunyang Huo and David Yeung

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Thomas Lukaszewicz . resolved

lgtm! David ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Chunyang Huo
  • David Yeung
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If1118952ae51b547ebff63c1364d1b9db48232f3
Gerrit-Change-Number: 8220888
Gerrit-PatchSet: 2
Gerrit-Owner: Chunyang Huo <chuny...@microsoft.com>
Gerrit-Reviewer: Chunyang Huo <chuny...@microsoft.com>
Gerrit-Reviewer: David Yeung <day...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: David Yeung <day...@chromium.org>
Gerrit-Attention: Chunyang Huo <chuny...@microsoft.com>
Gerrit-Comment-Date: Sun, 09 Aug 2026 20:32:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages