win: viz: Use OsCompositorTreeBase in DCLayerTree [chromium/src : main]

0 views
Skip to first unread message

Michael Tang (Gerrit)

unread,
Jun 11, 2025, 11:59:57 AM6/11/25
to Rafael Cintron, Vasiliy Telezhnikov, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, cc-...@chromium.org, penghu...@chromium.org
Attention needed from Rafael Cintron and Vasiliy Telezhnikov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Rafael Cintron
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I02aed386b6daf6089e38e8a57dcbc495dfeada87
Gerrit-Change-Number: 6451501
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Tang <ta...@microsoft.com>
Gerrit-Reviewer: Michael Tang <ta...@microsoft.com>
Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: Sunny Sachanandani <sun...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Comment-Date: Wed, 11 Jun 2025 15:59:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rafael Cintron (Gerrit)

unread,
Oct 8, 2025, 4:42:09 PM10/8/25
to Michael Tang, Vasiliy Telezhnikov, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, cc-...@chromium.org, penghu...@chromium.org
Attention needed from Michael Tang and Vasiliy Telezhnikov

Rafael Cintron added 5 comments

File components/viz/service/display/overlay_processor_delegated_support.cc
Line 157, Patchset 14 (Latest): sqs_list.push_back(sqs);
Rafael Cintron . unresolved

Since we're potentially creating a new entry in the list, should we call this method "GetOrCreateUniqueOverlayId"?

File ui/gl/dc_layer_overlay_params.h
Line 78, Patchset 14 (Latest): gfx::OverlayLayerId parent_layer_id;
Rafael Cintron . unresolved

Can we remove parent_layer_id for now until we need it?

File ui/gl/dc_layer_tree.cc
Line 577, Patchset 14 (Latest): Microsoft::WRL::ComPtr<IDCompositionVisual> old_parent_visual =
Rafael Cintron . unresolved
```suggestion
  Microsoft::WRL::ComPtr<IDCompositionVisual> previous_parent_visual =
```
Line 1262, Patchset 14 (Latest): base::FeatureList::IsEnabled(features::kDCLayerTree2FromScratch)
Rafael Cintron . unresolved

Consider having the update mode be a parameter of the DCLayerTree2 feature flag instead of its own feature flag. Fewer invalid states to check for.

Line 1336, Patchset 14 (Latest): DLOG(ERROR) << "IDCompositionDevice2::Commit failed: "
Rafael Cintron . unresolved
```suggestion
    LOG(ERROR) << "IDCompositionDevice2::Commit failed: "
```
Consider switching to LOG(ERROR) so we can better help people with rendering issues.
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Tang
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I02aed386b6daf6089e38e8a57dcbc495dfeada87
Gerrit-Change-Number: 6451501
Gerrit-PatchSet: 14
Gerrit-Owner: Michael Tang <ta...@microsoft.com>
Gerrit-Reviewer: Michael Tang <ta...@microsoft.com>
Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: Sunny Sachanandani <sun...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Michael Tang <ta...@microsoft.com>
Gerrit-Comment-Date: Wed, 08 Oct 2025 20:41:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Tang (Gerrit)

unread,
Nov 4, 2025, 5:32:22 PM11/4/25
to Rafael Cintron, Vasiliy Telezhnikov, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, cc-...@chromium.org, penghu...@chromium.org
Attention needed from Rafael Cintron and Vasiliy Telezhnikov

Michael Tang added 5 comments

File components/viz/service/display/overlay_processor_delegated_support.cc
Line 157, Patchset 14: sqs_list.push_back(sqs);
Rafael Cintron . resolved

Since we're potentially creating a new entry in the list, should we call this method "GetOrCreateUniqueOverlayId"?

Michael Tang

Done

File ui/gl/dc_layer_overlay_params.h
Line 78, Patchset 14: gfx::OverlayLayerId parent_layer_id;
Rafael Cintron . resolved

Can we remove parent_layer_id for now until we need it?

Michael Tang

We need this due to [the `OsCompositorTreeBase` interface](https://source.chromium.org/chromium/chromium/src/+/main:ui/gl/os_compositor_tree_base.h;l=31-33;drc=3ab87020a04ea6586dff4ab26eee8df86ab8dc8d). For now, it will always be `gfx::OverlayLayerId()` (which is `gfx::OverlayLayerId::MakeVizInternal(VizInternalId::kOsCompositorRoot)`).

File ui/gl/dc_layer_tree.cc
Line 577, Patchset 14: Microsoft::WRL::ComPtr<IDCompositionVisual> old_parent_visual =
Rafael Cintron . resolved
```suggestion
  Microsoft::WRL::ComPtr<IDCompositionVisual> previous_parent_visual =
```
Michael Tang

Done

Line 1262, Patchset 14: base::FeatureList::IsEnabled(features::kDCLayerTree2FromScratch)
Rafael Cintron . resolved

Consider having the update mode be a parameter of the DCLayerTree2 feature flag instead of its own feature flag. Fewer invalid states to check for.

Michael Tang

Done

Line 1336, Patchset 14: DLOG(ERROR) << "IDCompositionDevice2::Commit failed: "
Rafael Cintron . resolved
```suggestion
    LOG(ERROR) << "IDCompositionDevice2::Commit failed: "
```
Consider switching to LOG(ERROR) so we can better help people with rendering issues.
Michael Tang

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Rafael Cintron
  • Vasiliy Telezhnikov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I02aed386b6daf6089e38e8a57dcbc495dfeada87
    Gerrit-Change-Number: 6451501
    Gerrit-PatchSet: 16
    Gerrit-Owner: Michael Tang <ta...@microsoft.com>
    Gerrit-Reviewer: Michael Tang <ta...@microsoft.com>
    Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-CC: Sunny Sachanandani <sun...@chromium.org>
    Gerrit-Attention: Rafael Cintron <rafael....@microsoft.com>
    Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 22:32:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Rafael Cintron <rafael....@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rafael Cintron (Gerrit)

    unread,
    Nov 4, 2025, 6:02:18 PM11/4/25
    to Michael Tang, Vasiliy Telezhnikov, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, cc-...@chromium.org, penghu...@chromium.org
    Attention needed from Michael Tang and Vasiliy Telezhnikov

    Rafael Cintron voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Tang
    • Vasiliy Telezhnikov
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I02aed386b6daf6089e38e8a57dcbc495dfeada87
      Gerrit-Change-Number: 6451501
      Gerrit-PatchSet: 16
      Gerrit-Owner: Michael Tang <ta...@microsoft.com>
      Gerrit-Reviewer: Michael Tang <ta...@microsoft.com>
      Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
      Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
      Gerrit-CC: Sunny Sachanandani <sun...@chromium.org>
      Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
      Gerrit-Attention: Michael Tang <ta...@microsoft.com>
      Gerrit-Comment-Date: Tue, 04 Nov 2025 23:02:08 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages