[iOS] Add BottomSheetViewController to VC Catalog [chromium/src : main]
0 views
Skip to first unread message
Ewann Pellé (Gerrit)
9:52 AM (9 hours ago) 9:52 AM
to Anis Chara, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Anis Chara
Ewann Pellé added 2 comments![]( "Open in Gerrit")
Commit Message
Line 12, Patchset 2 (Latest):
screenshot:https://screenshot.googleplex.com/api/62HG7U4C5Hztns9.pngEwann Pellé . unresolved
It feels empty, can you add something to its content view ?
File ios/chrome/browser/catalogs/ui/view_controller_catalog_view_controller.mm
Line 205, Patchset 2 (Latest):
#pragma mark - Private HelpersEwann Pellé . unresolved
nit: this pragma section is redundant. Remove it.
Related details
Attention is currently required from:
- Anis Chara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anis Chara (Gerrit)
11:18 AM (7 hours ago) 11:18 AM
to Ewann Pellé, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ewann Pellé
Anis Chara added 2 comments![]( "Open in Gerrit")
Commit Message
Line 12, Patchset 2:
screenshot:https://screenshot.googleplex.com/api/62HG7U4C5Hztns9.pngEwann Pellé . resolved
It feels empty, can you add something to its content view ?
Anis Chara
Done
File ios/chrome/browser/catalogs/ui/view_controller_catalog_view_controller.mm
nit: this pragma section is redundant. Remove it.
Attention is currently required from:
- Ewann Pellé
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
11:23 AM (7 hours ago) 11:23 AM
to Anis Chara, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Anis Chara
Ewann Pellé voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Anis Chara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
11:52 AM (7 hours ago) 11:52 AM
to Anis Chara, Ewann Pellé, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Anis Chara
Gauthier Ambard added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/catalogs/ui/view_controller_catalog_view_controller.mm
Line 199, Patchset 5 (Latest):
BottomSheetViewController* bottomSheetViewController =Gauthier Ambard . unresolved
I think this VC should not exist. I would rather avoid adding more spotlight to it.
Related details
Attention is currently required from:
- Anis Chara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
12:08 PM (7 hours ago) 12:08 PM
to Anis Chara, Ewann Pellé, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Anis Chara
Gauthier Ambard added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/catalogs/ui/view_controller_catalog_view_controller.mm
Line 199, Patchset 5 (Latest):
BottomSheetViewController* bottomSheetViewController =Gauthier Ambard . unresolved
I think this VC should not exist. I would rather avoid adding more spotlight to it.
Gauthier Ambard
After discussing, could you rather add a buttonStackView with custom detent instead?
Related details
Attention is currently required from:
- Anis Chara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages