New webgpu pixel test that uses pixel storage in compute [chromium/src : main]
Peter McNeeley (Gerrit)
Peter McNeeley added 1 comment![]( "Open in Gerrit")
base_name + '_WebGPUCanvas2DDrawImage',Peter McNeeleyyou forgot to rename!!!
Done
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Related details
- Kai Ninomiya
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kai Ninomiya (Gerrit)
Kai Ninomiya voted and added 2 comments![]( "Open in Gerrit")
Votes added by Kai Ninomiya
| Code-Review | +1 |
2 comments
// This is either 'rgba8unorm' (android) or 'bgra8unorm' on macnit: mac and most or all other platforms
// Only if we neeed bgra do we need to request the featureI didn't think this feature would be available on all bgra8unorm platforms we test, but I guess it is?
Test could just use rgba8unorm to be safe but up to you since apparently this works in practice.
(however for CTS reftests we would want to always use rgba8unorm, or have coverage for both)
Related details
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley added 1 comment![]( "Open in Gerrit")
// This is either 'rgba8unorm' (android) or 'bgra8unorm' on macnit: mac and most or all other platforms
I am about to change linux 😊
So i just left it as the the things that we know for sure.
I am also not certain where d3d really falls here.
Related details
- Kai Ninomiya
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley added 1 comment![]( "Open in Gerrit")
// Only if we neeed bgra do we need to request the featureI didn't think this feature would be available on all bgra8unorm platforms we test, but I guess it is?
Test could just use rgba8unorm to be safe but up to you since apparently this works in practice.
(however for CTS reftests we would want to always use rgba8unorm, or have coverage for both)
The test asks for the preferred canvas format. This should be RGBA for Android and in the future linux. Everywhere else we need this feature for this test to work.
Kai Ninomiya (Gerrit)
Kai Ninomiya added 2 comments![]( "Open in Gerrit")
// This is either 'rgba8unorm' (android) or 'bgra8unorm' on macPeter McNeeleynit: mac and most or all other platforms
I am about to change linux 😊
So i just left it as the the things that we know for sure.
I am also not certain where d3d really falls here.
Acknowledged
// Only if we neeed bgra do we need to request the featurePeter McNeeleyI didn't think this feature would be available on all bgra8unorm platforms we test, but I guess it is?
Test could just use rgba8unorm to be safe but up to you since apparently this works in practice.
(however for CTS reftests we would want to always use rgba8unorm, or have coverage for both)
The test asks for the preferred canvas format. This should be RGBA for Android and in the future linux. Everywhere else we need this feature for this test to work.
Right, I'm suggesting that the test could just use `rgba8unorm` instead of the preferred format. That's always allowed (and always supports storage), just maybe less efficient. It's the simplest way to use storage to write to a canvas on all platforms without any conditionals.
Related details
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley added 1 comment![]( "Open in Gerrit")
// Only if we neeed bgra do we need to request the featurePeter McNeeleyI didn't think this feature would be available on all bgra8unorm platforms we test, but I guess it is?
Test could just use rgba8unorm to be safe but up to you since apparently this works in practice.
(however for CTS reftests we would want to always use rgba8unorm, or have coverage for both)
Kai NinomiyaThe test asks for the preferred canvas format. This should be RGBA for Android and in the future linux. Everywhere else we need this feature for this test to work.
Right, I'm suggesting that the test could just use `rgba8unorm` instead of the preferred format. That's always allowed (and always supports storage), just maybe less efficient. It's the simplest way to use storage to write to a canvas on all platforms without any conditionals.
Ah yes I didnt think about that? I think you are correct that this could be better.
Related details
- Kai Ninomiya
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley added 1 comment![]( "Open in Gerrit")
// Only if we neeed bgra do we need to request the featurePeter McNeeleyI didn't think this feature would be available on all bgra8unorm platforms we test, but I guess it is?
Test could just use rgba8unorm to be safe but up to you since apparently this works in practice.
(however for CTS reftests we would want to always use rgba8unorm, or have coverage for both)
Kai NinomiyaThe test asks for the preferred canvas format. This should be RGBA for Android and in the future linux. Everywhere else we need this feature for this test to work.
Peter McNeeleyRight, I'm suggesting that the test could just use `rgba8unorm` instead of the preferred format. That's always allowed (and always supports storage), just maybe less efficient. It's the simplest way to use storage to write to a canvas on all platforms without any conditionals.
Ah yes I didnt think about that? I think you are correct that this could be better.
Done
Related details
- Kai Ninomiya
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kai Ninomiya (Gerrit)
Kai Ninomiya voted Code-Review+1![]( "Open in Gerrit")
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
New webgpu pixel test that uses pixel storage in compute
This pixel test acts as a 'smoke test' for WebGPU compute
- M content/test/content_test_bundle_data.filelist
- A content/test/data/gpu/pixel_webgpu_texture_storage.html
- M content/test/gpu/gpu_tests/pixel_test_pages.py
Code-Review: +1 by Kai Ninomiya, +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |