[rust] Use `chromium::import!` to avoid refering to mangled crate names. [chromium/src : main]

0 views
Skip to first unread message

Łukasz Anforowicz (Gerrit)

unread,
Dec 5, 2025, 1:50:35 PM (14 hours ago) Dec 5
to Junichi Uekawa, Sora Kawashima, Tatsuyuki Ishi, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Junichi Uekawa

Łukasz Anforowicz voted and added 1 comment

Votes added by Łukasz Anforowicz

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Łukasz Anforowicz . resolved

@uekawa, can you PTAL?

Open in Gerrit

Related details

Attention is currently required from:
  • Junichi Uekawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib95dc2b073b1431e6a41d6422c58affc185d4783
Gerrit-Change-Number: 7230181
Gerrit-PatchSet: 1
Gerrit-Owner: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-Reviewer: Junichi Uekawa <uek...@chromium.org>
Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-CC: Sora Kawashima <skawa...@google.com>
Gerrit-CC: Tatsuyuki Ishi <ishita...@google.com>
Gerrit-Attention: Junichi Uekawa <uek...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Dec 2025 18:50:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Dec 5, 2025, 3:15:02 PM (13 hours ago) Dec 5
to Łukasz Anforowicz, Daniel Cheng, Junichi Uekawa, Sora Kawashima, Tatsuyuki Ishi, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Junichi Uekawa and Łukasz Anforowicz

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Daniel Cheng . resolved

I am going to cheat here a little.

Open in Gerrit

Related details

Attention is currently required from:
  • Junichi Uekawa
  • Łukasz Anforowicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib95dc2b073b1431e6a41d6422c58affc185d4783
    Gerrit-Change-Number: 7230181
    Gerrit-PatchSet: 1
    Gerrit-Owner: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-CC: Sora Kawashima <skawa...@google.com>
    Gerrit-CC: Tatsuyuki Ishi <ishita...@google.com>
    Gerrit-Attention: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Attention: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Dec 2025 20:14:50 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Dec 5, 2025, 4:31:24 PM (11 hours ago) Dec 5
    to Łukasz Anforowicz, Daniel Cheng, Junichi Uekawa, Sora Kawashima, Tatsuyuki Ishi, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Junichi Uekawa and Łukasz Anforowicz

    Daniel Cheng voted

    Commit-Queue+2
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Junichi Uekawa
    • Łukasz Anforowicz
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib95dc2b073b1431e6a41d6422c58affc185d4783
    Gerrit-Change-Number: 7230181
    Gerrit-PatchSet: 1
    Gerrit-Owner: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-CC: Sora Kawashima <skawa...@google.com>
    Gerrit-CC: Tatsuyuki Ishi <ishita...@google.com>
    Gerrit-Attention: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Attention: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Dec 2025 21:31:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 5, 2025, 4:34:41 PM (11 hours ago) Dec 5
    to Łukasz Anforowicz, Daniel Cheng, Junichi Uekawa, Sora Kawashima, Tatsuyuki Ishi, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [rust] Use `chromium::import!` to avoid refering to mangled crate names.
    Bug: 463302946
    Change-Id: Ib95dc2b073b1431e6a41d6422c58affc185d4783
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Auto-Submit: Łukasz Anforowicz <luk...@chromium.org>
    Reviewed-by: Daniel Cheng <dch...@chromium.org>
    Owners-Override: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1554896}
    Files:
    Change size: S
    Delta: 2 files changed, 18 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Daniel Cheng
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib95dc2b073b1431e6a41d6422c58affc185d4783
    Gerrit-Change-Number: 7230181
    Gerrit-PatchSet: 2
    Gerrit-Owner: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
    open
    diffy
    satisfied_requirement

    Tatsuyuki Ishi (Gerrit)

    unread,
    12:55 AM (3 hours ago) 12:55 AM
    to Chromium LUCI CQ, Łukasz Anforowicz, Daniel Cheng, Junichi Uekawa, Sora Kawashima, chromium...@chromium.org

    Tatsuyuki Ishi voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib95dc2b073b1431e6a41d6422c58affc185d4783
    Gerrit-Change-Number: 7230181
    Gerrit-PatchSet: 2
    Gerrit-Owner: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Reviewer: Tatsuyuki Ishi <ishita...@google.com>
    Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-CC: Sora Kawashima <skawa...@google.com>
    Gerrit-Comment-Date: Sat, 06 Dec 2025 05:55:19 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages