Cleaning unused includes in various chrome/browser/ui/views dirs [chromium/src : main]

0 views
Skip to first unread message

Kunal Daftari (Gerrit)

unread,
Jul 1, 2026, 2:43:35 PM (8 days ago) Jul 1
to SLSA Policy Verification Service, AyeAye Python Dispatcher, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org, storage...@chromium.org
Attention needed from Kunal Daftari

Kunal Daftari removed SLSA Policy Verification Service from this change

Deleted Reviewers:
  • SLSA Policy Verification Service
Open in Gerrit

Related details

Attention is currently required from:
  • Kunal Daftari
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idab00f8c59148272b8b293a97b0770d83ea448c5
Gerrit-Change-Number: 7965161
Gerrit-PatchSet: 4
Gerrit-Owner: Kunal Daftari <kunald...@google.com>
Gerrit-Reviewer: Kunal Daftari <kunald...@google.com>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-Attention: Kunal Daftari <kunald...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kunal Daftari (Gerrit)

unread,
Jul 8, 2026, 8:38:46 PM (18 hours ago) Jul 8
to SLSA Policy Verification Service, //chrome/browser/ui/views Reviews, AyeAye Python Dispatcher, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org, storage...@chromium.org
Attention needed from //chrome/browser/ui/views Reviews

Kunal Daftari removed SLSA Policy Verification Service from this change

Deleted Reviewers:
  • SLSA Policy Verification Service
Open in Gerrit

Related details

Attention is currently required from:
  • //chrome/browser/ui/views Reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idab00f8c59148272b8b293a97b0770d83ea448c5
Gerrit-Change-Number: 7965161
Gerrit-PatchSet: 11
Gerrit-Owner: Kunal Daftari <kunald...@google.com>
Gerrit-Reviewer: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
Gerrit-Reviewer: Kunal Daftari <kunald...@google.com>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-Attention: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jul 8, 2026, 8:43:09 PM (18 hours ago) Jul 8
to Kunal Daftari, //chrome/browser/ui/views Reviews, David Pennington, AyeAye Python Dispatcher, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org, storage...@chromium.org
Attention needed from David Pennington

Message from gwsq

Reviewer source(s):
dpen...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/ui/views/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • David Pennington
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idab00f8c59148272b8b293a97b0770d83ea448c5
Gerrit-Change-Number: 7965161
Gerrit-PatchSet: 11
Gerrit-Owner: Kunal Daftari <kunald...@google.com>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Kunal Daftari <kunald...@google.com>
Gerrit-CC: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: David Pennington <dpen...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Jul 2026 00:42:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Pennington (Gerrit)

unread,
11:34 AM (3 hours ago) 11:34 AM
to Kunal Daftari, //chrome/browser/ui/views Reviews, AyeAye Python Dispatcher, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org, storage...@chromium.org
Attention needed from Kunal Daftari

David Pennington voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kunal Daftari
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idab00f8c59148272b8b293a97b0770d83ea448c5
Gerrit-Change-Number: 7965161
Gerrit-PatchSet: 11
Gerrit-Owner: Kunal Daftari <kunald...@google.com>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Kunal Daftari <kunald...@google.com>
Gerrit-CC: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: gwsq
Gerrit-Attention: Kunal Daftari <kunald...@google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 15:34:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kunal Daftari (Gerrit)

unread,
12:01 PM (3 hours ago) 12:01 PM
to David Pennington, //chrome/browser/ui/views Reviews, AyeAye Python Dispatcher, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org, storage...@chromium.org

Kunal Daftari voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idab00f8c59148272b8b293a97b0770d83ea448c5
Gerrit-Change-Number: 7965161
Gerrit-PatchSet: 11
Gerrit-Owner: Kunal Daftari <kunald...@google.com>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Kunal Daftari <kunald...@google.com>
Gerrit-CC: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: gwsq
Gerrit-Comment-Date: Thu, 09 Jul 2026 16:01:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
12:05 PM (3 hours ago) 12:05 PM
to Kunal Daftari, David Pennington, //chrome/browser/ui/views Reviews, AyeAye Python Dispatcher, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org, storage...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Cleaning unused includes in various chrome/browser/ui/views dirs

extensions, eye_dropper, file_system_access, frame.

See bug for description of the automated process.
Bug: 525413967
Change-Id: Idab00f8c59148272b8b293a97b0770d83ea448c5
Reviewed-by: David Pennington <dpen...@chromium.org>
Commit-Queue: Kunal Daftari <kunald...@google.com>
Cr-Commit-Position: refs/heads/main@{#1659601}
Files:
  • M chrome/browser/ui/views/extensions/browser_action_drag_data.cc
  • M chrome/browser/ui/views/extensions/chooser_dialog_view.cc
  • M chrome/browser/ui/views/extensions/device_chooser_extension_browsertest.cc
  • M chrome/browser/ui/views/extensions/dialogs/confirm_protocol_handler_dialog_interactive_uitest.cc
  • M chrome/browser/ui/views/extensions/dialogs/extension_install_friction_dialog_interactive_uitest.cc
  • M chrome/browser/ui/views/extensions/expandable_container_view.cc
  • M chrome/browser/ui/views/extensions/expandable_container_view_unittest.cc
  • M chrome/browser/ui/views/extensions/extension_action_delegate_desktop.cc
  • M chrome/browser/ui/views/extensions/extension_context_menu_controller.cc
  • M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
  • M chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
  • M chrome/browser/ui/views/extensions/extension_permissions_view.cc
  • M chrome/browser/ui/views/extensions/extension_popup.cc
  • M chrome/browser/ui/views/extensions/extension_post_install_dialog_view_utils.cc
  • M chrome/browser/ui/views/extensions/extension_post_install_dialog_view_utils_browsertest.cc
  • M chrome/browser/ui/views/extensions/extension_post_install_dialog_view_utils_signin_browsertest.cc
  • M chrome/browser/ui/views/extensions/extension_view_views.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_coordinator.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_entry_view.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_item_unittest.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_item_view.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_main_page_view.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_main_page_view_interactive_uitest.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_main_page_view_unittest.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_site_permissions_page_view.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_site_permissions_page_view_interactive_uitest.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_site_permissions_page_view_unittest.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_test_util.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_view.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_view_interactive_uitest.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_view_unittest.cc
  • M chrome/browser/ui/views/extensions/extensions_request_access_button.cc
  • M chrome/browser/ui/views/extensions/extensions_toolbar_button.cc
  • M chrome/browser/ui/views/extensions/extensions_toolbar_desktop.cc
  • M chrome/browser/ui/views/extensions/extensions_toolbar_desktop_interactive_uitest.cc
  • M chrome/browser/ui/views/extensions/extensions_toolbar_desktop_view_controller.cc
  • M chrome/browser/ui/views/extensions/extensions_toolbar_interactive_uitest.cc
  • M chrome/browser/ui/views/extensions/extensions_toolbar_unittest.cc
  • M chrome/browser/ui/views/extensions/rich_radio_button.cc
  • M chrome/browser/ui/views/extensions/security_dialog_tracker_browsertest.cc
  • M chrome/browser/ui/views/extensions/settings_overridden_dialog_view_utils.cc
  • M chrome/browser/ui/views/eye_dropper/eye_dropper.cc
  • M chrome/browser/ui/views/eye_dropper/eye_dropper_aura.cc
  • M chrome/browser/ui/views/eye_dropper/eye_dropper_browsertest.cc
  • M chrome/browser/ui/views/file_system_access/file_system_access_browsertest.cc
  • M chrome/browser/ui/views/file_system_access/file_system_access_page_action_controller.cc
  • M chrome/browser/ui/views/file_system_access/file_system_access_restore_permission_bubble_view.cc
  • M chrome/browser/ui/views/file_system_access/file_system_access_restore_permission_bubble_view_browsertest.cc
  • M chrome/browser/ui/views/file_system_access/file_system_access_scroll_panel.cc
  • M chrome/browser/ui/views/file_system_access/file_system_access_usage_bubble_interactive_uitest.cc
  • M chrome/browser/ui/views/file_system_access/file_system_access_usage_bubble_view.cc
  • M chrome/browser/ui/views/file_system_access/file_system_access_views_helpers.cc
  • M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_linux.cc
  • M chrome/browser/ui/views/frame/browser_frame_view.cc
  • M chrome/browser/ui/views/frame/browser_frame_view_browsertest.cc
  • M chrome/browser/ui/views/frame/browser_frame_view_factory_views.cc
  • M chrome/browser/ui/views/frame/browser_frame_view_layout_linux.cc
  • M chrome/browser/ui/views/frame/browser_frame_view_layout_linux_native_unittest.cc
  • M chrome/browser/ui/views/frame/browser_frame_view_layout_linux_unittest.cc
  • M chrome/browser/ui/views/frame/browser_frame_view_linux.cc
  • M chrome/browser/ui/views/frame/browser_frame_view_linux_native.cc
  • M chrome/browser/ui/views/frame/browser_frame_view_unittest.cc
  • M chrome/browser/ui/views/frame/browser_native_widget_aura.cc
  • M chrome/browser/ui/views/frame/browser_native_widget_aura_linux.cc
  • M chrome/browser/ui/views/frame/browser_root_view.cc
  • M chrome/browser/ui/views/frame/browser_view_focus_interactive_uitest.cc
  • M chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
  • M chrome/browser/ui/views/frame/browser_widget.cc
  • M chrome/browser/ui/views/frame/browser_window_factory.cc
  • M chrome/browser/ui/views/frame/caption_button_placeholder_container.cc
  • M chrome/browser/ui/views/frame/contents_border_controller.cc
  • M chrome/browser/ui/views/frame/contents_container_outline.cc
  • M chrome/browser/ui/views/frame/contents_container_view.cc
  • M chrome/browser/ui/views/frame/contents_separator.cc
  • M chrome/browser/ui/views/frame/contents_web_view.cc
  • M chrome/browser/ui/views/frame/custom_floating_corner.cc
  • M chrome/browser/ui/views/frame/dbus_appmenu.cc
  • M chrome/browser/ui/views/frame/dbus_appmenu_registrar.cc
  • M chrome/browser/ui/views/frame/horizontal_tab_strip_region_view.cc
  • M chrome/browser/ui/views/frame/horizontal_tab_strip_region_view_interactive_uitest.cc
  • M chrome/browser/ui/views/frame/layout/browser_view_layout_delegate_impl.cc
  • M chrome/browser/ui/views/frame/layout/browser_view_layout_delegate_impl_browsertest.cc
  • M chrome/browser/ui/views/frame/layout/browser_view_tabbed_layout_impl.cc
  • M chrome/browser/ui/views/frame/multi_contents_drop_target_view.cc
  • M chrome/browser/ui/views/frame/multi_contents_drop_target_view_unittest.cc
  • M chrome/browser/ui/views/frame/multi_contents_resize_area.cc
  • M chrome/browser/ui/views/frame/multi_contents_view.cc
  • M chrome/browser/ui/views/frame/multi_contents_view_delegate.cc
  • M chrome/browser/ui/views/frame/multi_contents_view_drop_target_controller.cc
  • M chrome/browser/ui/views/frame/multi_contents_view_drop_target_controller_browsertest.cc
  • M chrome/browser/ui/views/frame/multi_contents_view_drop_target_controller_unittest.cc
  • M chrome/browser/ui/views/frame/multi_contents_view_mini_toolbar.cc
  • M chrome/browser/ui/views/frame/multi_contents_view_tab_drag_interactive_uitest.cc
  • M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
  • M chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
  • M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
  • M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
  • M chrome/browser/ui/views/frame/picture_in_picture_browser_frame_view.cc
  • M chrome/browser/ui/views/frame/scrim_view.cc
  • M chrome/browser/ui/views/frame/shadow_overlay_view.cc
  • M chrome/browser/ui/views/frame/system_menu_model_delegate.cc
  • M chrome/browser/ui/views/frame/test_with_browser_view.cc
  • M chrome/browser/ui/views/frame/themed_background.cc
  • M chrome/browser/ui/views/frame/top_container_view.cc
  • M chrome/browser/ui/views/frame/vertical_tab_strip_region_view.cc
  • M chrome/browser/ui/views/frame/vertical_tab_strip_region_view_browsertest.cc
  • M chrome/browser/ui/views/frame/vertical_tab_strip_region_view_interactive_uitest.cc
Change size: L
Delta: 107 files changed, 7 insertions(+), 342 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by David Pennington
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idab00f8c59148272b8b293a97b0770d83ea448c5
Gerrit-Change-Number: 7965161
Gerrit-PatchSet: 12
Gerrit-Owner: Kunal Daftari <kunald...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Kunal Daftari <kunald...@google.com>
Gerrit-CC: //chrome/browser/ui/views Reviews <chromium-chrome-brow...@google.com>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: gwsq
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages