[CrossThreadHandle] Convert third_party/blink/renderer/modules/file_system_access/file_system_access_regular_file_delegate.cc [chromium/src : main]

0 views
Skip to first unread message

Ari Chivukula (Gerrit)

unread,
Nov 22, 2022, 7:55:40 AM11/22/22
to blink-...@chromium.org, Yoav Weiss, chromium...@chromium.org

Attention is currently required from: Yoav Weiss.

Patch set 1:Auto-Submit +1Commit-Queue +1

View Change

    To view, visit change 4048000. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a4a1572a637a8e7b8df6ce61e71091621fe4997
    Gerrit-Change-Number: 4048000
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ari Chivukula <ari...@chromium.org>
    Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-Attention: Yoav Weiss <yoav...@chromium.org>
    Gerrit-Comment-Date: Tue, 22 Nov 2022 12:53:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Yoav Weiss (Gerrit)

    unread,
    Nov 25, 2022, 4:36:50 AM11/25/22
    to Ari Chivukula, blink-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Ari Chivukula.

    Patch set 1:Code-Review +1Commit-Queue +2

    View Change

      To view, visit change 4048000. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7a4a1572a637a8e7b8df6ce61e71091621fe4997
      Gerrit-Change-Number: 4048000
      Gerrit-PatchSet: 1
      Gerrit-Owner: Ari Chivukula <ari...@chromium.org>
      Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>
      Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
      Gerrit-Attention: Ari Chivukula <ari...@chromium.org>
      Gerrit-Comment-Date: Fri, 25 Nov 2022 09:33:52 +0000

      Ari Chivukula (Gerrit)

      unread,
      Nov 25, 2022, 2:12:15 PM11/25/22
      to blink-...@chromium.org, Yoav Weiss, Chromium LUCI CQ, chromium...@chromium.org

      Patch set 2:Commit-Queue +2

      View Change

        To view, visit change 4048000. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I7a4a1572a637a8e7b8df6ce61e71091621fe4997
        Gerrit-Change-Number: 4048000
        Gerrit-PatchSet: 2
        Gerrit-Owner: Ari Chivukula <ari...@chromium.org>
        Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>
        Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
        Gerrit-Comment-Date: Fri, 25 Nov 2022 19:09:54 +0000

        Ari Chivukula (Gerrit)

        unread,
        Nov 25, 2022, 11:17:02 PM11/25/22
        to blink-...@chromium.org, Yoav Weiss, Chromium LUCI CQ, chromium...@chromium.org

        Patch set 3:Auto-Submit +1Commit-Queue +2

        View Change

          To view, visit change 4048000. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I7a4a1572a637a8e7b8df6ce61e71091621fe4997
          Gerrit-Change-Number: 4048000
          Gerrit-PatchSet: 3
          Gerrit-Owner: Ari Chivukula <ari...@chromium.org>
          Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>
          Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
          Gerrit-Comment-Date: Sat, 26 Nov 2022 04:15:11 +0000

          Ari Chivukula (Gerrit)

          unread,
          Nov 26, 2022, 8:02:31 AM11/26/22
          to blink-...@chromium.org, Yoav Weiss, Chromium LUCI CQ, chromium...@chromium.org

          Attention is currently required from: Ari Chivukula.

          Patch set 3:Commit-Queue +2

          View Change

            To view, visit change 4048000. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I7a4a1572a637a8e7b8df6ce61e71091621fe4997
            Gerrit-Change-Number: 4048000
            Gerrit-PatchSet: 3
            Gerrit-Owner: Ari Chivukula <ari...@chromium.org>
            Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>
            Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
            Gerrit-Attention: Ari Chivukula <ari...@chromium.org>
            Gerrit-Comment-Date: Sat, 26 Nov 2022 12:59:49 +0000

            Ari Chivukula (Gerrit)

            unread,
            Nov 26, 2022, 12:15:19 PM11/26/22
            to blink-...@chromium.org, Yoav Weiss, Chromium LUCI CQ, chromium...@chromium.org

            Patch set 4:Commit-Queue +2

            View Change

              To view, visit change 4048000. To unsubscribe, or for help writing mail filters, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I7a4a1572a637a8e7b8df6ce61e71091621fe4997
              Gerrit-Change-Number: 4048000
              Gerrit-PatchSet: 4
              Gerrit-Owner: Ari Chivukula <ari...@chromium.org>
              Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>
              Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
              Gerrit-Comment-Date: Sat, 26 Nov 2022 17:11:55 +0000

              Chromium LUCI CQ (Gerrit)

              unread,
              Nov 26, 2022, 12:16:02 PM11/26/22
              to Ari Chivukula, blink-...@chromium.org, Yoav Weiss, chromium...@chromium.org

              Chromium LUCI CQ submitted this change.

              View Change



              1 is the latest approved patch-set.
              No files were changed between the latest approved patch-set and the submitted one.

              Approvals: Ari Chivukula: Send CL to CQ automatically after approval; Commit Yoav Weiss: Looks good to me
              [CrossThreadHandle] Convert third_party/blink/renderer/modules/file_system_access/file_system_access_regular_file_delegate.cc

              This is part of a cleanup task to make memory safer when data isn't used
              cross thread, but is instead merely passed to be used back again on the
              originating thread. Design doc:
              https://docs.google.com/document/d/1GIT0ysdQ84sGhIo1r9EscF_fFt93lmNVM_q4vvHj2FQ/edit#

              Bug: 1377340
              Change-Id: I7a4a1572a637a8e7b8df6ce61e71091621fe4997

              fuzzer infra failure

              No-Try: true
              Change-Id: I7a4a1572a637a8e7b8df6ce61e71091621fe4997
              Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4048000
              Commit-Queue: Ari Chivukula <ari...@chromium.org>
              Reviewed-by: Yoav Weiss <yoav...@chromium.org>
              Auto-Submit: Ari Chivukula <ari...@chromium.org>
              Cr-Commit-Position: refs/heads/main@{#1075897}
              ---
              M third_party/blink/renderer/modules/file_system_access/file_system_access_regular_file_delegate.cc
              M third_party/blink/renderer/modules/file_system_access/file_system_access_regular_file_delegate.h
              2 files changed, 48 insertions(+), 21 deletions(-)


              To view, visit change 4048000. To unsubscribe, or for help writing mail filters, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I7a4a1572a637a8e7b8df6ce61e71091621fe4997
              Gerrit-Change-Number: 4048000
              Gerrit-PatchSet: 5
              Gerrit-Owner: Ari Chivukula <ari...@chromium.org>
              Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>
              Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
              Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
              Gerrit-MessageType: merged
              Reply all
              Reply to author
              Forward
              0 new messages