[iOS] Add support for kFillAutofillAi in AutofillAgent [chromium/src : main]
0 views
Skip to first unread message
Alexis Hétu (Gerrit)
Feb 6, 2026, 4:52:20 PM (20 hours ago) Feb 6
to Sebastien S-G, Vincent Boisselle, chromium...@chromium.org, browser-comp...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Sebastien S-G and Vincent Boisselle
Alexis Hétu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Sebastien S-G
- Vincent Boisselle
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sebastien S-G (Gerrit)
Feb 6, 2026, 5:23:50 PM (19 hours ago) Feb 6
to Alexis Hétu, Chromium LUCI CQ, Vincent Boisselle, chromium...@chromium.org, browser-comp...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Alexis Hétu and Vincent Boisselle
Sebastien S-G voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexis Hétu
- Vincent Boisselle
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vincent Boisselle (Gerrit)
6:51 AM (6 hours ago) 6:51 AM
to Alexis Hétu, Sebastien S-G, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Alexis Hétu
Vincent Boisselle voted and added 2 comments![]( "Open in Gerrit")
Votes added by Vincent Boisselle
| Code-Review | +1 |
2 comments
File components/autofill/ios/browser/autofill_agent.mm
Line 170, Patchset 1 (Latest):
return std::visit(Vincent Boisselle . unresolved
There is also the absl::Overload alternative that is bit less cryptic, but we don't really have specific guidance for choosing one over the other
```
bool HasGuid(const Suggestion::Payload& payload) {
return std::visit(absl::Overload{
// Duplicated logic for these two types
[](const Suggestion::AutofillProfilePayload& p) { return !p.guid.value().empty(); },
[](const Suggestion::AutofillAiPayload& p) { return !p.guid.value().empty(); },
[](const Suggestion::Guid& p) { return !p.value().empty(); },
[](const auto&) { return false; } // Catch-all
}, payload);
}
```up to you
Line 414, Patchset 1 (Latest):
(base::FeatureList::IsEnabled(
autofill::features::kAutofillAiServerModel) &&
suggestion.type == SuggestionType::kFillAutofillAi)) {Vincent Boisselle . unresolved
note that is usually be to but the feature flag at the very end in a chain of conditions, but in this case I think it doesn't really matter,
the idea being to only trigger (enroll the client into the an experimental group) when the feature is usable
but kFillAutofillAi is probably triggered way before this
Related details
Attention is currently required from:
- Alexis Hétu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages