Remove obsolete frame_header_ null checks in BrowserFrameViewChromeOS [chromium/src : main]
1 view
Skip to first unread message
Zoraiz Naeem (Gerrit)
May 27, 2026, 2:55:18 AM (yesterday) May 27
to Thomas Lukaszewicz, Achuith Bhandarkar, chromium...@chromium.org
Attention needed from Thomas Lukaszewicz
Zoraiz Naeem voted and added 1 comment![]( "Open in Gerrit")
Votes added by Zoraiz Naeem
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zoraiz Naeem (Gerrit)
May 27, 2026, 2:55:57 AM (yesterday) May 27
to Jack Geng, Chromium LUCI CQ, Thomas Lukaszewicz, Achuith Bhandarkar, chromium...@chromium.org
Attention needed from Jack Geng and Thomas Lukaszewicz
Zoraiz Naeem added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Jack Geng
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
May 27, 2026, 4:36:34 AM (yesterday) May 27
to Zoraiz Naeem, Jack Geng, Chromium LUCI CQ, Achuith Bhandarkar, chromium...@chromium.org
Attention needed from Jack Geng and Zoraiz Naeem
Thomas Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Lukaszewicz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jack Geng
- Zoraiz Naeem
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Geng (Gerrit)
May 27, 2026, 1:19:35 PM (yesterday) May 27
to Zoraiz Naeem, Thomas Lukaszewicz, Chromium LUCI CQ, Achuith Bhandarkar, chromium...@chromium.org
Attention needed from Zoraiz Naeem
Jack Geng added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Zoraiz Naeem
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zoraiz Naeem (Gerrit)
1:33 PM (3 hours ago) 1:33 PM
to Thomas Lukaszewicz, Jack Geng, Chromium LUCI CQ, Achuith Bhandarkar, chromium...@chromium.org
Zoraiz Naeem voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:34 PM (1 hour ago) 3:34 PM
to Zoraiz Naeem, Thomas Lukaszewicz, Jack Geng, Achuith Bhandarkar, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove obsolete frame_header_ null checks in BrowserFrameViewChromeOS
Following the removal of the ARC CCT feature in crrev.com/c/7459394,
frame_header_ is now unconditionally initialized in
`BrowserFrameViewChromeOS::Init()`.
This CL cleans up the remaining null checks that were left behind,
simplifying the code.
Bug: 474406675
Change-Id: Iabede1f51b672a08a6feeeee0b8f7a70416d12ed
Commit-Queue: Zoraiz Naeem <zorai...@chromium.org>
Auto-Submit: Zoraiz Naeem <zorai...@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1637874}
Files:
- M chrome/browser/ui/views/frame/browser_frame_view_chromeos.cc
Change size: M
Delta: 1 file changed, 17 insertions(+), 40 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages