Daniel Cheng (Gerrit)

unread,

12:59 PM (8 hours ago) 12:59 PM

to Daniel Cheng, David Benjamin, Mitsuru Oshima, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, max+watc...@igalia.com, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org

Attention needed from Dave Tapuska, David Benjamin and Mitsuru Oshima

Daniel Cheng added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Daniel Cheng . resolved

@davidben for //base and //net
@dtapuska for //third_party/blink and //ui
@oshima for //ui

Open in Gerrit

Related details

Attention is currently required from:

Dave Tapuska
David Benjamin
Mitsuru Oshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

1:12 PM (8 hours ago) 1:12 PM

to Daniel Cheng, David Benjamin, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, max+watc...@igalia.com, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org

Attention needed from Daniel Cheng, Dave Tapuska and David Benjamin

Mitsuru Oshima added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Mitsuru Oshima . resolved

ui/ lgtm

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Dave Tapuska
David Benjamin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Benjamin (Gerrit)

unread,

1:16 PM (7 hours ago) 1:16 PM

to Daniel Cheng, Mitsuru Oshima, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, max+watc...@igalia.com, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org

Attention needed from Daniel Cheng and Dave Tapuska

David Benjamin voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Dave Tapuska

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dave Tapuska (Gerrit)

unread,

6:07 PM (3 hours ago) 6:07 PM

to Daniel Cheng, David Benjamin, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, max+watc...@igalia.com, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org

Attention needed from Daniel Cheng

Dave Tapuska voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

6:21 PM (2 hours ago) 6:21 PM

to Daniel Cheng, Dave Tapuska, David Benjamin, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, max+watc...@igalia.com, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org

Attention needed from Daniel Cheng

Mitsuru Oshima voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

6:29 PM (2 hours ago) 6:29 PM

to Daniel Cheng, Mitsuru Oshima, Dave Tapuska, David Benjamin, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, max+watc...@igalia.com, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org

Daniel Cheng voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

6:34 PM (2 hours ago) 6:34 PM

to Daniel Cheng, Mitsuru Oshima, Dave Tapuska, David Benjamin, chromium...@chromium.org, Hongchan Choi, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, max+watc...@igalia.com, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Replace std::nan(), et cetera with std::numeric_limits<...>::quiet_NaN()

While clang optimizes `std::numeric_limits<double>::quiet_NaN()` and
`std::nan()` to the same thing, `quiet_NaN()` is more common and
subjectively more readable, since it does not accept any arguments.

Change-Id: I4d2f20400a3c0eac7ede69e1239825317fbe431d

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7477341

Reviewed-by: Dave Tapuska <dtap...@chromium.org>

Reviewed-by: Mitsuru Oshima <osh...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Reviewed-by: David Benjamin <davi...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1570059}

Files:

M base/trace_event/traced_value_unittest.cc
M net/socket/socket_pool_additional_capacity_unittest.cc
M third_party/blink/renderer/modules/mediasession/media_session_test.cc
M third_party/blink/renderer/platform/audio/biquad.cc
M third_party/blink/renderer/platform/audio/iir_filter.cc
M ui/events/blink/blink_event_util_unittest.cc
M ui/ozone/platform/wayland/wayland_buffer_manager_unittest.cc

Change size: M

Delta: 7 files changed, 35 insertions(+), 20 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Dave Tapuska, +1 by Mitsuru Oshima, +1 by David Benjamin

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Replace std::nan(), et cetera with std::numeric_limits<...>::quiet_NaN() [chromium/src : main]

Daniel Cheng (Gerrit)

Daniel Cheng added 1 comment

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima added 1 comment

Related details

David Benjamin (Gerrit)

David Benjamin voted Code-Review+1

Related details

Dave Tapuska (Gerrit)

Dave Tapuska voted Code-Review+1

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima voted Code-Review+1

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information