[ios] Refactor PrintCoordinator [chromium/src : main]

0 views
Skip to first unread message

Asami Doi (Gerrit)

unread,
Jan 13, 2026, 3:32:47 AM (24 hours ago) Jan 13
to Mark Cogan, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Mark Cogan

Asami Doi added 1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Asami Doi . resolved

marq@: Can you review this CL? Thank you.

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Cogan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4e2cf556857c313bdbf94754cf9c5c0173466a2
Gerrit-Change-Number: 7321861
Gerrit-PatchSet: 10
Gerrit-Owner: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Mark Cogan <ma...@chromium.org>
Gerrit-Attention: Mark Cogan <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 08:32:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Cogan (Gerrit)

unread,
Jan 13, 2026, 11:53:12 AM (15 hours ago) Jan 13
to Asami Doi, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Asami Doi

Mark Cogan voted and added 1 comment

Votes added by Mark Cogan

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Mark Cogan . resolved

LGTM, thanks for the cleanup!

Open in Gerrit

Related details

Attention is currently required from:
  • Asami Doi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4e2cf556857c313bdbf94754cf9c5c0173466a2
Gerrit-Change-Number: 7321861
Gerrit-PatchSet: 11
Gerrit-Owner: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Mark Cogan <ma...@chromium.org>
Gerrit-Attention: Asami Doi <asam...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 16:52:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Asami Doi (Gerrit)

unread,
12:21 AM (3 hours ago) 12:21 AM
to Mark Cogan, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Asami Doi voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4e2cf556857c313bdbf94754cf9c5c0173466a2
Gerrit-Change-Number: 7321861
Gerrit-PatchSet: 11
Gerrit-Owner: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Mark Cogan <ma...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Jan 2026 05:21:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
12:48 AM (2 hours ago) 12:48 AM
to Asami Doi, Mark Cogan, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[ios] Refactor PrintCoordinator

Refactor PrintCoordinator to remove the dependency to WebState by
removing WebStatePrinter protocol and exposing printView: and
printImage: via PrintHandler protocol. No behavior changes.

This refactored PrintCoordinator will be used in a follow-up CL:
crrev.com/c/7274439
Change-Id: Id4e2cf556857c313bdbf94754cf9c5c0173466a2
Commit-Queue: Asami Doi <asam...@chromium.org>
Reviewed-by: Mark Cogan <ma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568910}
Files:
  • M ios/chrome/browser/browser_view/ui_bundled/browser_coordinator.mm
  • M ios/chrome/browser/print/coordinator/BUILD.gn
  • M ios/chrome/browser/print/coordinator/DEPS
  • M ios/chrome/browser/print/coordinator/print_coordinator.h
  • M ios/chrome/browser/print/coordinator/print_coordinator.mm
  • M ios/chrome/browser/web/model/DEPS
  • M ios/chrome/browser/web/model/print/BUILD.gn
  • A ios/chrome/browser/web/model/print/print_handler.h
  • M ios/chrome/browser/web/model/print/print_java_script_feature_unittest.mm
  • M ios/chrome/browser/web/model/print/print_tab_helper.h
  • M ios/chrome/browser/web/model/print/print_tab_helper.mm
  • M ios/chrome/browser/web/model/print/print_tab_helper_unittest.mm
  • D ios/chrome/browser/web/model/print/web_state_printer.h
Change size: M
Delta: 13 files changed, 95 insertions(+), 88 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Cogan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4e2cf556857c313bdbf94754cf9c5c0173466a2
Gerrit-Change-Number: 7321861
Gerrit-PatchSet: 12
Gerrit-Owner: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mark Cogan <ma...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages