[Toolbar] Add metric to detect stale captures [chromium/src : main]

0 views
Skip to first unread message

Peilin Wang (Gerrit)

unread,
12:09 PM (9 hours ago) 12:09 PM
to Yaron Friedman, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
Attention needed from Yaron Friedman

Peilin Wang added 1 comment

File chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarControlContainer.java
Line 811, Patchset 1 (Latest): "Android.Toolbar.StaleCapturedUrlOnScroll", isCaptureStale);
Peilin Wang . unresolved

I don't remember if histogram recording is significant enough to cause jank. Is this ok, or should we post a task to delay until after the scroll is finished?

Open in Gerrit

Related details

Attention is currently required from:
  • Yaron Friedman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iab8fab49cd92caf0808efffadb4a10bad1a00f69
Gerrit-Change-Number: 6983186
Gerrit-PatchSet: 1
Gerrit-Owner: Peilin Wang <peili...@google.com>
Gerrit-Reviewer: Yaron Friedman <yfri...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Yaron Friedman <yfri...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 16:09:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages