Roll clap: 4.5.53 => 4.5.54 in //third_party/rust. [chromium/src : main]

1 view
Skip to first unread message

Alex Kallam (Gerrit)

unread,
Jan 9, 2026, 11:45:58 AM (2 days ago) Jan 9
to chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from chrome-third-pa...@google.com

Alex Kallam added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Alex Kallam . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I04bfdb5f89af71973dc7f4d7277c80b9b54fddf6
Gerrit-Change-Number: 7417143
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Alex Kallam <aaka...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 16:45:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jan 9, 2026, 11:47:44 AM (2 days ago) Jan 9
to Alex Kallam, chrome-third-pa...@google.com, Łukasz Anforowicz, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Łukasz Anforowicz

Message from gwsq

From googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq:
third-party-rust: luk...@chromium.org

It looks like you’re modifying `//third_party/rust`. An appropriate reviewer has been automatically added to this CL.

`//third_party/rust` reviewer(s): luk...@chromium.org


Reviewer source(s):
luk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Łukasz Anforowicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I04bfdb5f89af71973dc7f4d7277c80b9b54fddf6
Gerrit-Change-Number: 7417143
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 16:47:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Łukasz Anforowicz (Gerrit)

unread,
Jan 9, 2026, 11:49:03 AM (2 days ago) Jan 9
to Alex Kallam, chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Alex Kallam

Łukasz Anforowicz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Kallam
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I04bfdb5f89af71973dc7f4d7277c80b9b54fddf6
Gerrit-Change-Number: 7417143
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Alex Kallam <aaka...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 16:48:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 10, 2026, 9:07:47 PM (20 hours ago) Jan 10
to Alex Kallam, Daniel Cheng, Łukasz Anforowicz, chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Alex Kallam

Daniel Cheng voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Kallam
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I04bfdb5f89af71973dc7f4d7277c80b9b54fddf6
Gerrit-Change-Number: 7417143
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Alex Kallam <aaka...@chromium.org>
Gerrit-Comment-Date: Sun, 11 Jan 2026 02:07:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 10, 2026, 11:29:10 PM (18 hours ago) Jan 10
to Alex Kallam, Daniel Cheng, Łukasz Anforowicz, chrome-third-pa...@google.com, chromium...@chromium.org, chrome-rust-exper...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
Roll clap: 4.5.53 => 4.5.54 in //third_party/rust.

This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md

Updated crates:

* clap: 4.5.53 => 4.5.54; https://docs.rs/crate/clap/4.5.54
* clap_builder: 4.5.53 => 4.5.54;
https://docs.rs/crate/clap_builder/4.5.54
Bug: None
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Disable-Rts: True
Change-Id: I04bfdb5f89af71973dc7f4d7277c80b9b54fddf6
Reviewed-by: Łukasz Anforowicz <luk...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567484}
Files:
  • M third_party/rust/chromium_crates_io/Cargo.lock
  • M third_party/rust/chromium_crates_io/vendor/clap-v4/.cargo_vcs_info.json
  • M third_party/rust/chromium_crates_io/vendor/clap-v4/Cargo.lock
  • M third_party/rust/chromium_crates_io/vendor/clap-v4/Cargo.toml
  • M third_party/rust/chromium_crates_io/vendor/clap-v4/Cargo.toml.orig
  • M third_party/rust/chromium_crates_io/vendor/clap-v4/src/lib.rs
  • M third_party/rust/chromium_crates_io/vendor/clap_builder-v4/.cargo_vcs_info.json
  • M third_party/rust/chromium_crates_io/vendor/clap_builder-v4/Cargo.lock
  • M third_party/rust/chromium_crates_io/vendor/clap_builder-v4/Cargo.toml
  • M third_party/rust/chromium_crates_io/vendor/clap_builder-v4/Cargo.toml.orig
  • M third_party/rust/chromium_crates_io/vendor/clap_builder-v4/src/output/help_template.rs
  • M third_party/rust/clap/v4/BUILD.gn
  • M third_party/rust/clap/v4/README.chromium
  • M third_party/rust/clap_builder/v4/BUILD.gn
  • M third_party/rust/clap_builder/v4/README.chromium
Change size: S
Delta: 15 files changed, 25 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Łukasz Anforowicz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I04bfdb5f89af71973dc7f4d7277c80b9b54fddf6
Gerrit-Change-Number: 7417143
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages