[WebSocket/H3] Add byte count accessors to WebSocketQuicStreamAdapter [chromium/src : main]
0 views
Skip to first unread message
Nidhi Jaju (Gerrit)
Feb 27, 2026, 4:29:01 AM (3 days ago) Feb 27
to Mayur Patil, Adam Rice, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ricea...@chromium.org
Attention needed from Adam Rice and Mayur Patil
Nidhi Jaju voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Adam Rice
- Mayur Patil
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
Feb 27, 2026, 7:29:08 AM (3 days ago) Feb 27
to Mayur Patil, Nidhi Jaju, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ricea...@chromium.org
Attention needed from Mayur Patil
Adam Rice voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Rice
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Adam Rice . resolved
lgtm
Thanks for the test cleanups, they will help avoid flakiness in future.
Related details
Attention is currently required from:
- Mayur Patil
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mayur Patil (Gerrit)
Mar 1, 2026, 11:24:41 PM (4 hours ago) Mar 1
to Adam Rice, Nidhi Jaju, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ricea...@chromium.org
Mayur Patil voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:24 AM (3 hours ago) 12:24 AM
to Mayur Patil, Adam Rice, Nidhi Jaju, AyeAye, chromium...@chromium.org, net-r...@chromium.org, ricea...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[WebSocket/H3] Add byte count accessors to WebSocketQuicStreamAdapter
Add stream_bytes_read() and stream_bytes_written() to
WebSocketQuicStreamAdapter, delegating to the underlying
WebSocketQuicSpdyStream. These return 0 after Disconnect() when the
stream pointer is cleared.
Use these to implement GetTotalReceivedBytes() and GetTotalSentBytes()
in WebSocketHttp3HandshakeStream, replacing the stub implementations
that previously returned 0.
Integrate byte-count assertions into existing Read, Write, and
Disconnect tests for both HTTP/2 and HTTP/3 adapters. Migrate all
RunUntilIdle() calls to base::test::RunUntil() with explicit
predicates for improved test robustness.
Bug: 40210995
Change-Id: Idb9518297ed39dc3286bd120c0991da1a4120ed7
Commit-Queue: Mayur Patil <patil...@microsoft.com>
Reviewed-by: Nidhi Jaju <nidh...@chromium.org>
Reviewed-by: Adam Rice <ri...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1592247}
Files:
- M net/websockets/websocket_basic_stream_adapters.cc
- M net/websockets/websocket_basic_stream_adapters.h
- M net/websockets/websocket_basic_stream_adapters_test.cc
- M net/websockets/websocket_handshake_stream_create_helper_test.cc
- M net/websockets/websocket_http3_handshake_stream.cc
Change size: M
Delta: 5 files changed, 100 insertions(+), 66 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Adam Rice, +1 by Nidhi Jaju
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages