[VerticalTabs] Re-enable all flaky tests on Windows [chromium/src : main]
0 views
Skip to first unread message
Darryl James (Gerrit)
Dec 12, 2025, 5:33:59 PM (4 days ago) Dec 12
to Chromium LUCI CQ, chromium...@chromium.org
Darryl James added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Darryl James . resolved
Re-running this on win-rel to double check if tests are still flaky. If that run passes I have fair confidence that the flake is fixed or at the very least heavily mitigated 👍
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Gale (Gerrit)
Dec 15, 2025, 2:31:00 PM (21 hours ago) Dec 15
to Darryl James, Caroline Rising, Eshwar Stalin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Caroline Rising and Darryl James
Alison Gale voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Caroline Rising
- Darryl James
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Caroline Rising (Gerrit)
Dec 15, 2025, 2:51:57 PM (20 hours ago) Dec 15
to Darryl James, Alison Gale, Eshwar Stalin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Darryl James
Caroline Rising voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Darryl James
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Dec 15, 2025, 3:01:01 PM (20 hours ago) Dec 15
to Caroline Rising, Alison Gale, Eshwar Stalin, Chromium LUCI CQ, chromium...@chromium.org
Darryl James voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 15, 2025, 3:04:46 PM (20 hours ago) Dec 15
to Darryl James, Caroline Rising, Alison Gale, Eshwar Stalin, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[VerticalTabs] Re-enable all flaky tests on Windows
Regarding the change in crrev.com/c/7253837, previously disabled
VerticalTabStrip tests are being re-enabled since it is believed the
issues causing the tests to be flaky have been resolved at this point in
time. Fixed by this CL - crrev.com/c/7254711 - where the order of
entering vertical tabs mode was changed to happen before the browser was
setup. This prevents a race condition where both tabstrips (horizontal
and vertical) are referenced within the same test.
Change-Id: I48500c3b6b5c3791303660496b3914d7f6f045ed
Bug: 464486134
Reviewed-by: Alison Gale <ag...@chromium.org>
Commit-Queue: Darryl James <dlj...@chromium.org>
Reviewed-by: Caroline Rising <cori...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1558911}
Files:
- M chrome/browser/ui/views/tabs/vertical/vertical_split_tab_view_browsertest.cc
- M chrome/browser/ui/views/tabs/vertical/vertical_tab_view_browsertest.cc
Change size: S
Delta: 2 files changed, 0 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Caroline Rising, +1 by Alison Gale
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bruno Braga (Gerrit)
6:49 AM (4 hours ago) 6:49 AM
to Chromium LUCI CQ, Darryl James, Caroline Rising, Alison Gale, Eshwar Stalin, chromium...@chromium.org
Bruno Braga added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Bruno Braga . resolved
This seems to still be a problem https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64/105799/overview
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Gale (Gerrit)
10:38 AM (1 hour ago) 10:38 AM
to Chromium LUCI CQ, Darryl James, Bruno Braga, Caroline Rising, Eshwar Stalin, chromium...@chromium.org
Alison Gale has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages