aura: Handle window deletion during LockPointer [chromium/src : main]
0 views
Skip to first unread message
Mitsuru Oshima (Gerrit)
Jul 24, 2026, 3:43:11 PM (24 hours ago) Jul 24
to Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, Zhe Su, alexmo...@chromium.org, creis...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Alex Moshchuk
Mitsuru Oshima voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alex Moshchuk
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Moshchuk (Gerrit)
Jul 24, 2026, 6:05:40 PM (22 hours ago) Jul 24
to Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, Zhe Su, alexmo...@chromium.org, creis...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Mitsuru Oshima
Alex Moshchuk voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mitsuru Oshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
10:34 AM (5 hours ago) 10:34 AM
to Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, Zhe Su, alexmo...@chromium.org, creis...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Mitsuru Oshima voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:38 AM (5 hours ago) 10:38 AM
to Mitsuru Oshima, Alex Moshchuk, chromium...@chromium.org, Sadrul Chowdhury, Zhe Su, alexmo...@chromium.org, creis...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
aura: Handle window deletion during LockPointer
Use an aura::Window::ScopedDeleteBlocker in
RenderWidgetHostViewEventHandler::LockPointer to ensure that the window
(and by extension, the event handler) are not deleted prematurely while
executing.
Just checking weakptr in
RenderWidgetHostViewEventHandler and WindowTreeHostPlatform
as suggested in the bug is not enough(see bug). If we find a valid
use case for this deletion, we'll work on a different approach.
Bug: 532921800
Test: covered by unittest
TAG=agy
CONV=6a632318-b810-4c6e-a0e2-1135bf67758d
Change-Id: Iffe955d91dd88a2f99bf36d83517dc64d36da7a7
Reviewed-by: Alex Moshchuk <ale...@chromium.org>
Commit-Queue: Mitsuru Oshima <osh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1668283}
Files:
- M content/browser/renderer_host/render_widget_host_view_event_handler.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Moshchuk
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages