PK longpress diacritics: Add pref metric [chromium/src : main]
jhtin (Gerrit)
Attention is currently required from: Essential Inputs Reviews.
To view, visit change 3815109. To unsubscribe, or for help writing mail filters, visit settings.
gwsq (Gerrit)
Attention is currently required from: Keith Lee, Mehrab N.
Reviewer source(s):
keit...@chromium.org, meh...@chromium.org is from context
jhtin (Gerrit)
Attention is currently required from: Keith Lee, Mehrab N.
Patch set 2:Auto-Submit +1Commit-Queue +1
jhtin (Gerrit)
Attention is currently required from: Keith Lee, Mehrab N.
Patch set 3:Auto-Submit +1
gwsq (Gerrit)
Attention is currently required from: Caitlin Fischer, Keith Lee, Mehrab N.
From analysis/uma/chrome-metrics.gwsq:
Histograms should by default be reviewed by the owners of the subdirectories. The chromium-met...@google.com gwsq should be used when there are no individual owners, or for escalation to the Metrics team.
If you are interested in becoming a metrics reviewer, please review the instructions at https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#Becoming-a-Metrics-Reviewer
Reviewer source(s):
caitlin...@google.com is from context
Caitlin Fischer (Gerrit)
Attention is currently required from: Keith Lee, Mehrab N, jhtin.
1 comment:
Patchset:
Prefer owners in https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/metadata/input/OWNERS.
If the owners are all OOO, then please feel free to re-add me directly, and I'll TAL.
To view, visit change 3815109. To unsubscribe, or for help writing mail filters, visit settings.
jhtin (Gerrit)
Attention is currently required from: Darren Shen, Keith Lee, Mehrab N.
Patch set 4:Auto-Submit +1
Darren Shen (Gerrit)
Attention is currently required from: Keith Lee, Mehrab N, jhtin.
Patch set 4:Code-Review +1
Mehrab N (Gerrit)
Attention is currently required from: Keith Lee, jhtin.
Patch set 4:Code-Review +1
To view, visit change 3815109. To unsubscribe, or for help writing mail filters, visit settings.
Keith Lee (Gerrit)
Attention is currently required from: jhtin.
Patch set 4:Code-Review +1Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
PK longpress diacritics: Add pref metric
Bug: b/241729161
Change-Id: I89c1188603ff34b4befa6abb00f2f4b700135bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3815109
Reviewed-by: Darren Shen <sh...@chromium.org>
Reviewed-by: Keith Lee <keit...@chromium.org>
Commit-Queue: Keith Lee <keit...@chromium.org>
Reviewed-by: Mehrab N <meh...@chromium.org>
Auto-Submit: jhtin <jh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032872}
---
M chrome/browser/ash/input_method/assistive_suggester.cc
M chrome/browser/ash/input_method/assistive_suggester_unittest.cc
M tools/metrics/histograms/metadata/input/histograms.xml
3 files changed, 69 insertions(+), 0 deletions(-)