[Blink] Remove redundant check in RtcVideoEncoder [chromium/src : main]
0 views
Skip to first unread message
Kentaro Hara (Gerrit)
Jan 5, 2026, 1:58:41 PM (7 days ago) Jan 5
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hirokazu Honda, blink-...@chromium.org, kinuko...@chromium.org, video-networking...@google.com
Attention needed from Colin Blundell
Kentaro Hara voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 6, 2026, 3:26:54 AM (7 days ago) Jan 6
to Colin Blundell, Kentaro Hara, chromium...@chromium.org, Hirokazu Honda, blink-...@chromium.org, kinuko...@chromium.org, video-networking...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Blink] Remove redundant check in RtcVideoEncoder
Following the elimination of GpuMemoryBuffer, the only way to create a
VideoFrame with STORAGE_MAPPABLE_SHARED_IMAGE is via [1] or by wrapping
a VideoFrame created via [1]. This will result in
VideoFrame::HasSharedImage() returning true due to [2][3][4]. Hence, the
first part of the conditional here is now unneeded: if the
storage type is STORAGE_MAPPABLE_SHARED_IMAGE then HasSharedImage() will
be guaranteed to be true, so we can just check IsSharedImage() rather
than having the two checks or'd together.
[1] https://source.chromium.org/chromium/chromium/src/+/main:media/base/video_frame.cc;l=390?q=WrapMappableSha&ss=chromium
[2] https://source.chromium.org/chromium/chromium/src/+/main:media/base/video_frame.cc;l=397?q=WrapMappableSha&ss=chromium
[3] https://source.chromium.org/chromium/chromium/src/+/main:media/base/video_frame.cc;l=484?q=WrapMappableSha&ss=chromium
[4] https://source.chromium.org/chromium/chromium/src/+/main:media/base/video_frame.cc;l=1166-1167;drc=56535b80c32d3a618b8fc8cfd7b1afdd3862e1b2;bpv=1;bpt=1
Bug: 404905709
Change-Id: I67e96194eb24a98459d0e52ac9109d3ab5fb45fd
Commit-Queue: Colin Blundell <blun...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1564835}
Files:
- M third_party/blink/renderer/platform/peerconnection/rtc_video_encoder.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kentaro Hara
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
Jan 9, 2026, 11:19:07 AM (3 days ago) Jan 9
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Hirokazu Honda, blink-...@chromium.org, kinuko...@chromium.org, video-networking...@google.com
Attention needed from Colin Blundell
Mingjing Zhang voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
10:13 AM (10 hours ago) 10:13 AM
to Colin Blundell, Kentaro Hara, Mingjing Zhang, Chromium LUCI CQ, chromium...@chromium.org, Hirokazu Honda, blink-...@chromium.org, kinuko...@chromium.org, video-networking...@google.com
Attention needed from Kentaro Hara
Colin Blundell added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
10:42 AM (10 hours ago) 10:42 AM
to Colin Blundell, Mingjing Zhang, Chromium LUCI CQ, chromium...@chromium.org, Hirokazu Honda, blink-...@chromium.org, kinuko...@chromium.org, video-networking...@google.com
Attention needed from Colin Blundell
Kentaro Hara voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
11:05 AM (9 hours ago) 11:05 AM
to Colin Blundell, Kentaro Hara, Mingjing Zhang, Chromium LUCI CQ, chromium...@chromium.org, Hirokazu Honda, blink-...@chromium.org, kinuko...@chromium.org, video-networking...@google.com
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:07 PM (8 hours ago) 12:07 PM
to Colin Blundell, Kentaro Hara, Mingjing Zhang, chromium...@chromium.org, Hirokazu Honda, blink-...@chromium.org, kinuko...@chromium.org, video-networking...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Blink] Remove redundant check in RtcVideoEncoder
HasNativeMappableSharedImage() is true iff
(HasMappableSharedImage() && !SI is shmem) [1]
Thus, !HasNativeMappableSharedImage() is
(!HasMappableSharedImage() || SI is shmem)
Since this !HasNativeMappableSharedImage() check is &&'d with a direct
!HasMappableSharedImage() check, the !HasNativeMappableSharedImage()
check itself is redundant.
[1] https://source.chromium.org/chromium/chromium/src/+/main:media/base/video_frame.cc;l=1179-1182?q=HasNativeMappable&ss=chromium
Bug: 404905709
Change-Id: I53784c5b26e301beb642f92ea8b83cd610d8553d
Reviewed-by: Kentaro Hara <har...@chromium.org>
Reviewed-by: Mingjing Zhang <mjz...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567835}
Files:
- M third_party/blink/renderer/platform/peerconnection/rtc_video_encoder.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kentaro Hara, +1 by Mingjing Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages