MD Settings: Migrate cups_printers_list.html to settings-action-menu. (issue 2427323003 by dpapad@chromium.org)

4 views
Skip to first unread message

dpapad@chromium.org via codereview.chromium.org

unread,
Oct 19, 2016, 8:12:43 PM10/19/16
to michaelpg...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org, stev...@chromium.org
Reviewers: michaelpg
CL: https://codereview.chromium.org/2427323003/

Message:
FYI, I discovered an exception being thrown from the cups UI (even without my
CL), will file a bug about it (see exception at http://imgur.com/a/s6CuJ).

Description:
MD Settings: Migrate cups_printers_list.html to settings-action-menu.

BUG=639718,603976
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Affected files (+38, -24 lines):
M chrome/browser/resources/settings/printing_page/compiled_resources2.gyp
M chrome/browser/resources/settings/printing_page/cups_printers_list.html
M chrome/browser/resources/settings/printing_page/cups_printers_list.js


Index: chrome/browser/resources/settings/printing_page/compiled_resources2.gyp
diff --git a/chrome/browser/resources/settings/printing_page/compiled_resources2.gyp b/chrome/browser/resources/settings/printing_page/compiled_resources2.gyp
index 99685b7126fb1a3dada597474fdacde153749f7e..752fe45c978162b26059fbe3ec005842569f6b79 100644
--- a/chrome/browser/resources/settings/printing_page/compiled_resources2.gyp
+++ b/chrome/browser/resources/settings/printing_page/compiled_resources2.gyp
@@ -55,6 +55,7 @@
{
'target_name': 'cups_printers_list',
'dependencies': [
+ '../compiled_resources2.gyp:settings_action_menu',
'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:cr',
'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:icon',
'cups_printers_browser_proxy',
@@ -64,6 +65,7 @@
{
'target_name': 'printing_page',
'dependencies': [
+ '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',
'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:load_time_data',
'../compiled_resources2.gyp:route',
'../settings_page/compiled_resources2.gyp:settings_animated_pages',
Index: chrome/browser/resources/settings/printing_page/cups_printers_list.html
diff --git a/chrome/browser/resources/settings/printing_page/cups_printers_list.html b/chrome/browser/resources/settings/printing_page/cups_printers_list.html
index 077a0f47ec48ca5806740ca91aa892e944fd03b7..eb1423deb87c19e624121b8f72d49126cf36fc49 100644
--- a/chrome/browser/resources/settings/printing_page/cups_printers_list.html
+++ b/chrome/browser/resources/settings/printing_page/cups_printers_list.html
@@ -1,9 +1,9 @@
<link rel="import" href="chrome://resources/cr_elements/icons.html">
<link rel="import" href="chrome://resources/html/polymer.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-dropdown.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
<link rel="import" href="/printing_page/cups_printers_browser_proxy.html">
+<link rel="import" href="/settings_action_menu.html">
<link rel="import" href="/settings_shared_css.html">

<dom-module id="settings-cups-printers-list">
@@ -23,33 +23,25 @@
.list-item {
min-height: 20px;
}
-
- iron-dropdown {
- width: 120px;
- }
</style>

- <template is="dom-repeat" items="{{printers}}"
+ <dialog is="settings-action-menu">
+ <button class="dropdown-item" role="option" on-tap="onDetailsTap_">
+ $i18n{cupsPrinterDetails}
+ </button>
+ <button class="dropdown-item" role="option" on-tap="onRemoveTap_">
+ $i18n{removePrinter}
+ </button>
+ </dialog>
+ <template is="dom-repeat" items="[[printers]]"
filter="[[filterPrinter_(searchTerm)]]">
<div id="container" class="list-item">
<div class="name-column">
<span class="name" id="printer-name">[[item.printerName]]</span>
<!--TODO(xdai): Add icon for enterprise CUPS printer. -->
</div>
- <paper-icon-button icon="cr:more-vert" toggles
- active="{{item.menuOpened}}">
+ <paper-icon-button icon="cr:more-vert" on-tap="onDotsTap_">
</paper-icon-button>
- <iron-dropdown opened="{{item.menuOpened}}" horizontal-align="right"
- vertical-align="top" horizontal-offset="15" vertical-offset="5">
- <div class="dropdown-content">
- <paper-item on-tap="onDetailsTap_">
- $i18n{cupsPrinterDetails}
- </paper-item>
- <paper-item on-tap="onRemoveTap_">
- $i18n{removePrinter}
- </paper-item>
- <div>
- </iron-dropdown>
</div>
</template>
</template>
Index: chrome/browser/resources/settings/printing_page/cups_printers_list.js
diff --git a/chrome/browser/resources/settings/printing_page/cups_printers_list.js b/chrome/browser/resources/settings/printing_page/cups_printers_list.js
index 6364807697e375a5ddacf40486c771d430c9aecc..6fa74d004d28b2f5d5e9dac86e1cb04926c59b0c 100644
--- a/chrome/browser/resources/settings/printing_page/cups_printers_list.js
+++ b/chrome/browser/resources/settings/printing_page/cups_printers_list.js
@@ -19,6 +19,12 @@ Polymer({
searchTerm: {
type: String,
},
+
+ /**
+ * The model for the printer action menu.
+ * @private {?CupsPrinterInfo}
+ */
+ activePrinter_: Object,
},

/** @private {settings.CupsPrintersBrowserProxy} */
@@ -30,6 +36,18 @@ Polymer({
},

/**
+ * @param {{model: {item: !CupsPrinterInfo}}} e
+ * @private
+ */
+ onDotsTap_: function(e) {
+ this.activePrinter_ = /** @type {!CupsPrinterInfo} */ (e.model.item);
+ var menu = /** @type {!SettingsActionMenuElement} */ (
+ this.$$('dialog[is=settings-action-menu]'));
+ menu.showAt(/** @type {!Element} */ (
+ Polymer.dom(/** @type {!Event} */ (e)).localTarget));
+ },
+
+ /**
* @param {{model:Object}} event
* @private
*/
@@ -37,7 +55,7 @@ Polymer({
this.closeDropdownMenu_();

// Event is caught by 'settings-printing-page'.
- this.fire('show-cups-printer-details', event.model.item);
+ this.fire('show-cups-printer-details', this.activePrinter_);
},

/**
@@ -47,15 +65,17 @@ Polymer({
onRemoveTap_: function(event) {
this.closeDropdownMenu_();

- var index = this.printers.indexOf(event.model.item);
+ var index = this.printers.indexOf(assert(this.activePrinter_));
this.splice('printers', index, 1);
- this.browserProxy_.removeCupsPrinter(event.model.item.printerId,
- event.model.item.printerName);
+ this.browserProxy_.removeCupsPrinter(this.activePrinter_.printerId,
+ this.activePrinter_.printerName);
},

/** @private */
closeDropdownMenu_: function() {
- this.$$('iron-dropdown').close();
+ var menu = /** @type {!SettingsActionMenuElement} */ (
+ this.$$('dialog[is=settings-action-menu]'));
+ menu.close();
},

/**


stev...@chromium.org

unread,
Oct 19, 2016, 8:27:16 PM10/19/16
to dpa...@chromium.org, michaelpg...@chromium.org, xd...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org

stev...@chromium.org

unread,
Oct 19, 2016, 8:27:35 PM10/19/16
to dpa...@chromium.org, michaelpg...@chromium.org, xd...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org
On 2016/10/20 00:27:15, stevenjb wrote:
> lgtm
>
> +xdai@ FYI

Er, ignore unintentional "quick lgtm"


https://codereview.chromium.org/2427323003/

xd...@chromium.org

unread,
Oct 20, 2016, 12:51:09 PM10/20/16
to dpa...@chromium.org, michaelpg...@chromium.org, stev...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org
On 2016/10/20 00:27:34, stevenjb wrote:
> On 2016/10/20 00:27:15, stevenjb wrote:
> > lgtm
> >
> > +xdai@ FYI
>
> Er, ignore unintentional "quick lgtm"

dpapad@chromium.org via codereview.chromium.org

unread,
Oct 20, 2016, 1:53:45 PM10/20/16
to michaelpg...@chromium.org, xd...@chromium.org, stev...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org
On 2016/10/20 at 16:51:08, xdai wrote:
> On 2016/10/20 00:27:34, stevenjb wrote:
> > On 2016/10/20 00:27:15, stevenjb wrote:
> > > lgtm
> > >
> > > +xdai@ FYI
> >
> > Er, ignore unintentional "quick lgtm"
>
> lgtm

@Steven: Are you planning to review this, or should I consider xdai's LG
sufficient?

https://codereview.chromium.org/2427323003/

mich...@chromium.org

unread,
Oct 20, 2016, 2:00:40 PM10/20/16
to dpa...@chromium.org, xd...@chromium.org, stev...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html
File
chrome/browser/resources/settings/printing_page/cups_printers_list.html
(right):

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html#newcode27
chrome/browser/resources/settings/printing_page/cups_printers_list.html:27:
<dialog is="settings-action-menu">
how does this menu react when it's opened for Printer X, and a change
comes from Chrome which removes Printer X?

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html#newcode29
chrome/browser/resources/settings/printing_page/cups_printers_list.html:29:
$i18n{cupsPrinterDetails}
indents off

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html#newcode42
chrome/browser/resources/settings/printing_page/cups_printers_list.html:42:

<paper-icon-button icon="cr:more-vert" on-tap="onDotsTap_">
nit: name what the button is, not what it looks like

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.js
File
chrome/browser/resources/settings/printing_page/cups_printers_list.js
(right):

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.js#newcode39
chrome/browser/resources/settings/printing_page/cups_printers_list.js:39:

* @param {{model: {item: !CupsPrinterInfo}}} e
nit: more !s

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.js#newcode71
chrome/browser/resources/settings/printing_page/cups_printers_list.js:71:
this.activePrinter_.printerName);
maybe set this.activePrinter_ = null; so it's not referencing a
(soon-to-be) removed printer?

https://codereview.chromium.org/2427323003/

dpapad@chromium.org via codereview.chromium.org

unread,
Oct 20, 2016, 2:15:58 PM10/20/16
to michaelpg...@chromium.org, stev...@chromium.org, xd...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html
File
chrome/browser/resources/settings/printing_page/cups_printers_list.html
(right):

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html#newcode27
chrome/browser/resources/settings/printing_page/cups_printers_list.html:27:
<dialog is="settings-action-menu">
On 2016/10/20 at 18:00:39, michaelpg wrote:
> how does this menu react when it's opened for Printer X, and a change
comes from Chrome which removes Printer X?

This is not handled at the moment. I can move this dialog inside the
dom-repeat again, and wrap it with a lazy-render or dom-if. This way it
would be removed from the DOM when the dom-repeat updates. Or perhaps
there is a way to still have 1 action menu for N rows, and somehow
observe whether the current printer just got removed.

BTW, case you are describing probably breaks other such menus in our
codebase where we chosen to have 1 menu for N rows.


https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html#newcode29
chrome/browser/resources/settings/printing_page/cups_printers_list.html:29:
$i18n{cupsPrinterDetails}
On 2016/10/20 at 18:00:39, michaelpg wrote:
> indents off

Done.


https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html#newcode42
chrome/browser/resources/settings/printing_page/cups_printers_list.html:42:
<paper-icon-button icon="cr:more-vert" on-tap="onDotsTap_">
On 2016/10/20 at 18:00:39, michaelpg wrote:
> nit: name what the button is, not what it looks like



https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.js
File
chrome/browser/resources/settings/printing_page/cups_printers_list.js
(right):

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.js#newcode39
chrome/browser/resources/settings/printing_page/cups_printers_list.js:39:
* @param {{model: {item: !CupsPrinterInfo}}} e
On 2016/10/20 at 18:00:39, michaelpg wrote:
> nit: more !s

Done.


https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.js#newcode71
chrome/browser/resources/settings/printing_page/cups_printers_list.js:71:
this.activePrinter_.printerName);
On 2016/10/20 at 18:00:39, michaelpg wrote:
> maybe set this.activePrinter_ = null; so it's not referencing a
(soon-to-be) removed printer?

Updated closeDropdownMenu_ to set the activePrinter back to null, and
moved the calls at the end of onRemoveTap/onDetailsTap.

https://codereview.chromium.org/2427323003/

Steven Bennetts

unread,
Oct 20, 2016, 2:17:52 PM10/20/16
to Demetrios Papadopoulos, michaelpg...@chromium.org, stev...@chromium.org, xd...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org
I was planning to let michael and xdai@ do the review

mich...@chromium.org

unread,
Oct 20, 2016, 3:49:06 PM10/20/16
to dpa...@chromium.org, stev...@chromium.org, xd...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org
lgtm





https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html
File
chrome/browser/resources/settings/printing_page/cups_printers_list.html
(right):

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html#newcode27
chrome/browser/resources/settings/printing_page/cups_printers_list.html:27:
<dialog is="settings-action-menu">
On 2016/10/20 18:15:56, dpapad wrote:
> On 2016/10/20 at 18:00:39, michaelpg wrote:
> > how does this menu react when it's opened for Printer X, and a
change comes
> from Chrome which removes Printer X?
>
> This is not handled at the moment. I can move this dialog inside the
dom-repeat
> again, and wrap it with a lazy-render or dom-if. This way it would be
removed
> from the DOM when the dom-repeat updates. Or perhaps there is a way to
still
> have 1 action menu for N rows, and somehow observe whether the current
printer
> just got removed.

Would that cause a dom-if template to be created for each item? :-\

I think it's fine if we just call close() in the menu item handlers.

>
> BTW, case you are describing probably breaks other such menus in our
codebase
> where we chosen to have 1 menu for N rows.

I just checked, and you're right. Filed http://crbug.com/657970


https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html#newcode42
chrome/browser/resources/settings/printing_page/cups_printers_list.html:42:
<paper-icon-button icon="cr:more-vert" on-tap="onDotsTap_">
On 2016/10/20 18:15:56, dpapad wrote:
> On 2016/10/20 at 18:00:39, michaelpg wrote:
> > nit: name what the button is, not what it looks like
>
> OK, but
>
https://cs.chromium.org/search/?q=onDotsTap_&sq=package:chromium&type=cs.

Huh, ok then. Somehow I'd never seen it before.

https://codereview.chromium.org/2427323003/diff/80001/chrome/browser/resources/settings/printing_page/cups_printers_list.js
File
chrome/browser/resources/settings/printing_page/cups_printers_list.js
(right):

https://codereview.chromium.org/2427323003/diff/80001/chrome/browser/resources/settings/printing_page/cups_printers_list.js#newcode46
chrome/browser/resources/settings/printing_page/cups_printers_list.js:46:

menu.showAt(/** @type {!Element} */ (
why is this cast necessary? just to tell closure it's non-null?

https://codereview.chromium.org/2427323003/diff/80001/chrome/browser/resources/settings/printing_page/cups_printers_list.js#newcode58
chrome/browser/resources/settings/printing_page/cups_printers_list.js:58:

rm blank line

https://codereview.chromium.org/2427323003/

dpapad@chromium.org via chromiumcodereview-hr.appspot.com

unread,
Oct 20, 2016, 5:58:29 PM10/20/16
to michaelpg...@chromium.org, stev...@chromium.org, xd...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html
File
chrome/browser/resources/settings/printing_page/cups_printers_list.html
(right):

https://codereview.chromium.org/2427323003/diff/60001/chrome/browser/resources/settings/printing_page/cups_printers_list.html#newcode27
chrome/browser/resources/settings/printing_page/cups_printers_list.html:27:
<dialog is="settings-action-menu">
On 2016/10/20 at 19:49:05, michaelpg wrote:
> On 2016/10/20 18:15:56, dpapad wrote:
> > On 2016/10/20 at 18:00:39, michaelpg wrote:
> > > how does this menu react when it's opened for Printer X, and a
change comes
> > from Chrome which removes Printer X?
> >
> > This is not handled at the moment. I can move this dialog inside the
dom-repeat
> > again, and wrap it with a lazy-render or dom-if. This way it would
be removed
> > from the DOM when the dom-repeat updates. Or perhaps there is a way
to still
> > have 1 action menu for N rows, and somehow observe whether the
current printer
> > just got removed.
>
> Would that cause a dom-if template to be created for each item? :-\
>
> I think it's fine if we just call close() in the menu item handlers.
>
> >
> > BTW, case you are describing probably breaks other such menus in our
codebase
> > where we chosen to have 1 menu for N rows.
>
> I just checked, and you're right. Filed http://crbug.com/657970

Yes, it would cause a dom-if template node for each item. We already do
this for the certificate action menu, see
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html?l=35.
We do close the menu when an action happens, but don't bother removing
it from dom, we just use cr-lazy-render. So if you were to open 100
menus for 100 different items, the page would get gradually more
populated.


https://codereview.chromium.org/2427323003/diff/80001/chrome/browser/resources/settings/printing_page/cups_printers_list.js
File
chrome/browser/resources/settings/printing_page/cups_printers_list.js
(right):

https://codereview.chromium.org/2427323003/diff/80001/chrome/browser/resources/settings/printing_page/cups_printers_list.js#newcode46
chrome/browser/resources/settings/printing_page/cups_printers_list.js:46:
menu.showAt(/** @type {!Element} */ (
On 2016/10/20 at 19:49:06, michaelpg wrote:
> why is this cast necessary? just to tell closure it's non-null?

Correct.

https://codereview.chromium.org/2427323003/diff/80001/chrome/browser/resources/settings/printing_page/cups_printers_list.js#newcode58
chrome/browser/resources/settings/printing_page/cups_printers_list.js:58:

On 2016/10/20 at 19:49:06, michaelpg wrote:
> rm blank line

Done.

https://codereview.chromium.org/2427323003/

commit-bot@chromium.org via chromiumcodereview-hr.appspot.com

unread,
Oct 20, 2016, 6:59:58 PM10/20/16
to dpa...@chromium.org, michaelpg...@chromium.org, stev...@chromium.org, xd...@chromium.org, commi...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org

commit-bot@chromium.org via chromiumcodereview-hr.appspot.com

unread,
Oct 20, 2016, 9:17:07 PM10/20/16
to dpa...@chromium.org, michaelpg...@chromium.org, stev...@chromium.org, xd...@chromium.org, commi...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org
Committed patchset #6 (id:100001)

https://codereview.chromium.org/2427323003/

commit-bot@chromium.org via chromiumcodereview-hr.appspot.com

unread,
Oct 21, 2016, 9:33:38 AM10/21/16
to dpa...@chromium.org, michaelpg...@chromium.org, stev...@chromium.org, xd...@chromium.org, commi...@chromium.org, arv+...@chromium.org, chromium...@chromium.org, dbeam+watc...@chromium.org, dbeam+wat...@chromium.org, jlklein+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, stevenjb+watc...@chromium.org, vitalyp...@chromium.org
Patchset 6 (id:??) landed as
https://crrev.com/3188c5dbeaac9424446fb392f02756cb4374f9f3
Cr-Commit-Position: refs/heads/master@{#426672}

https://codereview.chromium.org/2427323003/
Reply all
Reply to author
Forward
0 new messages