Revert "Reland "Add a client-side decorated frame view for non-browser widgets on Linux"" [chromium/src : main]

[luci-bisection@appspot.gserviceaccount.com (Gerrit)]

Attention needed from Athul Iddya, Thomas Anderson and Thomas Lukaszewicz

luci-bi...@appspot.gserviceaccount.com has uploaded the change for review

luci-bi...@appspot.gserviceaccount.com would like Athul Iddya, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Thomas Anderson and Thomas Lukaszewicz to review this change.

Commit message

Revert "Reland "Add a client-side decorated frame view for non-browser widgets on Linux""

This reverts commit 74d069bb0c7eebbdb6871398db76566b8921b230.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5684550224052224

Sample build with failed test: https://ci.chromium.org/b/8684567635765834513
Affected test(s):
[://ui/views\:views_unittests!gtest::DesktopWindowTreeHostPlatformTest#UpdateWindowShapeFromWindowMask](https://ci.chromium.org/ui/test/chromium/:%2F%2Fui%2Fviews%5C:views_unittests%21gtest::DesktopWindowTreeHostPlatformTest%23UpdateWindowShapeFromWindowMask?q=VHash%3Aadeafd3586039903)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5684550224052224&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7744360&type=BUG

Original change's description:
> Reland "Add a client-side decorated frame view for non-browser widgets on Linux"
>
> This is a reland of commit e514a815751a98f257a5587deb6e6424dc24f271
>
> The original change used a views::Label for the window title, which
> caused a duplicate NAME-CHANGED accessibility event to be emitted on
> window title changes. FrameViewLinux now paints the window title text
> on the frame, matching DefaultFrameView's approach.
>
> Original change's description:
> > Add a client-side decorated frame view for non-browser widgets on Linux
> >
> > Non-browser widgets like Profile Picker and Task Manager do not get
> > native decorations on Wayland compositors that don't support server-side
> > decorations, and they fall back to DefaultFrameView. Browser widgets
> > have BrowserFrameViewLinux for toolkit-independent decorations and
> > BrowserFrameViewLinuxNative for toolkit-native drawing.
> >
> > A new view class called FrameViewLinux has been created in ui/views to
> > close this gap. This class re-implements similar logic to
> > BrowserFrameViewLinux, using Material Design styling to draw the window
> > frame, controls, and shadows. Shared logic between FrameViewLinux and
> > BrowserFrameViewLinux has been split off as utilities in
> > frame_view_utils_linux.
> >
> > FrameViewLayoutLinux handles layout of the caption buttons, title bar,
> > and client view. It is designed as an extensible base class with virtual
> > methods for frame geometry, button sizing, and layout, allowing
> > subclasses to provide native toolkit integration.
> >
> > DesktopWindowTreeHostLinux has been updated to handle native theme
> > observation and the additional responsibilities of frame insets and
> > region calculations for FrameViewLinux classes. The compositor window
> > menu has been added as a fallback when a frame lacks a context menu.
> >
> > Bug: 40275440
> > Change-Id: Id1d1fb03a6dc16ec11b2590b75a915479d22919f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7709824
> > Auto-Submit: Athul Iddya <at...@iddya.com>
> > Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
> > Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>
> > Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1612202}
>
> Bug: 40275440
> Change-Id: I65d74eed6b2782569d445a3d4ab40f7f74576b68
> Cq-Include-Trybots: luci.chromium.try:linux-wayland-mutter-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7744360
> Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
> Auto-Submit: Athul Iddya <at...@iddya.com>
> Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
> Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1614228}
>

Bug: 40275440

No-Presubmit: true

No-Tree-Checks: true

No-Try: true

Change-Id: Id70c946131d40931a081e3e0ebb1a53d6d24f017

Change diff

Change information

Files:

• M chrome/browser/ui/BUILD.gn
• M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_linux.cc
• M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_linux.h
• M chrome/browser/ui/views/frame/browser_frame_view_layout_linux.cc
• M chrome/browser/ui/views/frame/browser_frame_view_layout_linux_native.cc
• M chrome/browser/ui/views/frame/browser_frame_view_linux.cc
• A chrome/browser/ui/views/frame/browser_frame_view_paint_utils_linux.cc
• A chrome/browser/ui/views/frame/browser_frame_view_paint_utils_linux.h
• M chrome/browser/ui/views/frame/picture_in_picture_browser_frame_view_linux.cc
• M ui/color/color_id.h
• M ui/color/ui_color_mixer.cc
• M ui/gtk/gtk_color_mixers.cc
• M ui/views/BUILD.gn
• M ui/views/widget/desktop_aura/desktop_window_tree_host_linux.cc
• M ui/views/widget/desktop_aura/desktop_window_tree_host_linux.h
• M ui/views/widget/desktop_aura/window_event_filter_linux.cc
• D ui/views/window/frame_view_layout_linux.cc
• D ui/views/window/frame_view_layout_linux.h
• D ui/views/window/frame_view_linux.cc
• D ui/views/window/frame_view_linux.h
• D ui/views/window/frame_view_linux_unittest.cc
• D ui/views/window/frame_view_utils_linux.cc
• D ui/views/window/frame_view_utils_linux.h

Change size: XL

Delta: 23 files changed, 264 insertions(+), 1989 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Athul Iddya
• Thomas Anderson
• Thomas Lukaszewicz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id70c946131d40931a081e3e0ebb1a53d6d24f017

Gerrit-Change-Number: 7759632

Gerrit-PatchSet: 1

Gerrit-Owner: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Gerrit-Reviewer: Athul Iddya <at...@iddya.com>

Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>

Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>

Gerrit-CC: Mitchell Cohen <mitc...@agilebits.com>

Gerrit-CC: Robert Liao <rob...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Athul Iddya <at...@iddya.com>

Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>

Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>

[luci-bisection@appspot.gserviceaccount.com (Gerrit)]

Attention needed from Athul Iddya, Michael Ershov, Thomas Anderson and Thomas Lukaszewicz

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.

Open in Gerrit

Related details

Attention is currently required from:

• Athul Iddya
• Michael Ershov
• Thomas Anderson
• Thomas Lukaszewicz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id70c946131d40931a081e3e0ebb1a53d6d24f017

Gerrit-Change-Number: 7759632

Gerrit-PatchSet: 1

Gerrit-Owner: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Gerrit-Reviewer: Athul Iddya <at...@iddya.com>

Gerrit-Reviewer: Michael Ershov <mie...@google.com>

Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>

Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>

Gerrit-CC: Mitchell Cohen <mitc...@agilebits.com>

Gerrit-CC: Robert Liao <rob...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Athul Iddya <at...@iddya.com>

Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>

Gerrit-Attention: Michael Ershov <mie...@google.com>

Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Comment-Date: Tue, 14 Apr 2026 07:34:13 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[rubber-stamper@appspot.gserviceaccount.com (Gerrit)]

Attention needed from Athul Iddya, Michael Ershov, Thomas Anderson and Thomas Lukaszewicz

rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1

Bot-Commit

+1

Open in Gerrit

Related details

Attention is currently required from:

• Athul Iddya
• Michael Ershov
• Thomas Anderson
• Thomas Lukaszewicz

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Gerrit-Comment-Date: Tue, 14 Apr 2026 07:35:09 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Michael Ershov (Gerrit)]

Attention needed from Athul Iddya, Thomas Anderson and Thomas Lukaszewicz

Michael Ershov voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Athul Iddya
• Thomas Anderson
• Thomas Lukaszewicz

Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Comment-Date: Tue, 14 Apr 2026 08:25:51 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Michael Ershov (Gerrit)]

Attention needed from Athul Iddya, Thomas Anderson and Thomas Lukaszewicz

Michael Ershov voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

• Athul Iddya
• Thomas Anderson
• Thomas Lukaszewicz

Submit Requirements:

• Code-Coverage
• Code-Owners

Gerrit-Comment-Date: Tue, 14 Apr 2026 08:25:59 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Michael Ershov (Gerrit)]

Attention needed from Athul Iddya, Thomas Anderson and Thomas Lukaszewicz

Michael Ershov voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Tue, 14 Apr 2026 08:39:55 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)]

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7759632

Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Owners-Override: Michael Ershov <mie...@google.com>

Commit-Queue: Michael Ershov <mie...@google.com>

Cr-Commit-Position: refs/heads/main@{#1614314}

Branch: refs/heads/main

Submit Requirements:

• Code-Review: Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id70c946131d40931a081e3e0ebb1a53d6d24f017

Gerrit-Change-Number: 7759632

Gerrit-PatchSet: 2