Restore middle click new tab button functionality (Linux) [chromium/src : main]

[Kaan Alsan (Gerrit)]

Attention needed from Alison Gale, Erik Chen and Michael Stapelberg

Kaan Alsan added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Kaan Alsan . resolved

LGTM from a technical perspective, but I don't have enough context into why it was originally removed, so I'll wait for agale@ before giving the +1.

Open in Gerrit

Related details

Attention is currently required from:

• Alison Gale
• Erik Chen
• Michael Stapelberg

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I587ab67e961936382e4cbe7e8304ef94a565fd0e

Gerrit-Change-Number: 7368605

Gerrit-PatchSet: 1

Gerrit-Owner: Michael Stapelberg <stape...@google.com>

Gerrit-Reviewer: Alison Gale <ag...@chromium.org>

Gerrit-Reviewer: Erik Chen <erik...@chromium.org>

Gerrit-Reviewer: Kaan Alsan <al...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Erik Chen <erik...@chromium.org>

Gerrit-Attention: Alison Gale <ag...@chromium.org>

Gerrit-Attention: Michael Stapelberg <stape...@google.com>

Gerrit-Comment-Date: Mon, 05 Jan 2026 14:12:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Erik Chen (Gerrit)]

Attention needed from Alison Gale and Michael Stapelberg

Erik Chen added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Erik Chen . unresolved

the tab strip is being rewritten and we were not planning on support this functionality in the rewrite. We will discuss the feedback internally.

Open in Gerrit

Related details

Attention is currently required from:

• Alison Gale
• Michael Stapelberg

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I587ab67e961936382e4cbe7e8304ef94a565fd0e

Gerrit-Change-Number: 7368605

Gerrit-PatchSet: 1

Gerrit-Owner: Michael Stapelberg <stape...@google.com>

Gerrit-Reviewer: Alison Gale <ag...@chromium.org>

Gerrit-Reviewer: Erik Chen <erik...@chromium.org>

Gerrit-Reviewer: Kaan Alsan <al...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Alison Gale <ag...@chromium.org>

Gerrit-Attention: Michael Stapelberg <stape...@google.com>

Gerrit-Comment-Date: Mon, 05 Jan 2026 18:09:08 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Alison Gale (Gerrit)]

Attention needed from Michael Stapelberg

Alison Gale added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Erik Chen . unresolved

the tab strip is being rewritten and we were not planning on support this functionality in the rewrite. We will discuss the feedback internally.

Alison Gale

Removing myself from the attention set pending discussion with leads

Open in Gerrit

Related details

Attention is currently required from:

• Michael Stapelberg

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I587ab67e961936382e4cbe7e8304ef94a565fd0e

Gerrit-Change-Number: 7368605

Gerrit-PatchSet: 1

Gerrit-Owner: Michael Stapelberg <stape...@google.com>

Gerrit-Reviewer: Alison Gale <ag...@chromium.org>

Gerrit-Reviewer: Erik Chen <erik...@chromium.org>

Gerrit-Reviewer: Kaan Alsan <al...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Michael Stapelberg <stape...@google.com>

Gerrit-Comment-Date: Wed, 07 Jan 2026 18:24:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Erik Chen <erik...@chromium.org>

[Alison Gale (Gerrit)]

Attention needed from Erik Chen and Michael Stapelberg

Alison Gale voted and added 3 comments

Votes added by Alison Gale

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Erik Chen . resolved

the tab strip is being rewritten and we were not planning on support this functionality in the rewrite. We will discuss the feedback internally.

Alison Gale

Removing myself from the attention set pending discussion with leads

Alison Gale

After more discussion with leads, we decided to move forward with this change with the addition of metrics that will allow us to understand the usage of this feature. I"ll go ahead and resolve this comment but you can move foward with this CL after resolving merge conflicts. Thanks for your patience.

File chrome/browser/ui/views/frame/horizontal_tab_strip_region_view.cc

Line 300, Patchset 1 (Latest): // The New Tab Button can be middle-clicked on Linux.

Alison Gale . unresolved

Can you add details about what middle click on Linux is used for (paste and navigate)

File chrome/browser/ui/views/tabs/tab_strip.cc

Line 2272, Patchset 1 (Latest): controller_->CreateNewTabWithLocation(clipboard_text);

Alison Gale . unresolved

Can you add a user action log here:
```
base::RecordAction(base::UserMetricsAction("NewTabButton_PasteAndNavigate"));
```

Open in Gerrit

Related details

Attention is currently required from:

• Erik Chen
• Michael Stapelberg

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I587ab67e961936382e4cbe7e8304ef94a565fd0e

Gerrit-Change-Number: 7368605

Gerrit-PatchSet: 1

Gerrit-Owner: Michael Stapelberg <stape...@google.com>

Gerrit-Reviewer: Alison Gale <ag...@chromium.org>

Gerrit-Reviewer: Erik Chen <erik...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Erik Chen <erik...@chromium.org>

Gerrit-Attention: Michael Stapelberg <stape...@google.com>

Gerrit-Comment-Date: Tue, 24 Mar 2026 14:44:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Erik Chen <erik...@chromium.org>

Comment-In-Reply-To: Alison Gale <ag...@chromium.org>

[Michael Stapelberg (Gerrit)]

Attention needed from Erik Chen

Michael Stapelberg added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Michael Stapelberg . unresolved

Thanks! I will rebase and update the CL per your comments ASAP; hopefully within the next 24 hours.

Open in Gerrit

Related details

Attention is currently required from:

• Erik Chen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I587ab67e961936382e4cbe7e8304ef94a565fd0e

Gerrit-Change-Number: 7368605

Gerrit-PatchSet: 1

Gerrit-Owner: Michael Stapelberg <stape...@google.com>

Gerrit-Reviewer: Alison Gale <ag...@chromium.org>

Gerrit-Reviewer: Erik Chen <erik...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Erik Chen <erik...@chromium.org>

Gerrit-Comment-Date: Tue, 24 Mar 2026 14:46:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Erik Chen (Gerrit)]

Attention needed from Michael Stapelberg

Erik Chen added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Erik Chen . resolved

Thanks Alison and Michael for following up!

Open in Gerrit

Related details

Attention is currently required from:

• Michael Stapelberg

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I587ab67e961936382e4cbe7e8304ef94a565fd0e

Gerrit-Change-Number: 7368605

Gerrit-PatchSet: 1

Gerrit-Owner: Michael Stapelberg <stape...@google.com>

Gerrit-Reviewer: Alison Gale <ag...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Michael Stapelberg <stape...@google.com>

Gerrit-Comment-Date: Tue, 24 Mar 2026 15:26:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Alison Gale (Gerrit)]

Attention needed from Caroline Rising and Michael Stapelberg

Alison Gale added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Michael Stapelberg . unresolved

Thanks! I will rebase and update the CL per your comments ASAP; hopefully within the next 24 hours.

Alison Gale

I'm OOO for the next week so adding someone else on my team as a reviewer for any additional approvals needed

Open in Gerrit

Related details

Attention is currently required from:

• Caroline Rising
• Michael Stapelberg

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I587ab67e961936382e4cbe7e8304ef94a565fd0e

Gerrit-Change-Number: 7368605

Gerrit-PatchSet: 1

Gerrit-Owner: Michael Stapelberg <stape...@google.com>

Gerrit-Reviewer: Alison Gale <ag...@chromium.org>

Gerrit-Reviewer: Caroline Rising <cori...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Caroline Rising <cori...@chromium.org>

Gerrit-Attention: Michael Stapelberg <stape...@google.com>

Gerrit-Comment-Date: Tue, 24 Mar 2026 17:45:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Michael Stapelberg <stape...@google.com>

[Michael Stapelberg (Gerrit)]

Attention needed from Alison Gale

Michael Stapelberg added 2 comments

File chrome/browser/ui/views/frame/horizontal_tab_strip_region_view.cc

Line 300, Patchset 1: // The New Tab Button can be middle-clicked on Linux.

Alison Gale . resolved

Can you add details about what middle click on Linux is used for (paste and navigate)

Michael Stapelberg

Done

File chrome/browser/ui/views/tabs/tab_strip.cc

Line 2272, Patchset 1: controller_->CreateNewTabWithLocation(clipboard_text);

Alison Gale . resolved

Can you add a user action log here:
```
base::RecordAction(base::UserMetricsAction("NewTabButton_PasteAndNavigate"));
```

Michael Stapelberg

Done, and verified it shows up in chrome://user-actions.

Open in Gerrit

Related details

Attention is currently required from:

• Alison Gale

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I587ab67e961936382e4cbe7e8304ef94a565fd0e

Gerrit-Change-Number: 7368605

Gerrit-PatchSet: 2

Gerrit-Owner: Michael Stapelberg <stape...@google.com>

Gerrit-Reviewer: Alison Gale <ag...@chromium.org>

Gerrit-Reviewer: Caroline Rising <cori...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Alison Gale <ag...@chromium.org>

Gerrit-Comment-Date: Wed, 25 Mar 2026 00:43:34 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Alison Gale <ag...@chromium.org>

[Michael Stapelberg (Gerrit)]

Attention needed from Alison Gale and Caroline Rising

Michael Stapelberg voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Alison Gale
• Caroline Rising

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I587ab67e961936382e4cbe7e8304ef94a565fd0e

Gerrit-Change-Number: 7368605

Gerrit-PatchSet: 2

Gerrit-Owner: Michael Stapelberg <stape...@google.com>

Gerrit-Reviewer: Alison Gale <ag...@chromium.org>

Gerrit-Reviewer: Caroline Rising <cori...@chromium.org>

Gerrit-Reviewer: Michael Stapelberg <stape...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Caroline Rising <cori...@chromium.org>

Gerrit-Attention: Alison Gale <ag...@chromium.org>

Gerrit-Comment-Date: Wed, 25 Mar 2026 00:44:02 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes