Use absl::flat_hash_map in url_template [chromium/src : main]
0 views
Skip to first unread message
Adam Rice (Gerrit)
Jun 17, 2026, 7:21:15 AM (10 days ago) Jun 17
to Yoichi Osato, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
Attention needed from Yoichi Osato
Adam Rice voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Yoichi Osato
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoichi Osato (Gerrit)
Jun 18, 2026, 12:53:33 AM (9 days ago) Jun 18
to Adam Rice, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
Attention needed from Adam Rice
Yoichi Osato voted![]( "Open in Gerrit")
Attention is currently required from:
- Adam Rice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2026, 12:58:55 AM (9 days ago) Jun 18
to Adam Rice, Yoichi Osato, chromium...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use absl::flat_hash_map in url_template
Replace use of std::unordered_map with absl::flat_hash_map in the
parameters of url_template::Expand(). This reduces CPU and memory usage.
The choice of absl::flat_hash_map rather than base::flat_map was because
QUICHE already uses absl::flat_hash_map for this purpose so it avoids
a container conversion.
Remove "using std::string" from header file url_template.h. It causes
namespace pollution and is a style guide violation.
Change-Id: Iedd15a34404d19f3b74244b44f3147728160ba39
Commit-Queue: Yoichi Osato <yoi...@chromium.org>
Reviewed-by: Yoichi Osato <yoi...@chromium.org>
Auto-Submit: Adam Rice <ri...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648799}
Files:
- M net/dns/dns_http_attempt.cc
- M net/dns/dns_transaction_unittest.cc
- M net/dns/dns_util.cc
- M net/dns/filtering_details_url_generator.cc
- M net/dns/public/dns_over_https_server_config.cc
- M net/third_party/quiche/overrides/quiche_platform_impl/quiche_url_utils_impl.cc
- M net/third_party/uri_template/uri_template.cc
- M net/third_party/uri_template/uri_template.h
- M net/third_party/uri_template/uri_template_fuzzer.cc
- M net/third_party/uri_template/uri_template_test.cc
Change size: M
Delta: 10 files changed, 24 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yoichi Osato
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages