Enum-ify ZhuyinPageSize in CrOS 1P IME Settings. [chromium/src : main]
0 views
Skip to first unread message
Bao-Duy Tran (Gerrit)
Jan 12, 2026, 4:07:01 AM (2 days ago) Jan 12
to Michael Cui, John Palmer, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, mlcui+watch-os-s...@google.com
Attention needed from John Palmer and Michael Cui
Bao-Duy Tran voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- John Palmer
- Michael Cui
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Cui (Gerrit)
Jan 12, 2026, 5:56:52 PM (2 days ago) Jan 12
to Bao-Duy Tran, Michael Cui, John Palmer, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, mlcui+watch-os-s...@google.com
Attention needed from Bao-Duy Tran and John Palmer
Michael Cui voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Cui
| Code-Review | +1 |
1 comment
Commit Message
Line 15, Patchset 8 (Latest):
mirror persisted CrOS-Prefs verbatim, but declares integer type [3]. This precariously works, as all enum string values happen to be
integer-like & cast-able to integer. VK+IME ext still reads the
value as string 1st then DIY cast back to number. We'll leave this private API intact for now.Michael Cui . unresolved
nit: Wrap to 72 columns.
Related details
Attention is currently required from:
- Bao-Duy Tran
- John Palmer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bao-Duy Tran (Gerrit)
Jan 12, 2026, 7:55:19 PM (2 days ago) Jan 12
to Michael Cui, John Palmer, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, mlcui+watch-os-s...@google.com
Attention needed from John Palmer
Bao-Duy Tran added 1 comment![]( "Open in Gerrit")
Commit Message
Line 15, Patchset 8:
mirror persisted CrOS-Prefs verbatim, but declares integer type [3]. This precariously works, as all enum string values happen to be
integer-like & cast-able to integer. VK+IME ext still reads the
value as string 1st then DIY cast back to number. We'll leave this private API intact for now.Michael Cui . resolved
nit: Wrap to 72 columns.
Attention is currently required from:
- John Palmer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
John Palmer (Gerrit)
12:16 AM (3 hours ago) 12:16 AM
to Bao-Duy Tran, Michael Cui, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, mlcui+watch-os-s...@google.com
Attention needed from Bao-Duy Tran
John Palmer voted and added 1 comment![]( "Open in Gerrit")
Votes added by John Palmer
| Code-Review | +1 |
1 comment
File chrome/browser/resources/ash/settings/os_languages_page/input_method_options_page.ts
Line 377, Patchset 9 (Latest):
private dependentOptionsDisabled_(value: OptionValue|string): boolean {John Palmer . unresolved
I am surprised this is needed - I think optionvalue should include string (or maybe it only includes the consts?)
Related details
Attention is currently required from:
- Bao-Duy Tran
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bao-Duy Tran (Gerrit)
12:24 AM (3 hours ago) 12:24 AM
to John Palmer, Michael Cui, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, mlcui+watch-os-s...@google.com
Bao-Duy Tran added 1 comment![]( "Open in Gerrit")
File chrome/browser/resources/ash/settings/os_languages_page/input_method_options_page.ts
Line 377, Patchset 9 (Latest):
private dependentOptionsDisabled_(value: OptionValue|string): boolean {John Palmer . resolved
I am surprised this is needed - I think optionvalue should include string (or maybe it only includes the consts?)
Bao-Duy Tran
OptionValue is defined as the (union of the) types seen in OPTION_DEFAULT (see line 43), which now only includes those string enums (not general strings) and booleans and numbers. I could've removed "value === '0'" here, but didn't want to disturb stuff, esp. given the mysterious-sounding TODO comments here.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bao-Duy Tran (Gerrit)
3:15 AM (2 minutes ago) 3:15 AM
to John Palmer, Michael Cui, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, mlcui+watch-os-s...@google.com
Bao-Duy Tran voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages