Giovanni Pezzino (Gerrit)

unread,

Jan 8, 2026, 9:31:34 AM (6 days ago) Jan 8

to Devlin Cronin, David Yeung, Oleg Davydov, Chromium LUCI CQ, Simon Hangl, Rubber Stamper, AyeAye, Justin Lulejian, Code Review Nudger, chromeos-commercial-readability-c-reviewers+reviews, chromium...@chromium.org

Attention needed from David Yeung, David Yeung, Devlin Cronin, Oleg Davydov and Simon Hangl

Giovanni Pezzino has uploaded the change for review

Giovanni Pezzino would like Devlin Cronin, David Yeung, Oleg Davydov, Chromium LUCI CQ, Simon Hangl, David Yeung and Rubber Stamper to review this change.

Commit message

Reland "Force the update of corrupted extensions."

This reverts commit 1c94bad1e6507cb40eebd8e07c44b5f6afbfc230.

Reason for revert: The broken test is now fixed.

Original change's description:
> Revert "Force the update of corrupted extensions."
>
> This reverts commit ecdd40c9ab12b9df2ac1e09302ac95e7eb4627d5.
>
> Reason for revert: Caused a regression in SingleClientExtensionAppsSyncTest.InstallSomeApps
> See
> https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/60857/test-results
>
> Original change's description:
> > Force the update of corrupted extensions.
> >
> > Rebooting a device with Refresh+Power results in the
> > computed_hashes.json file being truncated to 0 bytes length. The next
> > time the extension is loaded, the contents verification fails and the
> > extension is marked as corrupted and disabled. The extension update flow
> > will try and reinstall the extension, but it fails as the version of the
> > corrupted extension and the version of the to-be-installed extension
> > are the same. This CL modifies the update logic so that same version
> > updates are allowed when the update is caused by a detected corruption.
> >
> > Bug: 301307156, 395009770, 396458740
> > Change-Id: I116f53b79c6d94d98c7f2781c067cb6af285953c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6830426
> > Reviewed-by: Oleg Davydov <buru...@chromium.org>
> > Auto-Submit: Giovanni Pezzino <gio...@google.com>
> > Reviewed-by: Devlin Cronin <rdevlin...@chromium.org>
> > Reviewed-by: Simon Hangl <sim...@google.com>
> > Commit-Queue: Devlin Cronin <rdevlin...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1563199}
>
> Bug: 301307156, 395009770, 396458740
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Ief248898fbfb3675be63e34b85b0a962d02caf9c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7354774
> Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Owners-Override: David Yeung <day...@google.com>
> Commit-Queue: David Yeung <day...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1563260}

Bug: 301307156, 395009770, 396458740

Change-Id: I9ce00a04a5d32ed233512ee2cabfb6f241cea5d8

Change diff

Change information

Files:

M chrome/browser/extensions/updater/extension_updater.cc
M chrome/browser/extensions/updater/extension_updater.h
M chrome/browser/extensions/updater/update_service_browsertest.cc
M extensions/browser/extension_protocols.cc
M extensions/browser/updater/extension_downloader.cc
M extensions/browser/updater/extension_downloader.h

Change size: M

Delta: 6 files changed, 77 insertions(+), 40 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

David Yeung
David Yeung
Devlin Cronin
Oleg Davydov
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rubber Stamper (Gerrit)

unread,

Jan 8, 2026, 9:32:21 AM (6 days ago) Jan 8

to Giovanni Pezzino, Devlin Cronin, David Yeung, Oleg Davydov, Chromium LUCI CQ, Simon Hangl, AyeAye, Justin Lulejian, Code Review Nudger, chromeos-commercial-readability-c-reviewers+reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from David Yeung, David Yeung, Devlin Cronin, Oleg Davydov and Simon Hangl

Rubber Stamper voted Bot-Commit+1

Bot-Commit

+1

Open in Gerrit

Related details

Attention is currently required from:

David Yeung
David Yeung
Devlin Cronin
Oleg Davydov
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rubber Stamper (Gerrit)

unread,

Jan 8, 2026, 10:02:06 AM (6 days ago) Jan 8

to chromium...@chromium.org

Attention needed from David Yeung, David Yeung, Devlin Cronin, Oleg Davydov and Simon Hangl

Message from Rubber Stamper

Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.

Open in Gerrit

Related details

Attention is currently required from:

David Yeung
David Yeung
Devlin Cronin
Oleg Davydov
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Giovanni Pezzino (Gerrit)

unread,

Jan 8, 2026, 10:06:04 AM (6 days ago) Jan 8

to Devlin Cronin, David Yeung, Oleg Davydov, Chromium LUCI CQ, Simon Hangl, AyeAye, Justin Lulejian, Code Review Nudger, chromeos-commercial-readability-c-reviewers+reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from David Yeung, David Yeung, Devlin Cronin, Oleg Davydov and Simon Hangl

Giovanni Pezzino added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Giovanni Pezzino . resolved

Devlin, PTAL.

Patchset 2 includes the new check in extension_protocols.cc to make the broken test pass. I could not use the IsShuttingDown() method as we discussed, as it returned false.

satisfied_requirement

unsatisfied_requirement

open

diffy

Devlin Cronin (Gerrit)

unread,

Jan 8, 2026, 2:01:33 PM (6 days ago) Jan 8

to Giovanni Pezzino, Devlin Cronin, Oleg Davydov, Chromium LUCI CQ, Simon Hangl, AyeAye, Justin Lulejian, Code Review Nudger, chromeos-commercial-readability-c-reviewers+reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from David Yeung, Giovanni Pezzino, Oleg Davydov and Simon Hangl

Devlin Cronin added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Devlin Cronin . resolved

Thanks, Gio! The new check seems conceptually correct, but it looks like there are failing tests?

Open in Gerrit

Related details

Attention is currently required from:

David Yeung
Giovanni Pezzino
Oleg Davydov
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Simon Hangl (Gerrit)

unread,

Jan 9, 2026, 11:39:54 AM (5 days ago) Jan 9

to Giovanni Pezzino, Devlin Cronin, Oleg Davydov, Chromium LUCI CQ, AyeAye, Justin Lulejian, Code Review Nudger, chromeos-commercial-readability-c-reviewers+reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from David Yeung, Giovanni Pezzino and Oleg Davydov

Simon Hangl voted and added 1 comment

Votes added by Simon Hangl

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Simon Hangl . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

David Yeung
Giovanni Pezzino
Oleg Davydov

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Giovanni Pezzino (Gerrit)

unread,

Jan 13, 2026, 11:42:50 AM (16 hours ago) Jan 13

to Hidehiko Abe, Simon Hangl, Devlin Cronin, Oleg Davydov, Chromium LUCI CQ, AyeAye, Justin Lulejian, Code Review Nudger, chromeos-commercial-readability-c-reviewers+reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from David Yeung, Hidehiko Abe and Oleg Davydov

Giovanni Pezzino added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Giovanni Pezzino . resolved

Hi Hidehiko,
could you PTAL at the change to the single_client_extension_apps_sync_test.cc file?

I have still some ongoing discussions with Devlin about the approach, so there is no ush for this 😊

Open in Gerrit

Related details

Attention is currently required from:

David Yeung
Hidehiko Abe
Oleg Davydov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hidehiko Abe (Gerrit)

unread,

12:42 AM (3 hours ago) 12:42 AM

to Giovanni Pezzino, Simon Hangl, Devlin Cronin, Oleg Davydov, Chromium LUCI CQ, AyeAye, Justin Lulejian, Code Review Nudger, chromeos-commercial-readability-c-reviewers+reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from David Yeung, Giovanni Pezzino and Oleg Davydov

Hidehiko Abe added 2 comments

File chrome/browser/sync/test/integration/single_client_extension_apps_sync_test.cc

Line 148, Patchset 3 (Latest): extensions::SetShouldVerifyContentOverrideForTesting(false);

Hidehiko Abe . unresolved

could you document why this is needed?

File extensions/browser/extension_protocols.cc

Line 518, Patchset 3 (Latest):static std::optional<bool> should_verify_content_override_for_testing =

Hidehiko Abe . unresolved

could you use anonymous namespace?

Open in Gerrit

Related details

Attention is currently required from:

David Yeung
Giovanni Pezzino
Oleg Davydov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Reland "Force the update of corrupted extensions." [chromium/src : main]

Giovanni Pezzino (Gerrit)

Giovanni Pezzino has uploaded the change for review

Commit message

Change diff

Change information

Related details

Rubber Stamper (Gerrit)

Rubber Stamper voted Bot-Commit+1

Related details

Rubber Stamper (Gerrit)

Message from Rubber Stamper

Related details

Giovanni Pezzino (Gerrit)

Giovanni Pezzino added 1 comment

Devlin Cronin (Gerrit)

Devlin Cronin added 1 comment

Related details

Simon Hangl (Gerrit)

Simon Hangl voted and added 1 comment

Votes added by Simon Hangl

1 comment

Related details

Giovanni Pezzino (Gerrit)

Giovanni Pezzino added 1 comment

Related details

Hidehiko Abe (Gerrit)

Hidehiko Abe added 2 comments

Related details