[WebUI] Register ThemeSource explicitly, part 8. [chromium/src : main]

[Tommy Nyquist (Gerrit)]

Attention needed from Mickey Burks

Tommy Nyquist voted and added 2 comments

Votes added by Tommy Nyquist

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Tommy Nyquist . resolved

lgtm

File chrome/browser/glic/experimental_opt_in/glic_experimental_opt_in_ui.cc

Line 92, Patchset 1 (Latest): content::URLDataSource::Add(profile, std::make_unique<ThemeSource>(profile));

Tommy Nyquist . unresolved

Nit: since `content::URLDataSource::Add` is used directly here, perhaps we should also add `#include "content/public/browser/url_data_source.h"` rather than relying on the transitive include from `theme_source.h`. That would match the pattern from the earlier parts of this series (e.g. `chrome_file_manager_ui_delegate.cc` in part 4) and the existing registration in `chrome/browser/glic/host/glic_ui.cc`.

Open in Gerrit

Related details

Attention is currently required from:

• Mickey Burks

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iebf49940143702966d1b9659fdd0eb049d0cb58a

Gerrit-Change-Number: 8104772

Gerrit-PatchSet: 1

Gerrit-Owner: Mickey Burks <micke...@chromium.org>

Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mickey Burks <micke...@chromium.org>

Gerrit-Comment-Date: Fri, 17 Jul 2026 07:01:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Mickey Burks (Gerrit)]

Mickey Burks added 1 comment

File chrome/browser/glic/experimental_opt_in/glic_experimental_opt_in_ui.cc

Line 92, Patchset 1: content::URLDataSource::Add(profile, std::make_unique<ThemeSource>(profile));

Tommy Nyquist . resolved

Nit: since `content::URLDataSource::Add` is used directly here, perhaps we should also add `#include "content/public/browser/url_data_source.h"` rather than relying on the transitive include from `theme_source.h`. That would match the pattern from the earlier parts of this series (e.g. `chrome_file_manager_ui_delegate.cc` in part 4) and the existing registration in `chrome/browser/glic/host/glic_ui.cc`.

Mickey Burks

Definitely! Thanks

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iebf49940143702966d1b9659fdd0eb049d0cb58a

Gerrit-Change-Number: 8104772

Gerrit-PatchSet: 1

Gerrit-Owner: Mickey Burks <micke...@chromium.org>

Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 17 Jul 2026 21:40:04 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Tommy Nyquist <nyq...@chromium.org>

[Mickey Burks (Gerrit)]

Mickey Burks voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iebf49940143702966d1b9659fdd0eb049d0cb58a

Gerrit-Change-Number: 8104772

Gerrit-PatchSet: 2

Gerrit-Owner: Mickey Burks <micke...@chromium.org>

Gerrit-Reviewer: Mickey Burks <micke...@chromium.org>

Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Sat, 18 Jul 2026 18:30:54 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/glic/experimental_opt_in/glic_experimental_opt_in_ui.cc
Insertions: 1, Deletions: 0.

@@ -21,6 +21,7 @@
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/glic_experimental_opt_in_resources.h"
 #include "chrome/grit/glic_experimental_opt_in_resources_map.h"
+#include "content/public/browser/url_data_source.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_data_source.h"
```

Change information

Commit message:

[WebUI] Register ThemeSource explicitly, part 8.

In this part adding ThemeSource registration in
 - Glic experimental opt in

For details, refer to go/chrome-webui-explicit-theme-source-analysis

Bug: 40757220

Change-Id: Iebf49940143702966d1b9659fdd0eb049d0cb58a

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8104772

Commit-Queue: Mickey Burks <micke...@chromium.org>

Reviewed-by: Tommy Nyquist <nyq...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1664383}

Files:

• M chrome/browser/glic/experimental_opt_in/glic_experimental_opt_in_ui.cc

Change size: XS

Delta: 1 file changed, 4 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Tommy Nyquist

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iebf49940143702966d1b9659fdd0eb049d0cb58a

Gerrit-Change-Number: 8104772

Gerrit-PatchSet: 3

Gerrit-Owner: Mickey Burks <micke...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>