Ensure non-null Java object in MotionEventAndroid [chromium/src : main]

0 views
Skip to first unread message

Keigo Oka (Gerrit)

unread,
Jun 30, 2025, 3:03:54 AM6/30/25
to chromium...@chromium.org, James Su, apaselti...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, nona+...@chromium.org, dtapuska+ch...@chromium.org

Keigo Oka has uploaded the change for review

Commit message

Ensure non-null Java object in MotionEventAndroid

The `source` of a MotionEvent was previously passed as an argument
through the JNI boundary. This is unnecessary as it can be retrieved
from the MotionEvent object itself.

This commit modifies the JNI to pass the `MotionEvent` object to the
`MotionEventAndroid` constructor, allowing the `source` to be queried
directly from the event. This simplifies the JNI and removes redundant
arguments.
Bug: 417078839
Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d

Change diff


Change information

Files:
  • M components/input/web_input_event_builders_android_unittest.cc
  • M content/browser/android/content_ui_event_handler.cc
  • M content/browser/android/content_ui_event_handler.h
  • M content/browser/attribution_reporting/attribution_input_event_tracker_android_unittest.cc
  • M content/browser/renderer_host/input/input_transfer_handler_android_unittest.cc
  • M content/browser/renderer_host/render_widget_host_view_android_browsertest.cc
  • M content/browser/renderer_host/render_widget_host_view_android_unittest.cc
  • M content/browser/site_per_process_browsertest.cc
  • M content/browser/site_per_process_hit_test_browsertest.cc
  • M content/public/android/java/src/org/chromium/content/browser/ContentUiEventHandler.java
  • M ui/android/event_forwarder.cc
  • M ui/android/event_forwarder.h
  • M ui/android/java/src/org/chromium/ui/base/EventForwarder.java
  • M ui/android/view_android_unittest.cc
  • M ui/events/android/motion_event_android.cc
  • M ui/events/android/motion_event_android.h
  • M ui/events/android/motion_event_android_java.cc
  • M ui/events/android/motion_event_android_java.h
  • M ui/events/android/motion_event_android_native.cc
  • M ui/events/android/motion_event_android_native.h
  • M ui/events/android/motion_event_android_unittest.cc
Change size: L
Delta: 21 files changed, 249 insertions(+), 129 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
Gerrit-Change-Number: 6688667
Gerrit-PatchSet: 1
Gerrit-Owner: Keigo Oka <o...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Keigo Oka (Gerrit)

unread,
Jun 30, 2025, 3:24:19 AM6/30/25
to Mitsuru Oshima, Rakina Zata Amni, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Aman Verma, Mitsuru Oshima and Rakina Zata Amni

Keigo Oka voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aman Verma
  • Mitsuru Oshima
  • Rakina Zata Amni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
Gerrit-Change-Number: 6688667
Gerrit-PatchSet: 1
Gerrit-Owner: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Attention: Aman Verma <ama...@google.com>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Mon, 30 Jun 2025 07:23:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keigo Oka (Gerrit)

unread,
Jul 1, 2025, 8:55:22 PM7/1/25
to Chromium LUCI CQ, Mitsuru Oshima, Rakina Zata Amni, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Aman Verma, Mitsuru Oshima and Rakina Zata Amni

Keigo Oka voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aman Verma
  • Mitsuru Oshima
  • Rakina Zata Amni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
Gerrit-Change-Number: 6688667
Gerrit-PatchSet: 3
Gerrit-Owner: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Attention: Aman Verma <ama...@google.com>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Wed, 02 Jul 2025 00:54:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keigo Oka (Gerrit)

unread,
Jul 2, 2025, 4:49:40 AM7/2/25
to Chromium LUCI CQ, Mitsuru Oshima, Rakina Zata Amni, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org

Keigo Oka voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
Gerrit-Change-Number: 6688667
Gerrit-PatchSet: 4
Gerrit-Owner: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Comment-Date: Wed, 02 Jul 2025 08:49:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keigo Oka (Gerrit)

unread,
Jul 2, 2025, 5:00:58 AM7/2/25
to Chromium LUCI CQ, Mitsuru Oshima, Rakina Zata Amni, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org

Keigo Oka voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
Gerrit-Change-Number: 6688667
Gerrit-PatchSet: 5
Gerrit-Owner: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Comment-Date: Wed, 02 Jul 2025 09:00:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keigo Oka (Gerrit)

unread,
Jul 2, 2025, 5:39:15 AM7/2/25
to Chromium LUCI CQ, Mitsuru Oshima, Rakina Zata Amni, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org

Keigo Oka voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
Gerrit-Change-Number: 6688667
Gerrit-PatchSet: 6
Gerrit-Owner: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Comment-Date: Wed, 02 Jul 2025 09:38:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keigo Oka (Gerrit)

unread,
Jul 2, 2025, 5:49:14 AM7/2/25
to Chromium LUCI CQ, Mitsuru Oshima, Rakina Zata Amni, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Gerrit-Comment-Date: Wed, 02 Jul 2025 09:48:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keigo Oka (Gerrit)

unread,
Jul 2, 2025, 5:50:38 AM7/2/25
to Chromium LUCI CQ, Mitsuru Oshima, Rakina Zata Amni, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org

Keigo Oka voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
Gerrit-Change-Number: 6688667
Gerrit-PatchSet: 7
Gerrit-Owner: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Comment-Date: Wed, 02 Jul 2025 09:50:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keigo Oka (Gerrit)

unread,
Jul 2, 2025, 6:02:50 AM7/2/25
to Chromium LUCI CQ, Mitsuru Oshima, Rakina Zata Amni, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Gerrit-Comment-Date: Wed, 02 Jul 2025 10:02:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keigo Oka (Gerrit)

unread,
Jul 2, 2025, 6:04:04 AM7/2/25
to Chromium LUCI CQ, Mitsuru Oshima, Rakina Zata Amni, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org

Keigo Oka voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
Gerrit-Change-Number: 6688667
Gerrit-PatchSet: 8
Gerrit-Owner: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Comment-Date: Wed, 02 Jul 2025 10:03:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keigo Oka (Gerrit)

unread,
Jul 2, 2025, 7:11:14 AM7/2/25
to Chromium LUCI CQ, Mitsuru Oshima, Rakina Zata Amni, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Aman Verma, Mitsuru Oshima and Rakina Zata Amni

Keigo Oka added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Aman Verma
  • Mitsuru Oshima
  • Rakina Zata Amni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
Gerrit-Change-Number: 6688667
Gerrit-PatchSet: 8
Gerrit-Owner: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Attention: Aman Verma <ama...@google.com>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Wed, 02 Jul 2025 11:10:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Jul 2, 2025, 11:51:03 AM7/2/25
to Keigo Oka, Chromium LUCI CQ, Rakina Zata Amni, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Aman Verma, Keigo Oka and Rakina Zata Amni

Mitsuru Oshima voted and added 3 comments

Votes added by Mitsuru Oshima

Code-Review+1

3 comments

Patchset-level comments
Mitsuru Oshima . resolved

ui/events lgtm

can you also add a reviewer from ui/android/OWNERS for these files?

File ui/events/android/motion_event_android_java.cc
Line 73, Patchset 8 (Latest): DCHECK(event);
Mitsuru Oshima . unresolved

optional: You may leave it, but CHECK is now recommended over DCHECK.

File ui/events/android/motion_event_android_unittest.cc
Line 153, Patchset 8 (Latest): env, /*downTime*/ 0, /*eventTime*/ 0, /*action*/ 0, /*x*/ 0, /*y*/ 0,
Mitsuru Oshima . unresolved

nit:

    /*downTime=*/0, /*eventTime=*/0, etc.

same for the rest of the file.

Open in Gerrit

Related details

Attention is currently required from:
  • Aman Verma
  • Keigo Oka
  • Rakina Zata Amni
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
    Gerrit-Change-Number: 6688667
    Gerrit-PatchSet: 8
    Gerrit-Owner: Keigo Oka <o...@chromium.org>
    Gerrit-Reviewer: Aman Verma <ama...@google.com>
    Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Attention: Aman Verma <ama...@google.com>
    Gerrit-Attention: Keigo Oka <o...@chromium.org>
    Gerrit-Comment-Date: Wed, 02 Jul 2025 15:50:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rakina Zata Amni (Gerrit)

    unread,
    Jul 2, 2025, 7:50:16 PM7/2/25
    to Keigo Oka, Mitsuru Oshima, Chromium LUCI CQ, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Aman Verma and Keigo Oka

    Rakina Zata Amni voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Aman Verma
    • Keigo Oka
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
    Gerrit-Change-Number: 6688667
    Gerrit-PatchSet: 8
    Gerrit-Owner: Keigo Oka <o...@chromium.org>
    Gerrit-Reviewer: Aman Verma <ama...@google.com>
    Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-Attention: Aman Verma <ama...@google.com>
    Gerrit-Attention: Keigo Oka <o...@chromium.org>
    Gerrit-Comment-Date: Wed, 02 Jul 2025 23:49:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Keigo Oka (Gerrit)

    unread,
    Jul 2, 2025, 8:26:21 PM7/2/25
    to Sky Malice, Rakina Zata Amni, Mitsuru Oshima, Chromium LUCI CQ, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Aman Verma and Sky Malice

    Keigo Oka added 3 comments

    Patchset-level comments
    File-level comment, Patchset 10 (Latest):
    Keigo Oka . resolved

    +Skym as ui/android/ changes

    File ui/events/android/motion_event_android_java.cc
    Line 73, Patchset 8: DCHECK(event);
    Mitsuru Oshima . resolved

    optional: You may leave it, but CHECK is now recommended over DCHECK.

    Keigo Oka

    Let me make the change as a follow up.

    File ui/events/android/motion_event_android_unittest.cc
    Line 153, Patchset 8: env, /*downTime*/ 0, /*eventTime*/ 0, /*action*/ 0, /*x*/ 0, /*y*/ 0,
    Mitsuru Oshima . resolved

    nit:

        /*downTime=*/0, /*eventTime=*/0, etc.

    same for the rest of the file.

    Keigo Oka

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Aman Verma
    • Sky Malice
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
    Gerrit-Change-Number: 6688667
    Gerrit-PatchSet: 10
    Gerrit-Owner: Keigo Oka <o...@chromium.org>
    Gerrit-Reviewer: Aman Verma <ama...@google.com>
    Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-Attention: Sky Malice <sk...@chromium.org>
    Gerrit-Attention: Aman Verma <ama...@google.com>
    Gerrit-Comment-Date: Thu, 03 Jul 2025 00:25:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Keigo Oka (Gerrit)

    unread,
    Jul 2, 2025, 8:42:25 PM7/2/25
    to Sky Malice, Rakina Zata Amni, Mitsuru Oshima, Chromium LUCI CQ, Aman Verma, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Aman Verma and Sky Malice

    Keigo Oka voted Commit-Queue+1

    Commit-Queue+1
    Gerrit-Comment-Date: Thu, 03 Jul 2025 00:41:57 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Aman Verma (Gerrit)

    unread,
    Jul 3, 2025, 5:51:29 AM7/3/25
    to Keigo Oka, Sky Malice, Rakina Zata Amni, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Keigo Oka and Sky Malice

    Aman Verma voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keigo Oka
    • Sky Malice
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
    Gerrit-Change-Number: 6688667
    Gerrit-PatchSet: 10
    Gerrit-Owner: Keigo Oka <o...@chromium.org>
    Gerrit-Reviewer: Aman Verma <ama...@google.com>
    Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-Attention: Sky Malice <sk...@chromium.org>
    Gerrit-Attention: Keigo Oka <o...@chromium.org>
    Gerrit-Comment-Date: Thu, 03 Jul 2025 09:51:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Aman Verma (Gerrit)

    unread,
    Jul 3, 2025, 5:59:40 AM7/3/25
    to Keigo Oka, Sky Malice, Rakina Zata Amni, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Keigo Oka and Sky Malice

    Aman Verma voted and added 1 comment

    Votes added by Aman Verma

    Code-Review+0

    1 comment

    File ui/events/BUILD.gn
    Line 423, Patchset 10 (Latest): public_deps += [
    Aman Verma . unresolved

    Is this change required? The only additions for the header `ui/events/motionevent_jni_headers/MotionEvent_jni.h` I see in this patch are in test files which can add a dependency directly on `//ui/events:motionevent_jni_headers"` similar to [this](https://source.chromium.org/chromium/chromium/src/+/main:components/viz/service/BUILD.gn;l=740;drc=007205e3c3b1a6381b2f04409f811d2d2fbc4e82).

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keigo Oka
    • Sky Malice
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
    Gerrit-Change-Number: 6688667
    Gerrit-PatchSet: 10
    Gerrit-Owner: Keigo Oka <o...@chromium.org>
    Gerrit-Reviewer: Aman Verma <ama...@google.com>
    Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-Attention: Sky Malice <sk...@chromium.org>
    Gerrit-Attention: Keigo Oka <o...@chromium.org>
    Gerrit-Comment-Date: Thu, 03 Jul 2025 09:59:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Keigo Oka (Gerrit)

    unread,
    Jul 3, 2025, 9:54:32 PM7/3/25
    to Aman Verma, Sky Malice, Rakina Zata Amni, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Aman Verma, Mitsuru Oshima, Rakina Zata Amni and Sky Malice

    Keigo Oka voted and added 1 comment

    Votes added by Keigo Oka

    Commit-Queue+1

    1 comment

    File ui/events/BUILD.gn
    Line 423, Patchset 10: public_deps += [
    Aman Verma . resolved

    Is this change required? The only additions for the header `ui/events/motionevent_jni_headers/MotionEvent_jni.h` I see in this patch are in test files which can add a dependency directly on `//ui/events:motionevent_jni_headers"` similar to [this](https://source.chromium.org/chromium/chromium/src/+/main:components/viz/service/BUILD.gn;l=740;drc=007205e3c3b1a6381b2f04409f811d2d2fbc4e82).

    Keigo Oka

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Aman Verma
    • Mitsuru Oshima
    • Rakina Zata Amni
    • Sky Malice
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
      Gerrit-Change-Number: 6688667
      Gerrit-PatchSet: 11
      Gerrit-Owner: Keigo Oka <o...@chromium.org>
      Gerrit-Reviewer: Aman Verma <ama...@google.com>
      Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
      Gerrit-CC: James Su <su...@chromium.org>
      Gerrit-Attention: Sky Malice <sk...@chromium.org>
      Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Attention: Aman Verma <ama...@google.com>
      Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Comment-Date: Fri, 04 Jul 2025 01:54:09 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Aman Verma <ama...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Keigo Oka (Gerrit)

      unread,
      Jul 3, 2025, 10:00:29 PM7/3/25
      to Aman Verma, Sky Malice, Rakina Zata Amni, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
      Attention needed from Aman Verma, Mitsuru Oshima, Rakina Zata Amni and Sky Malice

      Keigo Oka voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Aman Verma
      • Mitsuru Oshima
      • Rakina Zata Amni
      • Sky Malice
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
      Gerrit-Change-Number: 6688667
      Gerrit-PatchSet: 12
      Gerrit-Owner: Keigo Oka <o...@chromium.org>
      Gerrit-Reviewer: Aman Verma <ama...@google.com>
      Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
      Gerrit-CC: James Su <su...@chromium.org>
      Gerrit-Attention: Sky Malice <sk...@chromium.org>
      Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Attention: Aman Verma <ama...@google.com>
      Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Comment-Date: Fri, 04 Jul 2025 02:00:08 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Keigo Oka (Gerrit)

      unread,
      Jul 3, 2025, 10:16:34 PM7/3/25
      to Aman Verma, Sky Malice, Rakina Zata Amni, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
      Attention needed from Aman Verma, Mitsuru Oshima, Rakina Zata Amni and Sky Malice

      Keigo Oka voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Aman Verma
      • Mitsuru Oshima
      • Rakina Zata Amni
      • Sky Malice
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
      Gerrit-Change-Number: 6688667
      Gerrit-PatchSet: 14
      Gerrit-Owner: Keigo Oka <o...@chromium.org>
      Gerrit-Reviewer: Aman Verma <ama...@google.com>
      Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
      Gerrit-CC: James Su <su...@chromium.org>
      Gerrit-Attention: Sky Malice <sk...@chromium.org>
      Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Attention: Aman Verma <ama...@google.com>
      Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Comment-Date: Fri, 04 Jul 2025 02:16:09 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Rakina Zata Amni (Gerrit)

      unread,
      Jul 4, 2025, 12:57:02 AM7/4/25
      to Keigo Oka, Aman Verma, Sky Malice, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
      Attention needed from Aman Verma, Keigo Oka, Mitsuru Oshima and Sky Malice

      Rakina Zata Amni voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Aman Verma
      • Keigo Oka
      • Mitsuru Oshima
      • Sky Malice
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
        Gerrit-Change-Number: 6688667
        Gerrit-PatchSet: 14
        Gerrit-Owner: Keigo Oka <o...@chromium.org>
        Gerrit-Reviewer: Aman Verma <ama...@google.com>
        Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
        Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
        Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
        Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
        Gerrit-CC: James Su <su...@chromium.org>
        Gerrit-Attention: Sky Malice <sk...@chromium.org>
        Gerrit-Attention: Aman Verma <ama...@google.com>
        Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
        Gerrit-Attention: Keigo Oka <o...@chromium.org>
        Gerrit-Comment-Date: Fri, 04 Jul 2025 04:56:34 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Keigo Oka (Gerrit)

        unread,
        Jul 4, 2025, 1:27:57 AM7/4/25
        to Rakina Zata Amni, Aman Verma, Sky Malice, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
        Attention needed from Aman Verma, Mitsuru Oshima and Sky Malice

        Keigo Oka voted Auto-Submit+1

        Auto-Submit+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Aman Verma
        • Mitsuru Oshima
        • Sky Malice
        Gerrit-Comment-Date: Fri, 04 Jul 2025 05:27:29 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Aman Verma (Gerrit)

        unread,
        Jul 4, 2025, 6:35:08 AM7/4/25
        to Keigo Oka, Rakina Zata Amni, Sky Malice, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
        Attention needed from Keigo Oka, Mitsuru Oshima and Sky Malice

        Aman Verma voted and added 1 comment

        Votes added by Aman Verma

        Code-Review+1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 14 (Latest):
        Aman Verma . resolved

        Thanks! LGTM :)

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Keigo Oka
        • Mitsuru Oshima
        • Sky Malice
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
        Gerrit-Change-Number: 6688667
        Gerrit-PatchSet: 14
        Gerrit-Owner: Keigo Oka <o...@chromium.org>
        Gerrit-Reviewer: Aman Verma <ama...@google.com>
        Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
        Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
        Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
        Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
        Gerrit-CC: James Su <su...@chromium.org>
        Gerrit-Attention: Sky Malice <sk...@chromium.org>
        Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
        Gerrit-Attention: Keigo Oka <o...@chromium.org>
        Gerrit-Comment-Date: Fri, 04 Jul 2025 10:34:50 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Keigo Oka (Gerrit)

        unread,
        Jul 5, 2025, 3:51:19 AM7/5/25
        to Aman Verma, Rakina Zata Amni, Sky Malice, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
        Attention needed from Mitsuru Oshima and Sky Malice

        Keigo Oka voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Mitsuru Oshima
        • Sky Malice
        Gerrit-Comment-Date: Sat, 05 Jul 2025 07:50:45 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jul 5, 2025, 4:36:32 AM7/5/25
        to Keigo Oka, Aman Verma, Rakina Zata Amni, Sky Malice, Mitsuru Oshima, chromium...@chromium.org, James Su, alexmo...@chromium.org, apaselti...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Ensure non-null Java object in MotionEventAndroid

        The `source` of a MotionEvent was previously passed as an argument
        through the JNI boundary. This is unnecessary as it can be retrieved
        from the MotionEvent object itself.

        This commit modifies the JNI to pass the `MotionEvent` object to the
        `MotionEventAndroid` constructor, allowing the `source` to be queried
        directly from the event. This simplifies the JNI and removes redundant
        arguments.
        Bug: 417078839
        Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
        Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
        Auto-Submit: Keigo Oka <o...@chromium.org>
        Reviewed-by: Aman Verma <ama...@google.com>
        Commit-Queue: Keigo Oka <o...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1482784}
        Files:
        • M components/input/BUILD.gn
        • M components/input/web_input_event_builders_android_unittest.cc
        • M content/browser/android/content_ui_event_handler.cc
        • M content/browser/android/content_ui_event_handler.h
        • M content/browser/attribution_reporting/attribution_input_event_tracker_android_unittest.cc
        • M content/browser/renderer_host/input/input_transfer_handler_android_unittest.cc
        • M content/browser/renderer_host/render_widget_host_view_android_browsertest.cc
        • M content/browser/renderer_host/render_widget_host_view_android_unittest.cc
        • M content/browser/site_per_process_browsertest.cc
        • M content/browser/site_per_process_hit_test_browsertest.cc
        • M content/public/android/java/src/org/chromium/content/browser/ContentUiEventHandler.java
        • M content/public/android/junit/src/org/chromium/content/browser/ContentUiEventHandlerTest.java
        • M content/test/BUILD.gn
        • M ui/android/BUILD.gn
        • M ui/android/event_forwarder.cc
        • M ui/android/event_forwarder.h
        • M ui/android/java/src/org/chromium/ui/base/EventForwarder.java
        • M ui/android/junit/src/org/chromium/ui/base/EventForwarderTest.java
        • M ui/android/junit/src/org/chromium/ui/base/MotionEventTestUtils.java
        • M ui/android/view_android_unittest.cc
        • M ui/events/android/motion_event_android.cc
        • M ui/events/android/motion_event_android.h
        • M ui/events/android/motion_event_android_java.cc
        • M ui/events/android/motion_event_android_java.h
        • M ui/events/android/motion_event_android_native.cc
        • M ui/events/android/motion_event_android_native.h
        • M ui/events/android/motion_event_android_unittest.cc
          Change size: L
          Delta: 27 files changed, 505 insertions(+), 223 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Rakina Zata Amni, +1 by Aman Verma
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ie1e04fd9438d45b5266e29e4eb5de829ec2da41d
          Gerrit-Change-Number: 6688667
          Gerrit-PatchSet: 15
          Gerrit-Owner: Keigo Oka <o...@chromium.org>
          Gerrit-Reviewer: Aman Verma <ama...@google.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
          Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
          Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
          Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages