Settings Lit: Introduce PrefKeyObserverMixin to avoid duplication. [chromium/src : main]
0 views
Skip to first unread message
Demetrios Papadopoulos (Gerrit)
Jul 8, 2026, 6:31:44 PM (9 hours ago) Jul 8
to Rebekah Potter, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Rebekah Potter
Demetrios Papadopoulos voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Rebekah Potter
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rebekah Potter (Gerrit)
Jul 8, 2026, 6:43:57 PM (9 hours ago) Jul 8
to Demetrios Papadopoulos, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Demetrios Papadopoulos
Rebekah Potter voted![]( "Open in Gerrit")
Attention is currently required from:
- Demetrios Papadopoulos
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 8, 2026, 6:56:02 PM (8 hours ago) Jul 8
to Demetrios Papadopoulos, Rebekah Potter, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Settings Lit: Introduce PrefKeyObserverMixin to avoid duplication.
The mixin is a helper for elements that monitor a single pref:
- controlled-radio-button
- settings-checkbox
- settings-dropdown-menu
- settings-radio-group
- settings-slider
- settings-toggle-button
It ensures that the prefKey is only ever assigned once and also sets up
the necessary listeners for the local 'pref' property to be updated
whenever the pref changes on the backend.
During the migration both Lit and Polymer versions of the mixin are
needed.
Bug: 393471368
Change-Id: I86c76eff406c3276bd3c0bbd4735281136625c55
Commit-Queue: Rebekah Potter <rbpo...@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpa...@chromium.org>
Reviewed-by: Rebekah Potter <rbpo...@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659109}
Files:
- M chrome/browser/resources/settings/BUILD.gn
- M chrome/browser/resources/settings/controls/controlled_radio_button.ts
- A chrome/browser/resources/settings/controls/pref_key_observer_mixin.ts
- A chrome/browser/resources/settings/controls/pref_key_observer_mixin_lit.ts
- M chrome/browser/resources/settings/controls/settings_dropdown_menu.ts
- M chrome/browser/resources/settings/controls/settings_radio_group.ts
- M chrome/browser/resources/settings/controls/settings_slider.ts
- M chrome/browser/resources/settings/controls/settings_toggle_button.ts
Change size: M
Delta: 8 files changed, 115 insertions(+), 92 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rebekah Potter
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages