[Webview] Refactor RenderThread context loss handling. [chromium/src : main]

0 views
Skip to first unread message

vikas soni (Gerrit)

unread,
Aug 6, 2026, 7:57:15 PM (3 days ago) Aug 6
to Bo Liu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org
Attention needed from Bo Liu

vikas soni added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
vikas soni . resolved

PTAL. thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Bo Liu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7e43c6e4dbd61374c6c62b8e8f09df242786b66e
Gerrit-Change-Number: 8213962
Gerrit-PatchSet: 7
Gerrit-Owner: vikas soni <vika...@chromium.org>
Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: vikas soni <vika...@chromium.org>
Gerrit-Attention: Bo Liu <bo...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Aug 2026 23:57:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Bo Liu (Gerrit)

unread,
Aug 6, 2026, 11:46:02 PM (3 days ago) Aug 6
to vikas soni, Bo Liu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org
Attention needed from vikas soni

Bo Liu added 2 comments

File android_webview/browser/gfx/aw_draw_fn_impl.cc
Line 191, Patchset 8 (Latest):// attempting any drawing operations or touching context state.
Bo Liu . unresolved

it's more specific.. we are not asking underlying context if it's lost, we are asking the shared context state has detected loss already

which means entrace check should only fire on shared context state already lost on some other call and we've survived thus far

File android_webview/browser/gfx/hardware_renderer.cc
Line 853, Patchset 8 (Latest): // intentionally crash in HardwareRenderer::OnViz::DisplayOutputSurface()
Bo Liu . unresolved

uhh, I guess we want to remove the intentinoal crash in DisplayOutputSurfaceLost as well, since a shared context can still hit it asynchronously even if all webviews are being shutdown

and it's moot if context is not shared

Open in Gerrit

Related details

Attention is currently required from:
  • vikas soni
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7e43c6e4dbd61374c6c62b8e8f09df242786b66e
    Gerrit-Change-Number: 8213962
    Gerrit-PatchSet: 8
    Gerrit-Attention: vikas soni <vika...@chromium.org>
    Gerrit-Comment-Date: Fri, 07 Aug 2026 03:45:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    vikas soni (Gerrit)

    unread,
    Aug 7, 2026, 11:43:49 AM (2 days ago) Aug 7
    to Bo Liu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org
    Attention needed from Bo Liu

    vikas soni added 3 comments

    Patchset-level comments
    File-level comment, Patchset 9 (Latest):
    vikas soni . resolved

    thanks for review.

    File android_webview/browser/gfx/aw_draw_fn_impl.cc
    Line 191, Patchset 8:// attempting any drawing operations or touching context state.
    Bo Liu . resolved

    it's more specific.. we are not asking underlying context if it's lost, we are asking the shared context state has detected loss already

    which means entrace check should only fire on shared context state already lost on some other call and we've survived thus far

    vikas soni

    Done

    File android_webview/browser/gfx/hardware_renderer.cc
    Line 853, Patchset 8: // intentionally crash in HardwareRenderer::OnViz::DisplayOutputSurface()
    Bo Liu . resolved

    uhh, I guess we want to remove the intentinoal crash in DisplayOutputSurfaceLost as well, since a shared context can still hit it asynchronously even if all webviews are being shutdown

    and it's moot if context is not shared

    vikas soni

    ack

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bo Liu
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7e43c6e4dbd61374c6c62b8e8f09df242786b66e
      Gerrit-Change-Number: 8213962
      Gerrit-PatchSet: 9
      Gerrit-Attention: Bo Liu <bo...@chromium.org>
      Gerrit-Comment-Date: Fri, 07 Aug 2026 15:43:35 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Bo Liu <bo...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Bo Liu (Gerrit)

      unread,
      6:08 PM (2 hours ago) 6:08 PM
      to vikas soni, Bo Liu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org
      Attention needed from vikas soni

      Bo Liu voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • vikas soni
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7e43c6e4dbd61374c6c62b8e8f09df242786b66e
      Gerrit-Change-Number: 8213962
      Gerrit-PatchSet: 9
      Gerrit-Owner: vikas soni <vika...@chromium.org>
      Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
      Gerrit-Reviewer: vikas soni <vika...@chromium.org>
      Gerrit-Attention: vikas soni <vika...@chromium.org>
      Gerrit-Comment-Date: Sun, 09 Aug 2026 22:08:07 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages