[AtMemory][Android] Check AtMemory websites eligilibity [chromium/src : main]

[Atalyk Akash (Gerrit)]

Attention needed from Jan Keitel, Piotr Kotynia and Timofey Chudakov

Atalyk Akash added 5 comments

Commit Message

Line 7, Patchset 3:[AtMemory][Android] Check AtMemory websites elgilibity

Jan Keitel . resolved

Nit: Typo

Atalyk Akash

Done

File chrome/browser/keyboard_accessory/android/at_memory_accessory_controller_impl.cc

Line 44, Patchset 3: *web_contents),

Jan Keitel . resolved

Optional nit: `CHECK_DEREF`.

Atalyk Akash

Done

Line 121, Patchset 3: if (!mf_controller_) {
mf_controller_ = ManualFillingController::GetOrCreate(&GetWebContents());
}
DCHECK(mf_controller_);
return mf_controller_;

Jan Keitel . resolved

Why do we save it into a member instead of just returning `ManualFillingController::GetOrCreate(&GetWebContents());`?

Atalyk Akash

Unit test passed mockcontroller during testing using CreateForWebContentsForTesting, which is reused during testing.

File chrome/browser/keyboard_accessory/android/at_memory_accessory_controller_impl_unittest.cc

Line 35, Patchset 3: void TearDown() override { ChromeRenderViewHostTestHarness::TearDown(); }

Jan Keitel . resolved

Drop?

Atalyk Akash

Done

File chrome/browser/keyboard_accessory/android/manual_filling_controller_impl_unittest.cc

Line 462, Patchset 3: EXPECT_CALL(mock_at_memory_controller_, RefreshSuggestions());

Jan Keitel . resolved

Nit: Drop.

Atalyk Akash

Done

Open in Gerrit

Related details

Attention is currently required from:

• Jan Keitel
• Piotr Kotynia
• Timofey Chudakov

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0805250e22a5d57049955b0a2e192f4dd31a1454

Gerrit-Change-Number: 8129948

Gerrit-PatchSet: 5

Gerrit-Owner: Atalyk Akash <ata...@google.com>

Gerrit-Reviewer: Atalyk Akash <ata...@google.com>

Gerrit-Reviewer: Jan Keitel <jke...@google.com>

Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>

Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jan Keitel <jke...@google.com>

Gerrit-Attention: Timofey Chudakov <tchu...@google.com>

Gerrit-Attention: Piotr Kotynia <piotrk...@google.com>

Gerrit-Comment-Date: Thu, 23 Jul 2026 13:51:08 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Jan Keitel <jke...@google.com>

[Timofey Chudakov (Gerrit)]

Attention needed from Jan Keitel and Piotr Kotynia

Timofey Chudakov added 3 comments

Patchset-level comments

File-level comment, Patchset 3:

Timofey Chudakov . resolved

Discussed offline, LGTM modulo we're going to redesign the manual fallback entry points.

File chrome/browser/keyboard_accessory/android/at_memory_accessory_controller_impl.cc

Line 52, Patchset 3: DCHECK(web_contents) << "Need valid WebContents to attach controller to!";

Timofey Chudakov . unresolved

We don't use DCHECK anymore, use CHECK instead

https://g3doc.corp.google.com/devtools/library_club/g3doc/totw/labs/avoid-dcheck.md?cl=head

Line 124, Patchset 3: DCHECK(mf_controller_);

Timofey Chudakov . unresolved

Same here.

Open in Gerrit

Related details

Attention is currently required from:

• Jan Keitel
• Piotr Kotynia

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0805250e22a5d57049955b0a2e192f4dd31a1454

Gerrit-Change-Number: 8129948

Gerrit-PatchSet: 3

Gerrit-Owner: Atalyk Akash <ata...@google.com>

Gerrit-Reviewer: Atalyk Akash <ata...@google.com>

Gerrit-Reviewer: Jan Keitel <jke...@google.com>

Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>

Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jan Keitel <jke...@google.com>

Gerrit-Attention: Piotr Kotynia <piotrk...@google.com>

Gerrit-Comment-Date: Thu, 23 Jul 2026 14:49:54 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Timofey Chudakov (Gerrit)]

Attention needed from Atalyk Akash, Jan Keitel and Piotr Kotynia

Timofey Chudakov added 1 comment

File chrome/browser/keyboard_accessory/android/at_memory_accessory_controller_impl.cc

Line 136, Patchset 5 (Latest): const bool is_eligible = autofill::MayPerformAtMemoryAction(

Timofey Chudakov . unresolved

Please try to do this check in the place where you add the icon to the list of icons in the keyboard accessory on the Java side.

Open in Gerrit

Related details

Attention is currently required from:

• Atalyk Akash
• Jan Keitel
• Piotr Kotynia

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0805250e22a5d57049955b0a2e192f4dd31a1454

Gerrit-Change-Number: 8129948

Gerrit-PatchSet: 5

Gerrit-Owner: Atalyk Akash <ata...@google.com>

Gerrit-Reviewer: Atalyk Akash <ata...@google.com>

Gerrit-Reviewer: Jan Keitel <jke...@google.com>

Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>

Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jan Keitel <jke...@google.com>

Gerrit-Attention: Atalyk Akash <ata...@google.com>

Gerrit-Attention: Piotr Kotynia <piotrk...@google.com>

Gerrit-Comment-Date: Thu, 23 Jul 2026 14:56:21 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jan Keitel (Gerrit)]

Attention needed from Atalyk Akash and Piotr Kotynia

Jan Keitel added 1 comment

File chrome/browser/keyboard_accessory/android/at_memory_accessory_controller_impl.cc

Line 121, Patchset 3: if (!mf_controller_) {
mf_controller_ = ManualFillingController::GetOrCreate(&GetWebContents());
}
DCHECK(mf_controller_);
return mf_controller_;

Jan Keitel . unresolved

Why do we save it into a member instead of just returning `ManualFillingController::GetOrCreate(&GetWebContents());`?

Atalyk Akash

Unit test passed mockcontroller during testing using CreateForWebContentsForTesting, which is reused during testing.

Jan Keitel

Could you explain this a bit more? `AtMemoryAccessoryControllerImpl::CreateForWebContentsForTesting` doesn't even access the member. What am I reading wrong?

Open in Gerrit

Related details

Attention is currently required from:

• Atalyk Akash
• Piotr Kotynia

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0805250e22a5d57049955b0a2e192f4dd31a1454

Gerrit-Change-Number: 8129948

Gerrit-PatchSet: 5

Gerrit-Owner: Atalyk Akash <ata...@google.com>

Gerrit-Reviewer: Atalyk Akash <ata...@google.com>

Gerrit-Reviewer: Jan Keitel <jke...@google.com>

Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>

Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Atalyk Akash <ata...@google.com>

Gerrit-Attention: Piotr Kotynia <piotrk...@google.com>

Gerrit-Comment-Date: Thu, 23 Jul 2026 15:24:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Jan Keitel <jke...@google.com>

Comment-In-Reply-To: Atalyk Akash <ata...@google.com>

[Piotr Kotynia (Gerrit)]

Attention needed from Atalyk Akash

Piotr Kotynia added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Piotr Kotynia . resolved

as discussed offline, Atalyk will explore simpler option to directly call for eligibility without complex logic

Open in Gerrit

Related details

Attention is currently required from:

• Atalyk Akash

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0805250e22a5d57049955b0a2e192f4dd31a1454

Gerrit-Change-Number: 8129948

Gerrit-PatchSet: 5

Gerrit-Owner: Atalyk Akash <ata...@google.com>

Gerrit-Reviewer: Atalyk Akash <ata...@google.com>

Gerrit-Reviewer: Jan Keitel <jke...@google.com>

Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>

Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Atalyk Akash <ata...@google.com>

Gerrit-Comment-Date: Fri, 24 Jul 2026 09:13:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No