cros/cmd/provision: dynamically detect ADB connection for foil provision images [infra/infra : main]
Jae Hoon Kim (Gerrit)
Jae Hoon Kim voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
- Garry Wang
- Otabek Kasimov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
Otabek Kasimov added 3 comments![]( "Open in Gerrit")
ForceAdb boollet specify what for to use adb? lets call it ForceDUTAccessByADB or UseADBForDUTAccess. or call it as compressed provision image (comment below)
isCompressed := strings.HasSuffix(provisionOSImagePath, ".zst") || strings.HasSuffix(provisionOSImagePath, ".zstd")please add comment to tell that compressed image required ADB access.
s.params.ForceAdb = isCompressedplease log it as setting that ewe set need use ADB access due to compressed image. if possible do not use ForceAdb and just make a field `ProvisionImageCompressed` as it will remove assumption overall.
Related details
- Garry Wang
- Jae Hoon Kim
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jae Hoon Kim (Gerrit)
Jae Hoon Kim voted and added 3 comments![]( "Open in Gerrit")
Votes added by Jae Hoon Kim
| Auto-Submit | +1 |
| Commit-Queue | +1 |
3 comments
let specify what for to use adb? lets call it ForceDUTAccessByADB or UseADBForDUTAccess. or call it as compressed provision image (comment below)
Done
isCompressed := strings.HasSuffix(provisionOSImagePath, ".zst") || strings.HasSuffix(provisionOSImagePath, ".zstd")please add comment to tell that compressed image required ADB access.
Done
please log it as setting that ewe set need use ADB access due to compressed image. if possible do not use ForceAdb and just make a field `ProvisionImageCompressed` as it will remove assumption overall.
- Garry Wang
- Otabek Kasimov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
Otabek Kasimov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Otabek Kasimov
| Code-Review | +1 |
2 comments
s.params.ForceAdb = isCompressedJae Hoon Kimplease log it as setting that ewe set need use ADB access due to compressed image. if possible do not use ForceAdb and just make a field `ProvisionImageCompressed` as it will remove assumption overall.
Acknowledged
not sure where is the log.
please move comment to the place where initialized `isCompressed`
Related details
- Garry Wang
- Jae Hoon Kim
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jae Hoon Kim (Gerrit)
Jae Hoon Kim voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jae Hoon Kim
| Commit-Queue | +2 |
1 comment
s.params.ForceAdb = isCompressedJae Hoon Kimplease log it as setting that ewe set need use ADB access due to compressed image. if possible do not use ForceAdb and just make a field `ProvisionImageCompressed` as it will remove assumption overall.
Otabek KasimovAcknowledged
not sure where is the log.
please move comment to the place where initialized `isCompressed`
Not adding the logs for this since the commands run will clearly show it taking the new paths.
So we don't need them
Related details
- Garry Wang
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
LUCI CQ (Gerrit)
LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
cros/cmd/provision: dynamically detect ADB connection for foil provision images
Instead of hardcoding models in GetAdbOnlyModelList, dynamically
detect if we need ADB connection by checking if we booted from a
compressed foil provision image (provision.bin.zst).
We set UseADBForDUTAccess in CrossOverParameters during SetupUSBState
if the successfully flashed image was compressed, and verify it in
FullOSImageState.
This ensures that we use ADB for all foil runs (including ruby,
lapis, moonstone) while correctly falling back to SSH if we
had to fall back to a ChromeOS provision image.
Bug: 503426131
Test: go test ./...
TAG=agy
CONV=83cb11e8-5a86-4475-99a3-47a05e59f77d
- M go/src/infra/cros/cmd/provision/common-utils/cross-over/cross_over_init_state.go
- M go/src/infra/cros/cmd/provision/common-utils/cross-over/full_os_image_state.go
- M go/src/infra/cros/cmd/provision/common-utils/cross-over/full_os_image_state_test.go
- M go/src/infra/cros/cmd/provision/common-utils/cross-over/setup_usb_state.go
- M go/src/infra/cros/cmd/provision/common-utils/cross-over/setup_usb_state_test.go
Code-Review: +1 by Otabek Kasimov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |