Create save_and_fill_manager to pac if flag is on [chromium/src : main]

0 views
Skip to first unread message

Olivia Saul (Gerrit)

unread,
Feb 6, 2026, 7:05:44 PM (18 hours ago) Feb 6
to Qihui Zhao, Olivia Saul, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Qihui Zhao

Olivia Saul voted and added 1 comment

Votes added by Olivia Saul

Code-Review+1

1 comment

File ios/chrome/browser/autofill/ui_bundled/ios_chrome_payments_autofill_client.h
Line 50, Patchset 4 (Latest):class SaveAndFillManager;
Olivia Saul . unresolved

alpha ordering (SaveAnd < SaveCard)

Open in Gerrit

Related details

Attention is currently required from:
  • Qihui Zhao
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibcf17629fbd76a75d6b72d49804c466e6a61d377
Gerrit-Change-Number: 7551030
Gerrit-PatchSet: 4
Gerrit-Owner: Qihui Zhao <qihu...@google.com>
Gerrit-Reviewer: Olivia Saul <os...@google.com>
Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
Gerrit-Attention: Qihui Zhao <qihu...@google.com>
Gerrit-Comment-Date: Sat, 07 Feb 2026 00:05:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Qihui Zhao (Gerrit)

unread,
Feb 6, 2026, 7:34:02 PM (17 hours ago) Feb 6
to Olivia Saul, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org

Qihui Zhao added 2 comments

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Qihui Zhao . resolved

Thanks!

File ios/chrome/browser/autofill/ui_bundled/ios_chrome_payments_autofill_client.h
Line 50, Patchset 4:class SaveAndFillManager;
Olivia Saul . resolved

alpha ordering (SaveAnd < SaveCard)

Qihui Zhao

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcf17629fbd76a75d6b72d49804c466e6a61d377
    Gerrit-Change-Number: 7551030
    Gerrit-PatchSet: 5
    Gerrit-Owner: Qihui Zhao <qihu...@google.com>
    Gerrit-Reviewer: Olivia Saul <os...@google.com>
    Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
    Gerrit-Comment-Date: Sat, 07 Feb 2026 00:33:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Olivia Saul <os...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Qihui Zhao (Gerrit)

    unread,
    Feb 6, 2026, 7:34:25 PM (17 hours ago) Feb 6
    to Vincent Boisselle, Olivia Saul, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Vincent Boisselle

    Qihui Zhao added 1 comment

    Patchset-level comments
    Qihui Zhao . resolved

    Hi Vincent, please take a look, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vincent Boisselle
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcf17629fbd76a75d6b72d49804c466e6a61d377
    Gerrit-Change-Number: 7551030
    Gerrit-PatchSet: 5
    Gerrit-Owner: Qihui Zhao <qihu...@google.com>
    Gerrit-Reviewer: Olivia Saul <os...@google.com>
    Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
    Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
    Gerrit-Attention: Vincent Boisselle <vi...@google.com>
    Gerrit-Comment-Date: Sat, 07 Feb 2026 00:34:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vincent Boisselle (Gerrit)

    unread,
    6:54 AM (6 hours ago) 6:54 AM
    to Qihui Zhao, Olivia Saul, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Qihui Zhao

    Vincent Boisselle voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Qihui Zhao
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcf17629fbd76a75d6b72d49804c466e6a61d377
    Gerrit-Change-Number: 7551030
    Gerrit-PatchSet: 5
    Gerrit-Owner: Qihui Zhao <qihu...@google.com>
    Gerrit-Reviewer: Olivia Saul <os...@google.com>
    Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
    Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
    Gerrit-Attention: Qihui Zhao <qihu...@google.com>
    Gerrit-Comment-Date: Sat, 07 Feb 2026 11:53:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages