[Autofill] Make EntityInstance::use_count() int64_t [chromium/src : main]

0 views
Skip to first unread message

Christoph Schwering (Gerrit)

unread,
Jan 9, 2026, 12:01:09 PM (3 days ago) Jan 9
to Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Jan Keitel

Christoph Schwering voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jan Keitel
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ida42f62c18ca1aaac626fac914368bb139fba7e3
Gerrit-Change-Number: 7414989
Gerrit-PatchSet: 2
Gerrit-Owner: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Jan Keitel <jke...@google.com>
Gerrit-Attention: Jan Keitel <jke...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 17:00:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jan Keitel (Gerrit)

unread,
1:56 AM (19 hours ago) 1:56 AM
to Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Christoph Schwering

Jan Keitel voted and added 1 comment

Votes added by Jan Keitel

Code-Review+1

1 comment

File components/autofill/core/browser/data_model/autofill_ai/entity_instance.h
Line 208, Patchset 2 (Latest): int64_t use_count;
Jan Keitel . unresolved

Predates this CL, but wouldn't it be good to add a default value here?

Open in Gerrit

Related details

Attention is currently required from:
  • Christoph Schwering
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ida42f62c18ca1aaac626fac914368bb139fba7e3
    Gerrit-Change-Number: 7414989
    Gerrit-PatchSet: 2
    Gerrit-Owner: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Attention: Christoph Schwering <schw...@google.com>
    Gerrit-Comment-Date: Mon, 12 Jan 2026 06:55:50 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Christoph Schwering (Gerrit)

    unread,
    8:13 AM (12 hours ago) 8:13 AM
    to Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org

    Christoph Schwering voted and added 1 comment

    Votes added by Christoph Schwering

    Auto-Submit+1
    Commit-Queue+2

    1 comment

    File components/autofill/core/browser/data_model/autofill_ai/entity_instance.h
    Line 208, Patchset 2: int64_t use_count;
    Jan Keitel . resolved

    Predates this CL, but wouldn't it be good to add a default value here?

    Christoph Schwering

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ida42f62c18ca1aaac626fac914368bb139fba7e3
      Gerrit-Change-Number: 7414989
      Gerrit-PatchSet: 3
      Gerrit-Owner: Christoph Schwering <schw...@google.com>
      Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
      Gerrit-Reviewer: Jan Keitel <jke...@google.com>
      Gerrit-Comment-Date: Mon, 12 Jan 2026 13:13:35 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Jan Keitel <jke...@google.com>
      satisfied_requirement
      open
      diffy

      Josef Raska (Gerrit)

      unread,
      8:46 AM (12 hours ago) 8:46 AM
      to Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
      Attention needed from Christoph Schwering

      Josef Raska added 1 comment

      File components/autofill/core/browser/webdata/autofill_ai/entity_table.cc
      Line 511, Patchset 2: int use_count = s.ColumnInt64(1);
      Josef Raska . unresolved

      Shall there be `int64_t` as in the rest of the changes?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Christoph Schwering
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ida42f62c18ca1aaac626fac914368bb139fba7e3
        Gerrit-Change-Number: 7414989
        Gerrit-PatchSet: 3
        Gerrit-Owner: Christoph Schwering <schw...@google.com>
        Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
        Gerrit-Reviewer: Jan Keitel <jke...@google.com>
        Gerrit-CC: Josef Raska <josef...@google.com>
        Gerrit-Attention: Christoph Schwering <schw...@google.com>
        Gerrit-Comment-Date: Mon, 12 Jan 2026 13:46:03 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Christoph Schwering (Gerrit)

        unread,
        11:04 AM (9 hours ago) 11:04 AM
        to Josef Raska, Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
        Attention needed from Josef Raska

        Christoph Schwering voted and added 1 comment

        Votes added by Christoph Schwering

        Auto-Submit+1
        Commit-Queue+2

        1 comment

        File components/autofill/core/browser/webdata/autofill_ai/entity_table.cc
        Line 511, Patchset 2: int use_count = s.ColumnInt64(1);
        Josef Raska . resolved

        Shall there be `int64_t` as in the rest of the changes?

        Christoph Schwering

        Of course, thanks a lot for catching this!

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Josef Raska
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ida42f62c18ca1aaac626fac914368bb139fba7e3
          Gerrit-Change-Number: 7414989
          Gerrit-PatchSet: 5
          Gerrit-Owner: Christoph Schwering <schw...@google.com>
          Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
          Gerrit-Reviewer: Jan Keitel <jke...@google.com>
          Gerrit-CC: Josef Raska <josef...@google.com>
          Gerrit-Attention: Josef Raska <josef...@google.com>
          Gerrit-Comment-Date: Mon, 12 Jan 2026 16:04:37 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          Comment-In-Reply-To: Josef Raska <josef...@google.com>
          satisfied_requirement
          open
          diffy

          Josef Raska (Gerrit)

          unread,
          11:27 AM (9 hours ago) 11:27 AM
          to Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
          Attention needed from Christoph Schwering

          Josef Raska added 1 comment

          Patchset-level comments
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Christoph Schwering
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ida42f62c18ca1aaac626fac914368bb139fba7e3
          Gerrit-Change-Number: 7414989
          Gerrit-PatchSet: 5
          Gerrit-Owner: Christoph Schwering <schw...@google.com>
          Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
          Gerrit-Reviewer: Jan Keitel <jke...@google.com>
          Gerrit-CC: Josef Raska <josef...@google.com>
          Gerrit-Attention: Christoph Schwering <schw...@google.com>
          Gerrit-Comment-Date: Mon, 12 Jan 2026 16:27:27 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          12:11 PM (8 hours ago) 12:11 PM
          to Josef Raska, Jan Keitel, chromium...@chromium.org, browser-comp...@chromium.org

          Chromium LUCI CQ submitted the change with unreviewed changes

          Unreviewed changes

          2 is the latest approved patch-set.
          The change was submitted with unreviewed changes in the following files:

          ```
          The name of the file: components/autofill/core/browser/data_model/autofill_ai/entity_instance.h
          Insertions: 1, Deletions: 1.

          The diff is too large to show. Please review the diff.
          ```
          ```
          The name of the file: components/autofill/core/browser/webdata/autofill_ai/entity_table.cc
          Insertions: 1, Deletions: 1.

          The diff is too large to show. Please review the diff.
          ```

          Change information

          Commit message:
          [Autofill] Make EntityInstance::use_count() int64_t

          Before this CL, EntityInstance use counts were represented as
          `int`, `int64_t`, or `size_t` in various places.

          Since it's `int64_t` in the database and in the protos, this CL
          CL migrates the `int` and `size_t` occurrences to `int64_t`.
          Bug: 40100455
          Change-Id: Ida42f62c18ca1aaac626fac914368bb139fba7e3
          Reviewed-by: Jan Keitel <jke...@google.com>
          Commit-Queue: Christoph Schwering <schw...@google.com>
          Auto-Submit: Christoph Schwering <schw...@google.com>
          Cr-Commit-Position: refs/heads/main@{#1567837}
          Files:
          • M components/autofill/core/browser/data_manager/autofill_ai/entity_data_manager_unittest.cc
          • M components/autofill/core/browser/data_model/autofill_ai/entity_instance.cc
          • M components/autofill/core/browser/data_model/autofill_ai/entity_instance.h
          • M components/autofill/core/browser/webdata/autofill_ai/entity_sync_util.cc
          • M components/autofill/core/browser/webdata/autofill_ai/entity_table.cc
          • M components/autofill/core/browser/webdata/autofill_ai/entity_table.h
          Change size: S
          Delta: 6 files changed, 11 insertions(+), 11 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Jan Keitel
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ida42f62c18ca1aaac626fac914368bb139fba7e3
          Gerrit-Change-Number: 7414989
          Gerrit-PatchSet: 6
          Gerrit-Owner: Christoph Schwering <schw...@google.com>
          Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Jan Keitel <jke...@google.com>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages