Huanpo Lin (Gerrit)

unread,

Nov 26, 2025, 11:02:50 PM11/26/25

to Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, tburkar...@chromium.org

Attention needed from Hiroki Nakagawa

Huanpo Lin voted and added 1 comment

Votes added by Huanpo Lin

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6:

Huanpo Lin . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Hiroki Nakagawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hiroki Nakagawa (Gerrit)

unread,

Nov 27, 2025, 1:14:15 AM11/27/25

to Huanpo Lin, Lingqi Chi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, tburkar...@chromium.org

Attention needed from Huanpo Lin and Lingqi Chi

Hiroki Nakagawa added 2 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Hiroki Nakagawa . resolved

+lingqi@: Can you review this CL together?

File content/browser/preloading/prerender/prerender_host.cc

Line 561, Patchset 5:bool PrerenderHost::StartPrerendering() {

Hiroki Nakagawa . unresolved

This CL supports form submission on matching, but prerender initial navigation still seems to run as non-form submission. Does a follow-up CL implement it?

Open in Gerrit

Related details

Attention is currently required from:

Huanpo Lin
Lingqi Chi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Huanpo Lin (Gerrit)

unread,

Nov 27, 2025, 1:32:41 AM11/27/25

to Lingqi Chi, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, tburkar...@chromium.org

Attention needed from Hiroki Nakagawa and Lingqi Chi

Huanpo Lin added 1 comment

File content/browser/preloading/prerender/prerender_host.cc

Line 561, Patchset 5:bool PrerenderHost::StartPrerendering() {

Hiroki Nakagawa . unresolved

This CL supports form submission on matching, but prerender initial navigation still seems to run as non-form submission. Does a follow-up CL implement it?

Huanpo Lin

Yes, it is in the dependent CL https://chromium-review.googlesource.com/c/chromium/src/+/7136943

Open in Gerrit

Related details

Attention is currently required from:

Hiroki Nakagawa
Lingqi Chi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hiroki Nakagawa (Gerrit)

unread,

Nov 28, 2025, 12:57:34 AM11/28/25

to Huanpo Lin, Lingqi Chi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, tburkar...@chromium.org

Attention needed from Huanpo Lin and Lingqi Chi

Hiroki Nakagawa added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Hiroki Nakagawa . resolved

Sorry, I'm packed with tasks that need to be finished today, so my review will be late.

One high level question: Did we reach a consensus on how to manage prerender requests that have the same URL but different form_submission param?

Open in Gerrit

Related details

Attention is currently required from:

Huanpo Lin
Lingqi Chi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lingqi Chi (Gerrit)

unread,

Nov 28, 2025, 1:00:09 AM11/28/25

to Huanpo Lin, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, tburkar...@chromium.org

Attention needed from Hiroki Nakagawa and Huanpo Lin

Lingqi Chi added 1 comment

Patchset-level comments

File-level comment, Patchset 7:

Hiroki Nakagawa . resolved

+lingqi@: Can you review this CL together?

Lingqi Chi

oops, I overlooked it. sure!

Open in Gerrit

Related details

Attention is currently required from:

Hiroki Nakagawa
Huanpo Lin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lingqi Chi (Gerrit)

unread,

Nov 28, 2025, 1:38:30 AM11/28/25

to Huanpo Lin, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, tburkar...@chromium.org

Attention needed from Huanpo Lin

Lingqi Chi added 2 comments

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Lingqi Chi . resolved

Quick question 🙏

Commit Message

Line 11, Patchset 9 (Latest):

Lingqi Chi . unresolved

can you add a brief explanation about the reason why you decided to put it to `MatchUrl` instead of AreInitialPrerenderNavigationParamsCompatibleWithNavigation etc?

Open in Gerrit

Related details

Attention is currently required from:

Huanpo Lin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hiroki Nakagawa (Gerrit)

unread,

Nov 28, 2025, 1:47:49 AM11/28/25

to Huanpo Lin, Lingqi Chi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, tburkar...@chromium.org

Attention needed from Huanpo Lin

Hiroki Nakagawa added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Hiroki Nakagawa . unresolved

Sorry, I'm packed with tasks that need to be finished today, so my review will be late.
One high level question: Did we reach a consensus on how to manage prerender requests that have the same URL but different form_submission param?

Hiroki Nakagawa

unresolved for visibility

satisfied_requirement

unsatisfied_requirement

open

diffy

Huanpo Lin (Gerrit)

unread,

Jun 18, 2026, 2:14:15 AM (11 days ago) Jun 18

to Lingqi Chi, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, tburkar...@chromium.org

Huanpo Lin abandoned this change.

View Change

Abandoned

The change is no longer needed.

Huanpo Lin abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

prerender: Add `form_submission` to MatchUrl and PrerenderInfo [chromium/src : main]

Huanpo Lin (Gerrit)

Huanpo Lin voted and added 1 comment

Votes added by Huanpo Lin

1 comment

Related details

Hiroki Nakagawa (Gerrit)

Hiroki Nakagawa added 2 comments

Related details

Huanpo Lin (Gerrit)

Huanpo Lin added 1 comment

Related details

Hiroki Nakagawa (Gerrit)

Hiroki Nakagawa added 1 comment

Related details

Lingqi Chi (Gerrit)

Lingqi Chi added 1 comment

Related details

Lingqi Chi (Gerrit)

Lingqi Chi added 2 comments

Related details

Hiroki Nakagawa (Gerrit)

Hiroki Nakagawa added 1 comment

Huanpo Lin (Gerrit)

Huanpo Lin abandoned this change

Related details