Fix toast close/menu button icon invisible on hover [chromium/src : main]
0 views
Skip to first unread message
qian zhuoyu (Gerrit)
Apr 11, 2026, 9:46:33 AM (3 days ago) Apr 11
to Alison Gale, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Alison Gale
qian zhuoyu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
qian zhuoyu . resolved
Hello Alison,
Could you please have a look at this change?
Thanks!
Related details
Attention is currently required from:
- Alison Gale
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Gale (Gerrit)
Apr 13, 2026, 9:48:19 AM (yesterday) Apr 13
to Zhuoyu Qian, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org
Attention needed from Zhuoyu Qian
Alison Gale voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alison Gale
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Zhuoyu Qian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhuoyu Qian (Gerrit)
4:06 AM (8 hours ago) 4:06 AM
to Alison Gale, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org
Zhuoyu Qian voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
4:48 AM (7 hours ago) 4:48 AM
to Zhuoyu Qian, Alison Gale, chromium...@chromium.org
chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix toast close/menu button icon invisible on hover
The close and menu buttons in ToastView use
CreateVectorImageButtonWithNativeTheme with kColorToastForeground for
the normal state, but the hovered/pressed state defaults to
kColorIconHovered which has poor contrast on the dark toast background.
Pass kColorToastForeground as the hovered color ID so the icon remains
visible on hover and press.
Before:
https://drive.google.com/file/d/1fykiSp7TE4vXrcGeGN0aDOpbqOr2mD8o
After:
https://drive.google.com/file/d/192Uq7r6-mCJI1llo7AxzDyce3m1uxpyP
Bug: 501295148
Change-Id: I0d28a798a98814670622c740838441cf564e5fc6
Commit-Queue: Zhuoyu Qian <zhuoy...@microsoft.com>
Reviewed-by: Alison Gale <ag...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1614318}
Files:
- M chrome/browser/ui/toasts/toast_view.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alison Gale
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages