Andrew Grieve (Gerrit)

unread,

Apr 20, 2026, 9:22:36 PM (10 days ago) Apr 20

to Andrew Grieve, Junji Watanabe, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Ben Pastene and Haiyang Pan

Andrew Grieve voted and added 1 comment

Votes added by Andrew Grieve

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1:

Ben Pastene . unresolved

Same concern as the other CL: does this GN arg have any expected impact on compile/link times? I'm unfamiliar with the arg, but I imagine it would lead to smaller binaries -> faster links?

Andrew Grieve

Sorry, didn't realize at first that changing it for CI would cause it to change the CQ bots.

But... I think this shouldn't have much impact, as strip_debug_info applies at the link step, but with symbol_level=0, there isn't any debug info to strip in the first place.

This should only impact bots that set symbol_level != 0

Open in Gerrit

Related details

Attention is currently required from:

Ben Pastene
Haiyang Pan

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrew Grieve (Gerrit)

unread,

Apr 20, 2026, 9:26:22 PM (10 days ago) Apr 20

to Andrew Grieve, Junji Watanabe, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Ben Pastene and Haiyang Pan

Andrew Grieve added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Ben Pastene . resolved

Same concern as the other CL: does this GN arg have any expected impact on compile/link times? I'm unfamiliar with the arg, but I imagine it would lead to smaller binaries -> faster links?

Andrew Grieve

Sorry, didn't realize at first that changing it for CI would cause it to change the CQ bots.
But... I think this shouldn't have much impact, as strip_debug_info applies at the link step, but with symbol_level=0, there isn't any debug info to strip in the first place.
This should only impact bots that set symbol_level != 0

Andrew Grieve

Rebased my other CL on this one since they conflict and my guess is that this is less likely to cause issues

Open in Gerrit

Related details

Attention is currently required from:

Ben Pastene
Haiyang Pan

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrew Grieve (Gerrit)

unread,

Apr 21, 2026, 3:12:03 PM (9 days ago) Apr 21

to Andrew Grieve, Junji Watanabe, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Ben Pastene and Haiyang Pan

Andrew Grieve voted and added 1 comment

Votes added by Andrew Grieve

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Andrew Grieve . resolved

ping - okay to go ahead with this one?

satisfied_requirement

unsatisfied_requirement

open

diffy

Haiyang Pan (Gerrit)

unread,

Apr 22, 2026, 12:10:23 PM (8 days ago) Apr 22

to Andrew Grieve, Junji Watanabe, Ben Pastene, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Andrew Grieve and Ben Pastene

Haiyang Pan voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Andrew Grieve
Ben Pastene

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 22, 2026, 1:18:55 PM (8 days ago) Apr 22

to Andrew Grieve, Haiyang Pan, Junji Watanabe, Ben Pastene, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove strip_debug_info from Android  bots that run tests

It causes tests to not show line numbers in stack traces

Before: https://ci.chromium.org/ui/p/chromium/builders/try/android-x64-rel/892829/overview
After: https://ci.chromium.org/ui/p/chromium/builders/try/android-x64-rel/893135/overview

Note that many bots still set symbol_level=0, which makes
strip_debug_info effectively a no-op anyways.

Bug: 503797275

Change-Id: I759b5535c04a46ca03581fd6d453e805e7f36e82

Cq-Include-Trybots: luci.chrome.try:android-internal-dbg,android-internal-binary-size

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7780134

Auto-Submit: Andrew Grieve <agr...@chromium.org>

Reviewed-by: Haiyang Pan <hy...@google.com>

Commit-Queue: Haiyang Pan <hy...@google.com>

Cr-Commit-Position: refs/heads/main@{#1618949}

Files:

M infra/config/generated/builders/build/android-build-perf-ninja/gn-args.json
M infra/config/generated/builders/build/android-build-perf-siso/gn-args.json
M infra/config/generated/builders/ci/android-10-arm64-rel/gn-args.json
M infra/config/generated/builders/ci/android-10-x86-nofieldtrial-rel/gn-args.json
M infra/config/generated/builders/ci/android-10-x86-rel/gn-args.json
M infra/config/generated/builders/ci/android-11-x86-rel/gn-args.json
M infra/config/generated/builders/ci/android-12-x64-rel/gn-args.json
M infra/config/generated/builders/ci/android-12l-x64-rel-cq/gn-args.json
M infra/config/generated/builders/ci/android-13-x64-rel/gn-args.json
M infra/config/generated/builders/ci/android-14-arm64-rel/gn-args.json
M infra/config/generated/builders/ci/android-14-automotive-landscape-x64-rel/gn-args.json
M infra/config/generated/builders/ci/android-14-tablet-landscape-arm64-rel/gn-args.json
M infra/config/generated/builders/ci/android-14-x64-rel/gn-args.json
M infra/config/generated/builders/ci/android-15-tablet-landscape-x64-rel/gn-args.json
M infra/config/generated/builders/ci/android-15-tablet-x64-rel/gn-args.json
M infra/config/generated/builders/ci/android-15-x64-rel/gn-args.json
M infra/config/generated/builders/ci/android-16-x64-rel/gn-args.json
M infra/config/generated/builders/ci/android-arm64-proguard-rel/gn-args.json
M infra/config/generated/builders/ci/android-bfcache-rel/gn-args.json
M infra/config/generated/builders/ci/android-cronet-arm-rel/gn-args.json
M infra/config/generated/builders/ci/android-cronet-arm64-rel/gn-args.json
M infra/config/generated/builders/ci/android-cronet-riscv64-rel/gn-args.json
M infra/config/generated/builders/ci/android-cronet-x64-rel/gn-args.json
M infra/config/generated/builders/ci/android-cronet-x86-rel/gn-args.json
M infra/config/generated/builders/ci/android-mte-arm64-rel/gn-args.json
M infra/config/generated/builders/ci/android-webview-13-x64-hostside-rel/gn-args.json
M infra/config/generated/builders/ci/android-x86-rel/gn-args.json
M infra/config/generated/builders/try/android-10-arm64-rel/gn-args.json
M infra/config/generated/builders/try/android-10-x86-nofieldtrial-rel/gn-args.json
M infra/config/generated/builders/try/android-10-x86-rel/gn-args.json
M infra/config/generated/builders/try/android-11-x86-rel/gn-args.json
M infra/config/generated/builders/try/android-12-x64-rel/gn-args.json
M infra/config/generated/builders/try/android-12l-x64-rel-cq/gn-args.json
M infra/config/generated/builders/try/android-13-x64-rel/gn-args.json
M infra/config/generated/builders/try/android-14-arm64-rel/gn-args.json
M infra/config/generated/builders/try/android-14-automotive-landscape-x64-rel/gn-args.json
M infra/config/generated/builders/try/android-14-tablet-landscape-arm64-rel/gn-args.json
M infra/config/generated/builders/try/android-14-x64-rel/gn-args.json
M infra/config/generated/builders/try/android-15-tablet-landscape-x64-rel/gn-args.json
M infra/config/generated/builders/try/android-15-tablet-x64-rel/gn-args.json
M infra/config/generated/builders/try/android-15-x64-rel/gn-args.json
M infra/config/generated/builders/try/android-16-x64-rel/gn-args.json
M infra/config/generated/builders/try/android-arm64-rel/gn-args.json
M infra/config/generated/builders/try/android-bfcache-rel/gn-args.json
M infra/config/generated/builders/try/android-cronet-arm64-rel/gn-args.json
M infra/config/generated/builders/try/android-cronet-riscv64-rel/gn-args.json
M infra/config/generated/builders/try/android-cronet-x64-rel/gn-args.json
M infra/config/generated/builders/try/android-cronet-x86-rel/gn-args.json
M infra/config/generated/builders/try/android-mte-arm64-rel/gn-args.json
M infra/config/generated/builders/try/android-webview-10-x86-rel-tests/gn-args.json
M infra/config/generated/builders/try/android-webview-13-x64-hostside-rel/gn-args.json
M infra/config/generated/builders/try/android-x64-rel/gn-args.json
M infra/config/generated/builders/try/android-x86-rel/gn-args.json
M infra/config/subprojects/chromium/ci/chromium.android.star

Change size: M

Delta: 54 files changed, 0 insertions(+), 78 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Haiyang Pan

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Mateusz Zbikowski (Gerrit)

unread,

Apr 28, 2026, 11:14:20 AM (2 days ago) Apr 28

to Andrew Grieve, Chromium LUCI CQ, Haiyang Pan, Junji Watanabe, Ben Pastene, chromium...@chromium.org

Mateusz Zbikowski has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Haiyang Pan (Gerrit)

unread,

Apr 28, 2026, 9:08:01 PM (2 days ago) Apr 28

to Andrew Grieve, Chromium LUCI CQ, Junji Watanabe, Ben Pastene, chromium...@chromium.org

Haiyang Pan added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Haiyang Pan . unresolved

Actually this is not a no-op change. The total size of compiled artifacts is almost 3x now:

Before in https://ci.chromium.org/ui/p/chromium/builders/ci/android-10-x86-rel/7730/infra: is about 26GB, took 18 mins (See the "stdout" of the step "isolate tests")
After in https://ci.chromium.org/ui/p/chromium/builders/ci/android-10-x86-rel/7732/infra: is about 88GB, took 40 mins.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Andrew Grieve (Gerrit)

unread,

Apr 28, 2026, 9:59:00 PM (2 days ago) Apr 28

to Andrew Grieve, Chromium LUCI CQ, Haiyang Pan, Junji Watanabe, Ben Pastene, chromium...@chromium.org

Andrew Grieve added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Haiyang Pan . unresolved

Actually this is not a no-op change. The total size of compiled artifacts is almost 3x now:
Before in https://ci.chromium.org/ui/p/chromium/builders/ci/android-10-x86-rel/7730/infra: is about 26GB, took 18 mins (See the "stdout" of the step "isolate tests")
After in https://ci.chromium.org/ui/p/chromium/builders/ci/android-10-x86-rel/7732/infra: is about 88GB, took 40 mins.

Andrew Grieve

That bot sets symbol_level=1, so yeah, it would affect it. It should only not have an effect for bots that set symbol_level=0.

We should really never use strip_debug_info on Android, and I'm not really sure why the flag exists tbh. Setting symbol_level=1 adds overhead to every compile to create debug info, and then strip_debug_info strips the debug info when linking.

E.g. If we're going to throw away the debug info, it's much more efficient to set symbol_level=0 so that the debug info is not generated in the first place.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Andrew Grieve (Gerrit)

unread,

Apr 28, 2026, 10:00:32 PM (2 days ago) Apr 28

to Andrew Grieve, Chromium LUCI CQ, Haiyang Pan, Junji Watanabe, Ben Pastene, chromium...@chromium.org

Andrew Grieve added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Haiyang Pan . unresolved

Actually this is not a no-op change. The total size of compiled artifacts is almost 3x now:
Before in https://ci.chromium.org/ui/p/chromium/builders/ci/android-10-x86-rel/7730/infra: is about 26GB, took 18 mins (See the "stdout" of the step "isolate tests")
After in https://ci.chromium.org/ui/p/chromium/builders/ci/android-10-x86-rel/7732/infra: is about 88GB, took 40 mins.

Andrew Grieve

That bot sets symbol_level=1, so yeah, it would affect it. It should only not have an effect for bots that set symbol_level=0.
We should really never use strip_debug_info on Android, and I'm not really sure why the flag exists tbh. Setting symbol_level=1 adds overhead to every compile to create debug info, and then strip_debug_info strips the debug info when linking.
E.g. If we're going to throw away the debug info, it's much more efficient to set symbol_level=0 so that the debug info is not generated in the first place.

Andrew Grieve

I checked before this that all of the Android trybots set symbol_level=0, except for android-binary-size. I think the symbol_level=0 setting is in the "release_trybot" config, so probably non-trybots have symbol_level=1.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Haiyang Pan (Gerrit)

unread,

Apr 29, 2026, 12:55:26 AM (yesterday) Apr 29

to Andrew Grieve, Chromium LUCI CQ, Junji Watanabe, Ben Pastene, chromium...@chromium.org

Attention needed from Andrew Grieve

Haiyang Pan added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Haiyang Pan . unresolved

Actually this is not a no-op change. The total size of compiled artifacts is almost 3x now:
Before in https://ci.chromium.org/ui/p/chromium/builders/ci/android-10-x86-rel/7730/infra: is about 26GB, took 18 mins (See the "stdout" of the step "isolate tests")
After in https://ci.chromium.org/ui/p/chromium/builders/ci/android-10-x86-rel/7732/infra: is about 88GB, took 40 mins.

Andrew Grieve

That bot sets symbol_level=1, so yeah, it would affect it. It should only not have an effect for bots that set symbol_level=0.
We should really never use strip_debug_info on Android, and I'm not really sure why the flag exists tbh. Setting symbol_level=1 adds overhead to every compile to create debug info, and then strip_debug_info strips the debug info when linking.
E.g. If we're going to throw away the debug info, it's much more efficient to set symbol_level=0 so that the debug info is not generated in the first place.

Andrew Grieve

I checked before this that all of the Android trybots set symbol_level=0, except for android-binary-size. I think the symbol_level=0 setting is in the "release_trybot" config, so probably non-trybots have symbol_level=1.

Haiyang Pan

I see. Thanks. I missed the symbol_level flag.

Setting symbol_level=1 adds overhead to every compile to create debug info, and then strip_debug_info strips the debug info when linking.

LOL, if this is case, +1 for removing `strip_debug_info`

Open in Gerrit

Related details

Attention is currently required from:

Andrew Grieve

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Mateusz Zbikowski (Gerrit)

unread,

Apr 29, 2026, 6:35:31 AM (yesterday) Apr 29

to Andrew Grieve, Chromium LUCI CQ, Haiyang Pan, Junji Watanabe, Ben Pastene, chromium...@chromium.org

Attention needed from Andrew Grieve

Mateusz Zbikowski has created a revert of this change

Open original change

Related details

Attention is currently required from:

Andrew Grieve

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Remove strip_debug_info from Android bots that run tests [chromium/src : main]

Andrew Grieve (Gerrit)

Andrew Grieve voted and added 1 comment

Votes added by Andrew Grieve

1 comment

Related details

Andrew Grieve (Gerrit)

Andrew Grieve added 1 comment

Related details

Andrew Grieve (Gerrit)

Andrew Grieve voted and added 1 comment

Votes added by Andrew Grieve

1 comment

Haiyang Pan (Gerrit)

Haiyang Pan voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Mateusz Zbikowski (Gerrit)

Mateusz Zbikowski has created a revert of this change

Related details

Haiyang Pan (Gerrit)

Haiyang Pan added 1 comment

Related details

Andrew Grieve (Gerrit)

Andrew Grieve added 1 comment

Related details

Andrew Grieve (Gerrit)

Andrew Grieve added 1 comment

Related details

Haiyang Pan (Gerrit)

Haiyang Pan added 1 comment

Related details

Mateusz Zbikowski (Gerrit)

Mateusz Zbikowski has created a revert of this change

Related details