Update AdjustSelection to avoid position inversion [chromium/src : main]

0 views

Skip to first unread message

Sambamurthy Bandaru (Gerrit)

unread,

7:11 AM (5 hours ago) 7:11 AM

to Utkarsh Pathak, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org

Attention needed from Utkarsh Pathak

Sambamurthy Bandaru voted and added 2 comments

Votes added by Sambamurthy Bandaru

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Sambamurthy Bandaru . resolved

LGTM with a nit

File third_party/blink/renderer/core/editing/selection_adjuster_test.cc

Line 601, Patchset 3 (Latest): Element* slotted1 = GetDocument().getElementById(AtomicString("slotted1"));

Sambamurthy Bandaru . unresolved

We can just write `GetElementById()`, which is a method of `PageTestBase`.

Same for all 4 places

Open in Gerrit

Related details

Attention is currently required from:

Utkarsh Pathak

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sambamurthy Bandaru (Gerrit)

unread,

10:06 AM (2 hours ago) 10:06 AM

to Utkarsh Pathak, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org

Attention needed from Kent Tamura and Utkarsh Pathak

Sambamurthy Bandaru voted Code-Review+1