Update AdjustSelection to avoid position inversion [chromium/src : main]

0 views
Skip to first unread message

Sambamurthy Bandaru (Gerrit)

unread,
7:11 AM (5 hours ago) 7:11 AM
to Utkarsh Pathak, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Utkarsh Pathak

Sambamurthy Bandaru voted and added 2 comments

Votes added by Sambamurthy Bandaru

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Sambamurthy Bandaru . resolved

LGTM with a nit

File third_party/blink/renderer/core/editing/selection_adjuster_test.cc
Line 601, Patchset 3 (Latest): Element* slotted1 = GetDocument().getElementById(AtomicString("slotted1"));
Sambamurthy Bandaru . unresolved

We can just write `GetElementById()`, which is a method of `PageTestBase`.

Same for all 4 places

Open in Gerrit

Related details

Attention is currently required from:
  • Utkarsh Pathak
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I30464ab2b9271bdfdc6b6804bac58e746e4394a1
Gerrit-Change-Number: 7673679
Gerrit-PatchSet: 3
Gerrit-Owner: Utkarsh Pathak <utpa...@microsoft.com>
Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Reviewer: Utkarsh Pathak <utpa...@microsoft.com>
Gerrit-Attention: Utkarsh Pathak <utpa...@microsoft.com>
Gerrit-Comment-Date: Mon, 23 Mar 2026 11:10:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sambamurthy Bandaru (Gerrit)

unread,
10:06 AM (2 hours ago) 10:06 AM
to Utkarsh Pathak, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura and Utkarsh Pathak

Sambamurthy Bandaru voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
  • Utkarsh Pathak
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I30464ab2b9271bdfdc6b6804bac58e746e4394a1
Gerrit-Change-Number: 7673679
Gerrit-PatchSet: 4
Gerrit-Owner: Utkarsh Pathak <utpa...@microsoft.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Reviewer: Utkarsh Pathak <utpa...@microsoft.com>
Gerrit-Attention: Utkarsh Pathak <utpa...@microsoft.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 14:06:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages