Clean up stale base::Feature ArcLockGuestMemory [chromium/src : main]
0 views
Skip to first unread message
Javier Garcia Visiedo (Gerrit)
Apr 16, 2026, 5:18:25 AMApr 16
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, dullweb...@chromium.org, hidehik...@chromium.org, msrame...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Javier Garcia Visiedo abandoned this change.
Abandoned
Wrong commit
Javier Garcia Visiedo abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Javier Garcia Visiedo (Gerrit)
Apr 16, 2026, 6:03:39 AMApr 16
to Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Hidehiko Abe and Nico Weber
Javier Garcia Visiedo voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Hidehiko Abe
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Apr 16, 2026, 9:04:04 AMApr 16
to Javier Garcia Visiedo, Junichi Uekawa, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Javier Garcia Visiedo, Junichi Uekawa and Nico Weber
Hidehiko Abe added 1 comment![]( "Open in Gerrit")
File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
Line 391, Patchset 2 (Parent):
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Hidehiko Abe . unresolved
Junichi, could you double check if this is no longer checked in ARCVM guest OS?
Related details
Attention is currently required from:
- Javier Garcia Visiedo
- Junichi Uekawa
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Junichi Uekawa (Gerrit)
Apr 19, 2026, 10:35:57 PMApr 19
to Javier Garcia Visiedo, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Javier Garcia Visiedo and Nico Weber
Junichi Uekawa added 1 comment![]( "Open in Gerrit")
File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
Line 391, Patchset 2 (Parent):
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Hidehiko Abe . unresolved
Junichi, could you double check if this is no longer checked in ARCVM guest OS?
Attention is currently required from:
- Javier Garcia Visiedo
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Javier Garcia Visiedo (Gerrit)
Apr 20, 2026, 5:12:49 AMApr 20
to Junichi Uekawa, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Hidehiko Abe, Junichi Uekawa and Nico Weber
Javier Garcia Visiedo added 1 comment![]( "Open in Gerrit")
File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
Line 391, Patchset 2 (Parent):
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Hidehiko Abe . unresolved
Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
it's being checked still
Attention is currently required from:
- Hidehiko Abe
- Junichi Uekawa
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Apr 20, 2026, 8:21:29 PMApr 20
to Javier Garcia Visiedo, Junichi Uekawa, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Javier Garcia Visiedo, Junichi Uekawa and Nico Weber
Hidehiko Abe added 1 comment![]( "Open in Gerrit")
File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
Line 391, Patchset 2 (Parent):
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Hidehiko Abe . unresolved
Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
Javier Garcia Visiedoit's being checked still
So this feature isn't safe to remove yet?
Hidehiko Abe
it means
```
vm_builder.AppendCustomParam("--lock-guest-memory", "");
```
needs to run regardless of the lock_guest_memory() condition in the service first,
then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
Related details
Attention is currently required from:
- Javier Garcia Visiedo
- Junichi Uekawa
- Nico Weber
Javier Garcia Visiedo (Gerrit)
Apr 20, 2026, 9:19:57 PMApr 20
to Junichi Uekawa, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Hidehiko Abe, Junichi Uekawa and Nico Weber
Javier Garcia Visiedo added 1 comment![]( "Open in Gerrit")
File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
Line 391, Patchset 2 (Parent):
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Hidehiko Abe . unresolved
Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
Javier Garcia Visiedoit's being checked still
Hidehiko AbeSo this feature isn't safe to remove yet?
it means
```
vm_builder.AppendCustomParam("--lock-guest-memory", "");
```
needs to run regardless of the lock_guest_memory() condition in the service first,
then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
Javier Garcia Visiedo
Thanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.
Since this feature is still actively checked in the ChromeOS concierge service.
I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.
Related details
Attention is currently required from:
- Hidehiko Abe
- Junichi Uekawa
- Nico Weber
Junichi Uekawa (Gerrit)
Apr 20, 2026, 9:29:05 PMApr 20
to Javier Garcia Visiedo, Alexandre Marciano Gimenez, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Alexandre Marciano Gimenez, Hidehiko Abe, Javier Garcia Visiedo and Nico Weber
Junichi Uekawa added 1 comment![]( "Open in Gerrit")
File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
Line 391, Patchset 2 (Parent):
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Hidehiko Abe . unresolved
Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
Javier Garcia Visiedoit's being checked still
Hidehiko AbeSo this feature isn't safe to remove yet?
Javier Garcia Visiedoit means
```
vm_builder.AppendCustomParam("--lock-guest-memory", "");
```
needs to run regardless of the lock_guest_memory() condition in the service first,
then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
Thanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.
Since this feature is still actively checked in the ChromeOS concierge service.
I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.
Attention is currently required from:
- Alexandre Marciano Gimenez
- Hidehiko Abe
- Javier Garcia Visiedo
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Javier Garcia Visiedo (Gerrit)
Apr 22, 2026, 4:34:52 AMApr 22
to Alexandre Marciano Gimenez, Junichi Uekawa, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Alexandre Marciano Gimenez, Hidehiko Abe, Junichi Uekawa and Nico Weber
Javier Garcia Visiedo added 1 comment![]( "Open in Gerrit")
File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
Line 391, Patchset 2 (Parent):
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Hidehiko Abe . unresolved
Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
Javier Garcia Visiedoit's being checked still
Hidehiko AbeSo this feature isn't safe to remove yet?
Javier Garcia Visiedoit means
```
vm_builder.AppendCustomParam("--lock-guest-memory", "");
```
needs to run regardless of the lock_guest_memory() condition in the service first,
then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
Junichi UekawaThanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.
Since this feature is still actively checked in the ChromeOS concierge service.
I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.
is this default on or off ? @rag...@google.com
Attention is currently required from:
- Alexandre Marciano Gimenez
- Hidehiko Abe
- Junichi Uekawa
- Nico Weber
Junichi Uekawa (Gerrit)
Apr 27, 2026, 7:48:06 AMApr 27
to Javier Garcia Visiedo, Code Review Nudger, Alexandre Marciano Gimenez, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Alexandre Marciano Gimenez, Hidehiko Abe, Javier Garcia Visiedo and Nico Weber
Junichi Uekawa voted and added 1 comment![]( "Open in Gerrit")
Votes added by Junichi Uekawa
| Code-Review | +1 |
1 comment
File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
Line 391, Patchset 2 (Parent):
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Hidehiko Abe . resolved
Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
Javier Garcia Visiedoit's being checked still
Hidehiko AbeSo this feature isn't safe to remove yet?
Javier Garcia Visiedoit means
```
vm_builder.AppendCustomParam("--lock-guest-memory", "");
```
needs to run regardless of the lock_guest_memory() condition in the service first,
then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
Junichi UekawaThanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.
Since this feature is still actively checked in the ChromeOS concierge service.
I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.
Javier Garcia Visiedois this default on or off ? @rag...@google.com
Disabled by default: https://source.chromium.org/chromium/chromium/src/+/main:chromeos/ash/experiences/arc/arc_features.cc;drc=1f768fd470e6e23e0e5b79e3921a569f47793ba9;l=204
Attention is currently required from:
- Alexandre Marciano Gimenez
- Hidehiko Abe
- Javier Garcia Visiedo
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Apr 27, 2026, 12:22:23 PMApr 27
to Javier Garcia Visiedo, Junichi Uekawa, Code Review Nudger, Alexandre Marciano Gimenez, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Alexandre Marciano Gimenez, Javier Garcia Visiedo and Nico Weber
Hidehiko Abe voted and added 3 comments![]( "Open in Gerrit")
Votes added by Hidehiko Abe
| Code-Review | +1 |
3 comments
Patchset-level comments
File chrome/browser/performance_manager/mechanisms/working_set_trimmer_chromeos_unittest.cc
File chromeos/ash/experiences/arc/arc_features.h
Related details
Attention is currently required from:
- Alexandre Marciano Gimenez
- Javier Garcia Visiedo
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
May 6, 2026, 8:10:10 PM (8 days ago) May 6
to Javier Garcia Visiedo, Junichi Uekawa, Code Review Nudger, Alexandre Marciano Gimenez, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Alexandre Marciano Gimenez, Javier Garcia Visiedo, Junichi Uekawa and Nico Weber
Hidehiko Abe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hidehiko Abe
| Code-Review | +1 |
Attention is currently required from:
- Alexandre Marciano Gimenez
- Javier Garcia Visiedo
- Junichi Uekawa
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Junichi Uekawa (Gerrit)
May 11, 2026, 3:01:26 AM (3 days ago) May 11
to Javier Garcia Visiedo, Hidehiko Abe, Code Review Nudger, Alexandre Marciano Gimenez, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Alexandre Marciano Gimenez, Javier Garcia Visiedo and Nico Weber
Junichi Uekawa voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexandre Marciano Gimenez
- Javier Garcia Visiedo
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Javier Garcia Visiedo (Gerrit)
May 11, 2026, 5:27:12 AM (3 days ago) May 11
to Junichi Uekawa, Hidehiko Abe, Code Review Nudger, Alexandre Marciano Gimenez, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Alexandre Marciano Gimenez and Nico Weber
Javier Garcia Visiedo added 2 comments![]( "Open in Gerrit")
File chrome/browser/performance_manager/mechanisms/working_set_trimmer_chromeos_unittest.cc
nit/style: only one line should be enough.
Javier Garcia Visiedo
Done
File chromeos/ash/experiences/arc/arc_features.h
nit: please remove the empty line here.
Attention is currently required from:
- Alexandre Marciano Gimenez
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Javier Garcia Visiedo (Gerrit)
May 11, 2026, 5:27:15 AM (3 days ago) May 11
to Junichi Uekawa, Hidehiko Abe, Code Review Nudger, Alexandre Marciano Gimenez, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Alexandre Marciano Gimenez and Nico Weber
Javier Garcia Visiedo voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
May 11, 2026, 5:31:27 AM (3 days ago) May 11
to Javier Garcia Visiedo, Junichi Uekawa, Hidehiko Abe, Code Review Nudger, Alexandre Marciano Gimenez, Nico Weber, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Clean up stale base::Feature ArcLockGuestMemory
This CL removes the stale base::Feature ArcLockGuestMemory and its
associated code from the codebase. The feature was used to control guest
memory locking in ARCVM.
No stale entries found in
`testing/variations/fieldtrial_testing_config.json`
Bug: 356233968
Change-Id: If976209036058829ead437332e3ffce085d901c8
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Commit-Queue: Javier Garcia Visiedo <vis...@google.com>
Reviewed-by: Junichi Uekawa <uek...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1628442}
Files:
- M chrome/browser/ash/arc/vmm/arcvm_working_set_trim_executor.cc
- M chrome/browser/performance_manager/mechanisms/working_set_trimmer_chromeos_unittest.cc
- M chromeos/ash/experiences/arc/arc_features.cc
- M chromeos/ash/experiences/arc/arc_features.h
- M chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
- M chromeos/ash/experiences/arc/session/arc_vm_client_adapter_unittest.cc
Change size: M
Delta: 6 files changed, 4 insertions(+), 50 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Junichi Uekawa, +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages