Javier Garcia Visiedo abandoned this change.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Junichi, could you double check if this is no longer checked in ARCVM guest OS?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Junichi, could you double check if this is no longer checked in ARCVM guest OS?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
it's being checked still
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
Javier Garcia Visiedoit's being checked still
So this feature isn't safe to remove yet?
it means
```
vm_builder.AppendCustomParam("--lock-guest-memory", "");
```
needs to run regardless of the lock_guest_memory() condition in the service first,
then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
Javier Garcia Visiedoit's being checked still
Hidehiko AbeSo this feature isn't safe to remove yet?
it means
```
vm_builder.AppendCustomParam("--lock-guest-memory", "");
```
needs to run regardless of the lock_guest_memory() condition in the service first,
then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
Thanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.
Since this feature is still actively checked in the ChromeOS concierge service.
I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
Javier Garcia Visiedoit's being checked still
Hidehiko AbeSo this feature isn't safe to remove yet?
Javier Garcia Visiedoit means
```
vm_builder.AppendCustomParam("--lock-guest-memory", "");
```
needs to run regardless of the lock_guest_memory() condition in the service first,
then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
Thanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.
Since this feature is still actively checked in the ChromeOS concierge service.
I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
Javier Garcia Visiedoit's being checked still
Hidehiko AbeSo this feature isn't safe to remove yet?
Javier Garcia Visiedoit means
```
vm_builder.AppendCustomParam("--lock-guest-memory", "");
```
needs to run regardless of the lock_guest_memory() condition in the service first,
then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
Junichi UekawaThanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.
Since this feature is still actively checked in the ChromeOS concierge service.
I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.
is this default on or off ? @rag...@google.com
| Code-Review | +1 |
request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));Junichi UekawaJunichi, could you double check if this is no longer checked in ARCVM guest OS?
Javier Garcia Visiedoit's being checked still
Hidehiko AbeSo this feature isn't safe to remove yet?
Javier Garcia Visiedoit means
```
vm_builder.AppendCustomParam("--lock-guest-memory", "");
```
needs to run regardless of the lock_guest_memory() condition in the service first,
then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
Junichi UekawaThanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.
Since this feature is still actively checked in the ChromeOS concierge service.
I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.
Javier Garcia Visiedois this default on or off ? @rag...@google.com
Disabled by default: https://source.chromium.org/chromium/chromium/src/+/main:chromeos/ash/experiences/arc/arc_features.cc;drc=1f768fd470e6e23e0e5b79e3921a569f47793ba9;l=204
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |