Clean up stale base::Feature ArcLockGuestMemory [chromium/src : main]

0 views
Skip to first unread message

Javier Garcia Visiedo (Gerrit)

unread,
Apr 16, 2026, 5:18:25 AMApr 16
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, dullweb...@chromium.org, hidehik...@chromium.org, msrame...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org

Javier Garcia Visiedo abandoned this change.

View Change

Abandoned Wrong commit

Javier Garcia Visiedo abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I071420b8d725cd18e9a884995a823bb22a1bd0a0
Gerrit-Change-Number: 7767873
Gerrit-PatchSet: 1
Gerrit-Owner: Javier Garcia Visiedo <vis...@google.com>
Gerrit-Reviewer: Javier Garcia Visiedo <vis...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Javier Garcia Visiedo (Gerrit)

unread,
Apr 16, 2026, 6:03:39 AMApr 16
to Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Hidehiko Abe and Nico Weber

Javier Garcia Visiedo voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If976209036058829ead437332e3ffce085d901c8
Gerrit-Change-Number: 7768449
Gerrit-PatchSet: 2
Gerrit-Owner: Javier Garcia Visiedo <vis...@google.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Javier Garcia Visiedo <vis...@google.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Apr 2026 10:03:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Apr 16, 2026, 9:04:04 AMApr 16
to Javier Garcia Visiedo, Junichi Uekawa, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
Attention needed from Javier Garcia Visiedo, Junichi Uekawa and Nico Weber

Hidehiko Abe added 1 comment

File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
Line 391, Patchset 2 (Parent): request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));
Hidehiko Abe . unresolved

Junichi, could you double check if this is no longer checked in ARCVM guest OS?

Open in Gerrit

Related details

Attention is currently required from:
  • Javier Garcia Visiedo
  • Junichi Uekawa
  • Nico Weber
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If976209036058829ead437332e3ffce085d901c8
    Gerrit-Change-Number: 7768449
    Gerrit-PatchSet: 2
    Gerrit-Owner: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Reviewer: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Attention: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Attention: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Comment-Date: Thu, 16 Apr 2026 13:03:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Junichi Uekawa (Gerrit)

    unread,
    Apr 19, 2026, 10:35:57 PM (11 days ago) Apr 19
    to Javier Garcia Visiedo, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
    Attention needed from Javier Garcia Visiedo and Nico Weber

    Junichi Uekawa added 1 comment

    File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
    Line 391, Patchset 2 (Parent): request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));
    Hidehiko Abe . unresolved

    Junichi, could you double check if this is no longer checked in ARCVM guest OS?

    Attention is currently required from:
    • Javier Garcia Visiedo
    • Nico Weber
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If976209036058829ead437332e3ffce085d901c8
    Gerrit-Change-Number: 7768449
    Gerrit-PatchSet: 2
    Gerrit-Owner: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Reviewer: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Attention: Nico Weber <tha...@chromium.org>
    Gerrit-Attention: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Comment-Date: Mon, 20 Apr 2026 02:35:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Javier Garcia Visiedo (Gerrit)

    unread,
    Apr 20, 2026, 5:12:49 AM (11 days ago) Apr 20
    to Junichi Uekawa, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
    Attention needed from Hidehiko Abe, Junichi Uekawa and Nico Weber

    Javier Garcia Visiedo added 1 comment

    File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
    Line 391, Patchset 2 (Parent): request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));
    Hidehiko Abe . unresolved

    Junichi, could you double check if this is no longer checked in ARCVM guest OS?

    Junichi Uekawa

    it's being checked still

    https://source.chromium.org/chromiumos/chromiumos/codesearch/+/HEAD:src/platform2/vm_tools/concierge/service_arc.cc;l=644

    Javier Garcia Visiedo

    So this feature isn't safe to remove yet?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hidehiko Abe
    • Junichi Uekawa
    • Nico Weber
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If976209036058829ead437332e3ffce085d901c8
    Gerrit-Change-Number: 7768449
    Gerrit-PatchSet: 2
    Gerrit-Owner: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Reviewer: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Attention: Nico Weber <tha...@chromium.org>
    Gerrit-Attention: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Mon, 20 Apr 2026 09:12:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Junichi Uekawa <uek...@chromium.org>
    Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hidehiko Abe (Gerrit)

    unread,
    Apr 20, 2026, 8:21:29 PM (10 days ago) Apr 20
    to Javier Garcia Visiedo, Junichi Uekawa, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
    Attention needed from Javier Garcia Visiedo, Junichi Uekawa and Nico Weber

    Hidehiko Abe added 1 comment

    File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
    Line 391, Patchset 2 (Parent): request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));
    Hidehiko Abe . unresolved

    Junichi, could you double check if this is no longer checked in ARCVM guest OS?

    Junichi Uekawa

    it's being checked still

    https://source.chromium.org/chromiumos/chromiumos/codesearch/+/HEAD:src/platform2/vm_tools/concierge/service_arc.cc;l=644

    Javier Garcia Visiedo

    So this feature isn't safe to remove yet?

    Hidehiko Abe
    it means
    ```
    vm_builder.AppendCustomParam("--lock-guest-memory", "");
    ```
    needs to run regardless of the lock_guest_memory() condition in the service first,
    then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Javier Garcia Visiedo
    • Junichi Uekawa
    • Nico Weber
    Gerrit-Attention: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Attention: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 00:21:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Javier Garcia Visiedo <vis...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Javier Garcia Visiedo (Gerrit)

    unread,
    Apr 20, 2026, 9:19:57 PM (10 days ago) Apr 20
    to Junichi Uekawa, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
    Attention needed from Hidehiko Abe, Junichi Uekawa and Nico Weber

    Javier Garcia Visiedo added 1 comment

    File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
    Line 391, Patchset 2 (Parent): request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));
    Hidehiko Abe . unresolved

    Junichi, could you double check if this is no longer checked in ARCVM guest OS?

    Junichi Uekawa

    it's being checked still

    https://source.chromium.org/chromiumos/chromiumos/codesearch/+/HEAD:src/platform2/vm_tools/concierge/service_arc.cc;l=644

    Javier Garcia Visiedo

    So this feature isn't safe to remove yet?

    Hidehiko Abe
    it means
    ```
    vm_builder.AppendCustomParam("--lock-guest-memory", "");
    ```
    needs to run regardless of the lock_guest_memory() condition in the service first,
    then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
    Javier Garcia Visiedo

    Thanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.

    Since this feature is still actively checked in the ChromeOS concierge service.

    I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hidehiko Abe
    • Junichi Uekawa
    • Nico Weber
    Gerrit-Attention: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 01:19:19 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Junichi Uekawa (Gerrit)

    unread,
    Apr 20, 2026, 9:29:05 PM (10 days ago) Apr 20
    to Javier Garcia Visiedo, Alexandre Marciano Gimenez, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
    Attention needed from Alexandre Marciano Gimenez, Hidehiko Abe, Javier Garcia Visiedo and Nico Weber

    Junichi Uekawa added 1 comment

    File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
    Line 391, Patchset 2 (Parent): request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));
    Hidehiko Abe . unresolved

    Junichi, could you double check if this is no longer checked in ARCVM guest OS?

    Junichi Uekawa

    it's being checked still

    https://source.chromium.org/chromiumos/chromiumos/codesearch/+/HEAD:src/platform2/vm_tools/concierge/service_arc.cc;l=644

    Javier Garcia Visiedo

    So this feature isn't safe to remove yet?

    Hidehiko Abe
    it means
    ```
    vm_builder.AppendCustomParam("--lock-guest-memory", "");
    ```
    needs to run regardless of the lock_guest_memory() condition in the service first,
    then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
    Javier Garcia Visiedo

    Thanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.

    Since this feature is still actively checked in the ChromeOS concierge service.

    I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.

    Junichi Uekawa

    is this default on or off ? @rag...@google.com

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexandre Marciano Gimenez
    • Hidehiko Abe
    • Javier Garcia Visiedo
    • Nico Weber
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If976209036058829ead437332e3ffce085d901c8
    Gerrit-Change-Number: 7768449
    Gerrit-PatchSet: 2
    Gerrit-Owner: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Reviewer: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-CC: Alexandre Marciano Gimenez <rag...@google.com>
    Gerrit-Attention: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-Attention: Alexandre Marciano Gimenez <rag...@google.com>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 01:28:26 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Javier Garcia Visiedo (Gerrit)

    unread,
    Apr 22, 2026, 4:34:52 AM (9 days ago) Apr 22
    to Alexandre Marciano Gimenez, Junichi Uekawa, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
    Attention needed from Alexandre Marciano Gimenez, Hidehiko Abe, Junichi Uekawa and Nico Weber

    Javier Garcia Visiedo added 1 comment

    File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
    Line 391, Patchset 2 (Parent): request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));
    Hidehiko Abe . unresolved

    Junichi, could you double check if this is no longer checked in ARCVM guest OS?

    Junichi Uekawa

    it's being checked still

    https://source.chromium.org/chromiumos/chromiumos/codesearch/+/HEAD:src/platform2/vm_tools/concierge/service_arc.cc;l=644

    Javier Garcia Visiedo

    So this feature isn't safe to remove yet?

    Hidehiko Abe
    it means
    ```
    vm_builder.AppendCustomParam("--lock-guest-memory", "");
    ```
    needs to run regardless of the lock_guest_memory() condition in the service first,
    then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
    Javier Garcia Visiedo

    Thanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.

    Since this feature is still actively checked in the ChromeOS concierge service.

    I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.

    Junichi Uekawa

    is this default on or off ? @rag...@google.com

    Attention is currently required from:
    • Alexandre Marciano Gimenez
    • Hidehiko Abe
    • Junichi Uekawa
    • Nico Weber
    Gerrit-Attention: Junichi Uekawa <uek...@chromium.org>
    Gerrit-Attention: Alexandre Marciano Gimenez <rag...@google.com>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Wed, 22 Apr 2026 08:34:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Junichi Uekawa <uek...@chromium.org>
    Comment-In-Reply-To: Javier Garcia Visiedo <vis...@google.com>
    Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Junichi Uekawa (Gerrit)

    unread,
    Apr 27, 2026, 7:48:06 AM (4 days ago) Apr 27
    to Javier Garcia Visiedo, Code Review Nudger, Alexandre Marciano Gimenez, Hidehiko Abe, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
    Attention needed from Alexandre Marciano Gimenez, Hidehiko Abe, Javier Garcia Visiedo and Nico Weber

    Junichi Uekawa voted and added 1 comment

    Votes added by Junichi Uekawa

    Code-Review+1

    1 comment

    File chromeos/ash/experiences/arc/session/arc_vm_client_adapter.cc
    Line 391, Patchset 2 (Parent): request.set_lock_guest_memory(base::FeatureList::IsEnabled(kLockGuestMemory));
    Hidehiko Abe . resolved

    Junichi, could you double check if this is no longer checked in ARCVM guest OS?

    Junichi Uekawa

    it's being checked still

    https://source.chromium.org/chromiumos/chromiumos/codesearch/+/HEAD:src/platform2/vm_tools/concierge/service_arc.cc;l=644

    Javier Garcia Visiedo

    So this feature isn't safe to remove yet?

    Hidehiko Abe
    it means
    ```
    vm_builder.AppendCustomParam("--lock-guest-memory", "");
    ```
    needs to run regardless of the lock_guest_memory() condition in the service first,
    then this code can be removed. Finally, we'd clean up the protobuf schema by removing the field.
    Javier Garcia Visiedo

    Thanks for looking into this and pointing out the dependency, hidehiko@ and uekawa@.

    Since this feature is still actively checked in the ChromeOS concierge service.

    I'll wait until the cleanup on the ChromeOS side is completed before resuming this CL to remove the feature flag from the Chrome side.

    Junichi Uekawa

    is this default on or off ? @rag...@google.com

    Javier Garcia Visiedo

    Disabled by default: https://source.chromium.org/chromium/chromium/src/+/main:chromeos/ash/experiences/arc/arc_features.cc;drc=1f768fd470e6e23e0e5b79e3921a569f47793ba9;l=204

    Junichi Uekawa

    Acknowledged

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexandre Marciano Gimenez
    • Hidehiko Abe
    • Javier Garcia Visiedo
    • Nico Weber
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If976209036058829ead437332e3ffce085d901c8
      Gerrit-Change-Number: 7768449
      Gerrit-PatchSet: 2
      Gerrit-Owner: Javier Garcia Visiedo <vis...@google.com>
      Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Reviewer: Javier Garcia Visiedo <vis...@google.com>
      Gerrit-Reviewer: Junichi Uekawa <uek...@chromium.org>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-CC: Alexandre Marciano Gimenez <rag...@google.com>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-Attention: Javier Garcia Visiedo <vis...@google.com>
      Gerrit-Attention: Alexandre Marciano Gimenez <rag...@google.com>
      Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Comment-Date: Mon, 27 Apr 2026 11:47:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Javier Garcia Visiedo <vis...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Hidehiko Abe (Gerrit)

      unread,
      Apr 27, 2026, 12:22:23 PM (3 days ago) Apr 27
      to Javier Garcia Visiedo, Junichi Uekawa, Code Review Nudger, Alexandre Marciano Gimenez, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org
      Attention needed from Alexandre Marciano Gimenez, Javier Garcia Visiedo and Nico Weber

      Hidehiko Abe voted and added 3 comments

      Votes added by Hidehiko Abe

      Code-Review+1

      3 comments

      Patchset-level comments
      File-level comment, Patchset 2 (Latest):
      Hidehiko Abe . resolved

      LGTM with comments.

      File chrome/browser/performance_manager/mechanisms/working_set_trimmer_chromeos_unittest.cc
      Line 344, Patchset 2 (Latest):
      Hidehiko Abe . unresolved

      nit/style: only one line should be enough.

      File chromeos/ash/experiences/arc/arc_features.h
      Line 48, Patchset 2 (Latest):
      Hidehiko Abe . unresolved

      nit: please remove the empty line here.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alexandre Marciano Gimenez
      • Javier Garcia Visiedo
      • Nico Weber
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If976209036058829ead437332e3ffce085d901c8
        Gerrit-Change-Number: 7768449
        Gerrit-PatchSet: 2
        Gerrit-Owner: Javier Garcia Visiedo <vis...@google.com>
        Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
        Gerrit-Reviewer: Javier Garcia Visiedo <vis...@google.com>
        Gerrit-Reviewer: Junichi Uekawa <uek...@chromium.org>
        Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
        Gerrit-CC: Alexandre Marciano Gimenez <rag...@google.com>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-Attention: Nico Weber <tha...@chromium.org>
        Gerrit-Attention: Javier Garcia Visiedo <vis...@google.com>
        Gerrit-Attention: Alexandre Marciano Gimenez <rag...@google.com>
        Gerrit-Comment-Date: Mon, 27 Apr 2026 16:21:53 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages