[CrossDevicePrefTracker] Introduce OnServiceStatusChanged [chromium/src : main]

0 views
Skip to first unread message

Benjamin Williams (Gerrit)

unread,
8:01 PM (3 hours ago) 8:01 PM
to Scott Yoder, Jenna Himawan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Scott Yoder

Benjamin Williams voted and added 1 comment

Votes added by Benjamin Williams

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Benjamin Williams . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Scott Yoder
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iefa31a28bbb595173b8fbf2b851b4d6efef66227
Gerrit-Change-Number: 7466924
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Williams <bwwil...@google.com>
Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>
Gerrit-Reviewer: Scott Yoder <scott...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Jenna Himawan <jhim...@google.com>
Gerrit-Attention: Scott Yoder <scott...@google.com>
Gerrit-Comment-Date: Wed, 14 Jan 2026 01:01:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Scott Yoder (Gerrit)

unread,
8:40 PM (2 hours ago) 8:40 PM
to Benjamin Williams, Jenna Himawan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Benjamin Williams

Scott Yoder voted and added 1 comment

Votes added by Scott Yoder

Code-Review+1

1 comment

Patchset-level comments
Scott Yoder . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Williams
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iefa31a28bbb595173b8fbf2b851b4d6efef66227
    Gerrit-Change-Number: 7466924
    Gerrit-PatchSet: 2
    Gerrit-Owner: Benjamin Williams <bwwil...@google.com>
    Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>
    Gerrit-Reviewer: Scott Yoder <scott...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Jenna Himawan <jhim...@google.com>
    Gerrit-Attention: Benjamin Williams <bwwil...@google.com>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 01:40:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages